Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Jörg Schaible
Gary Gregory wrote: > On Fri, Oct 12, 2012 at 9:39 AM, sebb wrote: > >> On 12 October 2012 13:38, Gary Gregory wrote: >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter > >wrote: [snip] >> >> > >> >> > +private static final char COMMENT = '#'; >> >> >> >> How about COMMENT_START ? >> >

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter
2012/10/12 Gary Gregory : > On Fri, Oct 12, 2012 at 9:56 AM, sebb wrote: > >> On 12 October 2012 14:50, Gary Gregory wrote: >> > On Fri, Oct 12, 2012 at 9:39 AM, sebb wrote: >> > >> >> On 12 October 2012 13:38, Gary Gregory wrote: >> >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter < >> be

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory
On Fri, Oct 12, 2012 at 9:56 AM, sebb wrote: > On 12 October 2012 14:50, Gary Gregory wrote: > > On Fri, Oct 12, 2012 at 9:39 AM, sebb wrote: > > > >> On 12 October 2012 13:38, Gary Gregory wrote: > >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter < > benerit...@gmail.com > >> >wrote: > >

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread sebb
On 12 October 2012 14:50, Gary Gregory wrote: > On Fri, Oct 12, 2012 at 9:39 AM, sebb wrote: > >> On 12 October 2012 13:38, Gary Gregory wrote: >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter > >wrote: >> > >> >> Hi >> >> >> >> 2012/10/12 : >> >> > Author: ggregory >> >> > Date: Fri Oct 1

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory
On Fri, Oct 12, 2012 at 9:39 AM, sebb wrote: > On 12 October 2012 13:38, Gary Gregory wrote: > > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter >wrote: > > > >> Hi > >> > >> 2012/10/12 : > >> > Author: ggregory > >> > Date: Fri Oct 12 12:12:44 2012 > >> > New Revision: 1397534 > >> > > >> >

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread sebb
On 12 October 2012 13:38, Gary Gregory wrote: > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter wrote: > >> Hi >> >> 2012/10/12 : >> > Author: ggregory >> > Date: Fri Oct 12 12:12:44 2012 >> > New Revision: 1397534 >> > >> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev >> > Log: >> > R

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory
On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter wrote: > Hi > > 2012/10/12 : > > Author: ggregory > > Date: Fri Oct 12 12:12:44 2012 > > New Revision: 1397534 > > > > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev > > Log: > > Refactor magic strings into constants. > > > > Modified: > >

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter
Hi 2012/10/12 : > Author: ggregory > Date: Fri Oct 12 12:12:44 2012 > New Revision: 1397534 > > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev > Log: > Refactor magic strings into constants. > > Modified: > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.ja