Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 17 March 2013 13:18, Simone Tripodi wrote: >>> /** >>> + * the decoding table size. >>> + */ >>> +private static final int DECODING_TABLE_SIZE = 256; >>> + >> >> The Javadoc does not say why the value 256 is used, so the number is >> still a magic number ... >> > > What should

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread Simone Tripodi
>> /** >> + * the decoding table size. >> + */ >> +private static final int DECODING_TABLE_SIZE = 256; >> + > > The Javadoc does not say why the value 256 is used, so the number is > still a magic number ... > What should be added more than `the decoding table size` in javadoc? I'

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 15 March 2013 10:37, wrote: > Author: simonetripodi > Date: Fri Mar 15 10:37:01 2013 > New Revision: 1456871 > > URL: http://svn.apache.org/r1456871 > Log: > checkstyle: '256' is a magic number. > > Modified: > > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/