[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/16 Oh pardon. I misread. I’ll re-run through it. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

Fixed in git master. Gary On Fri, Sep 22, 2017 at 3:35 PM, Pascal Schumacher wrote: > Builds on travis fail: > > [INFO] There are 6 checkstyle errors. > [ERROR] StrLookup.java[119] (regexp) RegexpSingleline: Line has trailing > spaces. > [ERROR] StrLookup.java[125]

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/16 Oh pardon. I misread. I’ll re-run through it. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[GitHub] commons-cli pull request #14: Added BugCLI260 JUnit Test

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #14: Added BugCLI260 JUnit Test

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #17: Tweak Javadoc spelling

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/17 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #18: .travis.yml: install open-jdk6, as it was remo...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/18 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #18: .travis.yml: install open-jdk6, as it was remo...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/18 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #17: Tweak Javadoc spelling

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/17 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140526276 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,13 +615,11 @@ public static String swapCase(final String str) {

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140526804 --- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java --- @@ -46,6 +46,7 @@ * This constructor is public to permit

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140528491 --- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java --- @@ -46,6 +46,7 @@ * This constructor is public to permit tools

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140524746 --- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java --- @@ -46,6 +46,7 @@ * This constructor is public to permit tools

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140525860 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,13 +615,11 @@ public static String swapCase(final String str) {

Re: [text] license header

Its already there [1] and fails if something is not correct in *main* but I guess it doesn't check anything for test resources and test java files. thats why build was passing till date. [1]. https://github.com/apache/commons-text/blob/master/pom.xml Regards, Amey On Fri, Sep 22, 2017 at 10:58

Re: [text] license header

Ah, my bad actually after your commit for TEXT-102 Travis was failed [1]. so seems we are good here. [1] https://travis-ci.org/apache/commons-text/builds/278697845 Regards, Amey On Fri, Sep 22, 2017 at 11:41 PM, Amey Jadiye wrote: > Its already there [1] and fails if

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140545049 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,10 +614,7 @@ public static String swapCase(final String str) {

[GitHub] commons-text pull request #63: small-code-quality-improvements

Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-text/pull/63#discussion_r140548121 --- Diff: src/main/java/org/apache/commons/text/WordUtils.java --- @@ -614,10 +614,7 @@ public static String swapCase(final String str) {

[GitHub] commons-text issue #63: small-code-quality-improvements

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/63 That last build failure wasn't on youjust fixed it in the master branch. --- - To unsubscribe, e-mail:

Re: [text] license header

Good catch and thank you. I wish we could set up Maven to run the RAT check and fail a local build if a header is missing. Gary On Fri, Sep 22, 2017 at 11:24 AM, wrote: > Repository: commons-text > Updated Branches: > refs/heads/master 3292f74df -> 8cdbbd34b > > >

Re: [text] license header

Hm, I guess we could add 'apache-rat:check' and 'clirr:check' to the Travis and Jenkins builds. Gary On Fri, Sep 22, 2017 at 11:26 AM, Gary Gregory wrote: > Good catch and thank you. > > I wish we could set up Maven to run the RAT check and fail a local build > if a

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 @chtompki , can you take a look if this looks good ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 Sure I'll get to this next. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands,

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @chtompki , is this not accepted ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @chtompki , is this not accepted ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional