Re: [All] Build fails because of "animal-sniffer"

On Sun, 11 Feb 2018 10:56:07 +, sebb wrote: On 11 February 2018 at 01:19, Gilles wrote: On Sun, 11 Feb 2018 00:46:23 +, sebb wrote: On 11 February 2018 at 00:36, Gilles wrote: Hi. Using CP 43, and JDK 9, the command $

Re: [text] Adapt the Log4j 2 Interpolator to [text]

On Sun, Feb 11, 2018 at 11:10 AM, Gary Gregory wrote: > On Sun, Feb 11, 2018 at 4:40 AM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Hi Gary, >> >> thanks for adding this, looks useful. +1 >> >> Please fix the checkstyle violations. >> > > Done but there

Re: [text] Adapt the Log4j 2 Interpolator to [text]

On Sun, Feb 11, 2018 at 4:40 AM, Pascal Schumacher wrote: > Hi Gary, > > thanks for adding this, looks useful. +1 > > Please fix the checkstyle violations. > Done but there is one checkstyle "Error" left for a TODO comment I left in the code. Gary > Thanks! > > -

Re: [text] Adapt the Log4j 2 Interpolator to [text]

Am 11.02.2018 um 19:10 schrieb Gary Gregory: Done but there is one checkstyle "Error" left for a TODO comment I left in the code. Thanks! - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands,

Re: [text] Adapt the Log4j 2 Interpolator to [text]

Am 11.02.2018 um 19:24 schrieb Gary Gregory: I'd like a code review and then a release of 1.3. Right now we only depend on java.base and Commons Lang, so let's keep it that way for 1.3 I think. My comments: - Given "TEXT-80: StrLookup API confusing generic type parameter" I think we should

Re: [text] Adapt the Log4j 2 Interpolator to [text]

On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Am 11.02.2018 um 19:24 schrieb Gary Gregory: > >> I'd like a code review and then a release of 1.3. Right now we only depend >> on java.base and Commons Lang, so let's keep it that way for 1.3 I think. >> >

Re: [text] Adapt the Log4j 2 Interpolator to [text]

> On Feb 11, 2018, at 1:24 PM, Gary Gregory wrote: > > On Sun, Feb 11, 2018 at 11:10 AM, Gary Gregory > wrote: > >> On Sun, Feb 11, 2018 at 4:40 AM, Pascal Schumacher < >> pascalschumac...@gmx.net> wrote: >> >>> Hi Gary, >>> >>> thanks for

Re: [text] Adapt the Log4j 2 Interpolator to [text]

On Sun, Feb 11, 2018 at 2:46 PM, Gary Gregory wrote: > > > On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Am 11.02.2018 um 19:24 schrieb Gary Gregory: >> >>> I'd like a code review and then a release of 1.3. Right now we only

Re: [All] Build fails because of "animal-sniffer"

On 11 February 2018 at 01:19, Gilles wrote: > On Sun, 11 Feb 2018 00:46:23 +, sebb wrote: >> >> On 11 February 2018 at 00:36, Gilles wrote: >>> >>> Hi. >>> >>> Using CP 43, and JDK 9, the command >>> $ mvn test >>> fails, seemingly

Re: [text] Adapt the Log4j 2 Interpolator to [text]

Hi Gary, thanks for adding this, looks useful. +1 Please fix the checkstyle violations. Thanks! - Pascal Am 11.02.2018 um 01:32 schrieb Gary Gregory: On Sat, Feb 10, 2018 at 12:44 PM, Gary Gregory wrote: I created the ticket "[TEXT-113] Add an interpolator string

Re: [text] Adapt the Log4j 2 Interpolator to [text]

Definitely create interfaces. Chas > On Feb 11, 2018, at 1:57 PM, Gary Gregory wrote: > > On Sun, Feb 11, 2018 at 2:46 PM, Gary Gregory > wrote: > >> >> >> On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < >> pascalschumac...@gmx.net>