Re: [all] - git: prevent unnecessary merge commits?

2018-06-09 Thread Bernd Eckenfels
+1 linear commits and branch.autosetuprebase always Gruss Bernd -- http://bernd.eckenfels.net From: Emmanuel Bourg Sent: Saturday, June 9, 2018 11:54:01 PM To: Commons Developers List Subject: Re: [all] - git: prevent unnecessary merge commits? +1, I prefer

[text] commit Mail subject prefix (was: [50/50] [abbrv] [text] Prepare for releasing 1.4.)

2018-06-09 Thread Bernd Eckenfels
Hello, Is there a possible setup problem of the subject prefix for [text] commit mails? Looks like [abrev] is a left over from some sort of template? Or what it is supposed to mean? Can this be fixed by ourself or dome need a infra ticket? Gruss Bernd -- http://bernd.eckenfels.net

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Gary Gregory
So the dependency on desktop is declared as optional but it still exists? Gary On Sat, Jun 9, 2018, 16:52 Bruno P. Kinoshita wrote: > Hi all, > > There is a patch [1] for LANG-1339 [2] that I would like to merge. The > discussion around this issue can be found in the rest of this e-mail

[GitHub] commons-collections pull request #38: COLLECTIONS-681: New unit test for Mul...

2018-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

[GitHub] commons-collections pull request #38: COLLECTIONS-681: New unit test for Mul...

2018-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Bruno P. Kinoshita
Yes, that's my understanding. We would use require static on java.desktop, but users wouldn't have any issues as long as they did not use the version of the class that requires java.desktop. If the user want/needs to use those classes, then they have to add the dependency to java.desktop in

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Bruno P. Kinoshita
Hi all, There is a patch [1] for LANG-1339 [2] that I would like to merge. The discussion around this issue can be found in the rest of this e-mail thread. The patch basically deprecates the existing classes that depend on java.desktop, and provide alternative implementations. The previous

Re: [VOTE] Release Apache Commons Text 1.4 based on RC1

2018-06-09 Thread Bruno P. Kinoshita
[ X ] +1 Release these artifacts Build passing with no errors on Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_171, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-oracle/jre Default

Re: [all] - git: prevent unnecessary merge commits?

2018-06-09 Thread Emmanuel Bourg
+1, I prefer linear commit histories too. Emmanuel Bourg Le 09/06/2018 à 10:53, Pascal Schumacher a écrit : > Hello everybody, > > in my opinion it is a good practice to always use the "--rebase" option > when using "git pull". This keeps the history free of unnecessary merge > commits like

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @sfuhrm thanks for the pull request. I had a look at the CLI-284 issue in JIRA, and also checked out the pull request locally to take a look in Eclipse. I believe we have some tests

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @sfuhrm thanks for the pull request. I had a look at the CLI-284 issue in JIRA, and also checked out the pull request locally to take a look in Eclipse. I believe we have some tests

[DBCP] Release 2.4.0

2018-06-09 Thread Gary Gregory
Hi All: I'd like to release DBCP 2.4.0 ASAP. Please review what you feel like reviewing... Gary

[GitHub] commons-pool pull request #5: Delete repeated call startEvictor

2018-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-pool/pull/5 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[release plugin] error when a file already exists in SVN

2018-06-09 Thread Gary Gregory
Hi Rob: We should handle this case: [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 04:12 min [INFO] Finished at: 2018-06-09T11:07:28-06:00

Re: [release plugin] error when a file already exists in SVN

2018-06-09 Thread Gary Gregory
I deleted the files in dist SVN to handle the previous error. But now, here is another: [INFO] --- commons-release-plugin:1.3-SNAPSHOT:stage-distributions (stage-distributions) @ commons-text --- [INFO] Preparing to stage distributions [INFO] Checking out dist from: scm:svn:

Re: rolling a commons-weaver release?

2018-06-09 Thread Gary Gregory
Go for it. Gary On Sat, Jun 9, 2018, 02:32 Mark Struberg wrote: > Hi folks! > > I'd like to run a commons-weaver release. > We need it for Apache BVal. > > The new version adds Java9+10 support, etc > > Any objections? > > > LieGrue, > strub > > >

Re: rolling a commons-weaver release?

2018-06-09 Thread Matt Benson
Site needs some work before it will build. ISTR that the japicmp config needs tweaking. Matt On Sat, Jun 9, 2018, 7:36 AM Gary Gregory wrote: > Go for it. > > Gary > > On Sat, Jun 9, 2018, 02:32 Mark Struberg > wrote: > > > Hi folks! > > > > I'd like to run a commons-weaver release. > > We

Re: [release plugin] error when a file already exists in SVN

2018-06-09 Thread Gary Gregory
For this issue, we should nuke the whole folder just after checking it out... Gary On Sat, Jun 9, 2018 at 11:08 AM, Gary Gregory wrote: > Hi Rob: > > We should handle this case: > > [INFO] > > [INFO] BUILD FAILURE >

[GitHub] commons-collections issue #37: COLLECTIONS-673: Fix inspired by the Guava pa...

2018-06-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/37 [![Coverage Status](https://coveralls.io/builds/17407790/badge)](https://coveralls.io/builds/17407790) Coverage increased (+0.007%) to 86.582% when pulling

[VOTE] Release Apache Commons Text 1.4 based on RC1

2018-06-09 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Text 1.3 was released, so I would like to release Apache Commons Text 1.4. Apache Commons Text 1.4 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/text (svn revision

[GitHub] commons-collections issue #38: COLLECTIONS-681: New unit test for MultiSetUt...

2018-06-09 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/38 [![Coverage Status](https://coveralls.io/builds/17408068/badge)](https://coveralls.io/builds/17408068) Coverage increased (+0.07%) to 86.644% when pulling

[GitHub] commons-collections pull request #37: COLLECTIONS-673: Fix inspired by the G...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/37 COLLECTIONS-673: Fix inspired by the Guava partition() implementation A fix for the COLLECTIONS-673 bug and a unit test proving the fix for the shown defect. See

[GitHub] commons-pool issue #5: Delete repeated call startEvictor

2018-06-09 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/5 Thank you for your patch. In git master now. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

Re: [release plugin] error when a file already exists in SVN

2018-06-09 Thread Rob Tompkins
Hm...that directory isn’t part of the site build, I checked it in to keep the older versions of the api available for google indexing. I’ll have to fiddle around with the plugin to overcome the error. > On Jun 9, 2018, at 1:18 PM, Gary Gregory wrote: > > I deleted the files in dist SVN to

[GitHub] commons-collections pull request #38: COLLECTIONS-681: New unit test for Mul...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/38 COLLECTIONS-681: New unit test for MultiSetUtils A unit test for the MultiSetUtils. The MultiSetUtils had no tests at all, so this will improve the overall coverage. You can merge this

[GitHub] commons-io pull request #63: Travis: Add oraclejdk10

2018-06-09 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-io/pull/63 Travis: Add oraclejdk10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-io travis_java_10 Alternatively

[GitHub] commons-io pull request #63: Travis: Add oraclejdk10

2018-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/63 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

rolling a commons-weaver release?

2018-06-09 Thread Mark Struberg
Hi folks! I'd like to run a commons-weaver release. We need it for Apache BVal. The new version adds Java9+10 support, etc Any objections? LieGrue, strub - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[all] - git: prevent unnecessary merge commits?

2018-06-09 Thread Pascal Schumacher
Hello everybody, in my opinion it is a good practice to always use the "--rebase" option when using "git pull". This keeps the history free of unnecessary merge commits like "Merge branch 'master' of https://git-wip-us.apache.org/repo...;. You can also tell git to automatically rebase when

Re: [all] - git: prevent unnecessary merge commits?

2018-06-09 Thread Bruno P. Kinoshita
Hi Pascal, Apache OpenNLP uses that approach whenever possible (http://opennlp.apache.org/using-git.html). I like the way the commit tree looks after a while. Sometimes it's not practical, especially when receiving patches from external contributors (developers can still check-out code locally

Re: rolling a commons-weaver release?

2018-06-09 Thread Romain Manni-Bucau
+1 Le sam. 9 juin 2018 10:32, Mark Struberg a écrit : > Hi folks! > > I'd like to run a commons-weaver release. > We need it for Apache BVal. > > The new version adds Java9+10 support, etc > > Any objections? > > > LieGrue, > strub > > >

Re: [all] - git: prevent unnecessary merge commits?

2018-06-09 Thread ajs6f
+1. Unless there is a specific reason to incur a merge commit, it's generally noise. ajs6f > On Jun 9, 2018, at 5:03 AM, Bruno P. Kinoshita > wrote: > > Hi Pascal, > > Apache OpenNLP uses that approach whenever possible > (http://opennlp.apache.org/using-git.html). I like the way the

[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-cli/pull/25 CLI-284: Fix inconsistent behaviour for short and long name == null Fix for https://issues.apache.org/jira/browse/CLI-284 You can merge this pull request into a Git repository by running: