> On 20 Jun 2019, at 00:54, Heinrich Bohne wrote:
>
> An awful lot of code is duplicated between FractionTest and
> BigFractionTest. Often, the test cases in the two classes only differ in
> the types they use (e.g. Fraction vs. BigFraction), but the actual
> values the tests use are the
A quick looks shows that the BigFractionTest does have test cases for very
large numbers. However the add, subtract, divide and multiply tests and a few
others just use values that would work with Fraction. Possibly these can be
moved to a shared common tests location too.
That's what I was
On 20/06/2019 12:45, Apache Jenkins Server wrote:
The Apache Jenkins build system has built commons-rng (build #361)
Status: Still Failing
Check console output at https://builds.apache.org/job/commons-rng/361/ to view
the results.
Jenkins is failing the RAT check on JDK 1.6 with apparently
On 20/06/2019 13:30, sebb wrote:
On Thu, 20 Jun 2019 at 13:06, Alex Herbert wrote:
On 20/06/2019 12:45, Apache Jenkins Server wrote:
The Apache Jenkins build system has built commons-rng (build #361)
Status: Still Failing
Check console output at
I do not understand the lack of reply to my requests to follow our release
process:
- Hashes to files on dist/dev
- Link to site
- Link to KEYS file
- Link to apache.org instead of github.com for the tag
Gary
On Wed, Jun 19, 2019 at 6:30 AM Mark Thomas wrote:
> On 19/06/2019 10:44, Jonathan
Hello Gary.
Le jeu. 20 juin 2019 à 14:31, Gary Gregory a écrit :
>
> Java 6? Really?
You ask this recurrently. ;-)
[I know this is not the right thread to answer it but anyways...]
That [RNG] still supports Java 6 is a tribute to what I've been
advocating for ages: Better create small and
On 20/06/2019 13:47, Gilles Sadowski wrote:
Hello Gary.
Le jeu. 20 juin 2019 à 14:31, Gary Gregory a écrit :
Java 6? Really?
You ask this recurrently. ;-)
[I know this is not the right thread to answer it but anyways...]
That [RNG] still supports Java 6 is a tribute to what I've been
On Thu, 20 Jun 2019 at 13:06, Alex Herbert wrote:
>
> On 20/06/2019 12:45, Apache Jenkins Server wrote:
> > The Apache Jenkins build system has built commons-rng (build #361)
> >
> > Status: Still Failing
> >
> > Check console output at https://builds.apache.org/job/commons-rng/361/ to
> > view
Java 6? Really?
Gary
On Thu, Jun 20, 2019 at 8:06 AM Alex Herbert
wrote:
> On 20/06/2019 12:45, Apache Jenkins Server wrote:
> > The Apache Jenkins build system has built commons-rng (build #361)
> >
> > Status: Still Failing
> >
> > Check console output at
Hi Gary and BCEL maintainers,
I created a PR for LruCacheClassPathRepository
https://github.com/apache/commons-bcel/pull/28 . I appreciate if you can
review them.
Regards,
Tomo
On Mon, Jun 17, 2019 at 12:11 PM Tomo Suzuki wrote:
> Hi Gary and BCEL maintainers,
>
> My OutOfMemoryError problem
Sorry for the slow reply, I thought I sent this yesterday.
I agree from a code architecture standpoint such a refactoring makes sense.
However from the perspective of unit tests it makes it no longer a unit
test.
IIUC it's best practice for a unit test that all context be within the
test. If
>
> > If additional context is required it fails to meet the definition of
> > a unit test and is instead an integration test, and the function being
> > tested may require rethinking.
>
> Depends what you define as a unit test. I'd say the unit was BigFraction
> or Fraction. An integration test
On 20/06/2019 16:07, Eric Barnhill wrote:
Sorry for the slow reply, I thought I sent this yesterday.
I agree from a code architecture standpoint such a refactoring makes sense.
However from the perspective of unit tests it makes it no longer a unit
test.
It is still testing a unit. Just the
Hello Eric,
I'm not sure if I understand what you mean by "context" when you say
that all context has to be within the unit test.Do you mean that the
test should not rely on the functionality of other
modules/methods/"units" than the one to be tested? If so, I agree with
you, but I don't think
By the way, I've worked a bit on the draft in the meantime and pushed
the changes I've made so far, in case anyone is interested in
(re-)viewing them. Here's the link to the branch again:
https://github.com/Schamschi/commons-numbers/tree/FractionCommonTestCases
On 6/20/19 6:13 PM, Heinrich Bohne
Given the discussions around 1.1.1 vs 1.2.0 I'm cancelling this release
vote.
I'll start preparing for a 1.2.0 RC now (I think things are pretty much
there but a final check won't hurt) with a view to tagging sometime
between late tomorrow and early next week.
If anyone has any objections to
On 20/06/2019 13:34, Gary Gregory wrote:
> I do not understand the lack of reply to my requests to follow our release
> process:
>
> - Hashes to files on dist/dev
Not necessary.
The revision number for the dist repo is sufficient for traceability.
> - Link to site
Not part of the release.
> -
17 matches
Mail list logo
