Re: [BloomFilters] changes to BloomFilter

2020-04-22 Thread Gilles Sadowski
Hello. Le mer. 22 avr. 2020 à 14:56, Gary Gregory a écrit : > > Hi All, > > I'd like to pat ourselves on the back for a smooth ride so far in bringing > in new code for a new non-trivial feature :-) > > IMO, let's not get hung up on generics for the first cut of the Bloom > Filter code. Why?

Re: [BloomFilters] changes to BloomFilter

2020-04-22 Thread Alex Herbert
On Wed, 22 Apr 2020 at 13:56, Gary Gregory wrote: > Hi All, > > I'd like to pat ourselves on the back for a smooth ride so far in bringing > in new code for a new non-trivial feature :-) > > IMO, let's not get hung up on generics for the first cut of the Bloom > Filter code. Why? Because

Re: [crypto] Help Releasing new Commons Crypto

2020-04-22 Thread Adam Retter
If you want to build on CentOS for releases that is fine - I can add Docker Build Environments as a Travis job that use older CentOS. On Wed, 22 Apr 2020 at 18:02, Geoffrey Blake wrote: > > I think it depends on whether using Ubuntu 14.04/16.04 as the base > distro for releases is ok. It seems

Re: [BloomFilters] changes to BloomFilter

2020-04-22 Thread Alex Herbert
On Wed, 22 Apr 2020 at 17:17, Gilles Sadowski wrote: > > > - Does the BF code reuse Commons Collection utilities? > > Yes, in class "HasherBloomFilter": > import org.apache.commons.collections4.iterators.EmptyIterator; > import org.apache.commons.collections4.iterators.IteratorChain; > Missed

Re: [crypto] Help Releasing new Commons Crypto

2020-04-22 Thread Geoffrey Blake
I think it depends on whether using Ubuntu 14.04/16.04 as the base distro for releases is ok. It seems most projects like to build on some variant of RHEL/CentOS as they typically use stable (read older) compilers and libc. Does Travis allow building all the binaries then having a final process

Re: [crypto] Help Releasing new Commons Crypto

2020-04-22 Thread Adam Retter
No that https://github.com/apache/commons-crypto/pull/96 has been merged, we have support for Arm64, ppc64le and x64 in Travis. I wondered if it was useful for the "Release Process" if we had Travis build and store release artifacts? I believe we can have Travis do this only when Git tags are

Re: [BloomFilters] changes to BloomFilter

2020-04-22 Thread Claude Warren
Bloom filters should not use generics. That has been my stated opinion. They are not like other collections in that you don't get out what you put in. They are collections of hashes so the idea that generics should be used to somehow define what goes in is misleading. If commons-collections is

Re: [BloomFilters] changes to BloomFilter

2020-04-22 Thread Gary Gregory
Hi All, I'd like to pat ourselves on the back for a smooth ride so far in bringing in new code for a new non-trivial feature :-) IMO, let's not get hung up on generics for the first cut of the Bloom Filter code. Why? Because generics are erased by the compiler and we can always add them later