> On Jul 7, 2020, at 6:56 PM, Gary Gregory wrote:
>
> In the PR https://github.com/apache/commons-lang/pull/559 I am going with
> "LockingVistors".
I like this name because of its brevity yet clarity.
-Rob
>
> Gary
>
> On Tue, Jul 7, 2020 at 2:33 PM Rob Tompkins wrote:
>
>> I’m not
On Tue, Jul 7, 2020 at 10:22 PM Gary Gregory wrote:
> On Tue, Jul 7, 2020 at 7:14 PM Matt Sicker wrote:
>
>> JCIP seems to call this idea a monitor, but that’s also the general
>> implicit locking mechanism in Java.
>>
>
FTR, that's JCIP section 4.2.1 (in my edition).
Gary
>
> Hi Matt,
>
>
I am avail to cut RCs when the fix goes in unless Phil wants to do it.
Gary
On Wed, Jul 8, 2020 at 11:20 AM Phil Steitz wrote:
>
> On 7/5/20 7:08 PM, Phil Steitz wrote:
> >
> >
> > On 7/5/20 6:02 PM, Phil Steitz wrote:
> >>
> >>
> >> On 7/5/20 11:07 AM, Phil Steitz wrote:
> >>>
> >>> The test
On 7/5/20 7:08 PM, Phil Steitz wrote:
On 7/5/20 6:02 PM, Phil Steitz wrote:
On 7/5/20 11:07 AM, Phil Steitz wrote:
The test looks a little off to me. I am not sure I fully understand
what it is trying to do, but I suspect that the reason that it fails
sporadically (I have seen this
On Wed, Jul 8, 2020 at 11:20 AM Phil Steitz wrote:
>
> On 7/5/20 7:08 PM, Phil Steitz wrote:
> >
> >
> > On 7/5/20 6:02 PM, Phil Steitz wrote:
> >>
> >>
> >> On 7/5/20 11:07 AM, Phil Steitz wrote:
> >>>
> >>> The test looks a little off to me. I am not sure I fully understand
> >>> what it is
On Wed, Jul 8, 2020, 09:32 Rob Tompkins wrote:
>
>
> > On Jul 7, 2020, at 6:56 PM, Gary Gregory wrote:
> >
> > In the PR https://github.com/apache/commons-lang/pull/559 I am going
> with
> > "LockingVistors".
>
> I like this name because of its brevity yet clarity.
>
Let's go for that then.
On 7/8/20 8:33 AM, Gary Gregory wrote:
On Wed, Jul 8, 2020 at 11:20 AM Phil Steitz wrote:
On 7/5/20 7:08 PM, Phil Steitz wrote:
On 7/5/20 6:02 PM, Phil Steitz wrote:
On 7/5/20 11:07 AM, Phil Steitz wrote:
The test looks a little off to me. I am not sure I fully understand
what it is
Hi,
I was replacing my own copy of CharSequenceReader with the one from
commons-io, but I had some test failures. I found out that there were
two reasons:
* It doesn't override ready(), and therefore always returns false, even
if there are still characters to be read. That's not incorrect
