Re: [VOTE] Release Apache Commons JCS 3.1 based on rc2

2022-01-17 Thread Thomas Vandahl
Hi Gilles, > Am 14.01.2022 um 15:37 schrieb Gilles Sadowski : > >>> Maven artifacts are here: >>> >>> https://repository.apache.org/content/repositories/orgapachecommons-1576/org/apache/commons/commons-jcs3/3.1/ > > I only see one ".pom" file and one ".xml" file (with their respective >

Re: [Geometry] Issues (?) with the "hull" module[1]

2022-01-17 Thread Gilles Sadowski
Hello. Le lun. 17 janv. 2022 à 14:16, Matt Juntunen a écrit : > > Hi Gilles, > > The main things I want to do on the hull module are > - Review the public API to see if any changes need to be made. (ex: > make AklToussaintHeuristic internal) Good suggestion; I'll minimize the public API.[1] >

Re: [VOTE] Release Apache Commons JCS 3.1 based on rc2

2022-01-17 Thread Thomas Vandahl
Hi Gilles, > Am 17.01.2022 um 14:11 schrieb Gilles Sadowski : > > No; the remark is for making the reviewer's life easier, i.e just copy/paste > the command and see the build succeed. Without the environment variable, > the "javadoc" step fails IIRC. Ok, thanks for the hint. I didn’t know

Re: [VOTE] Release Apache Commons JCS 3.1 based on rc2

2022-01-17 Thread Gilles Sadowski
Hello. Le lun. 17 janv. 2022 à 13:33, Thomas Vandahl a écrit : > > Hi Gilles, > > > Am 14.01.2022 um 15:37 schrieb Gilles Sadowski : > > > >>> Maven artifacts are here: > >>> > >>> https://repository.apache.org/content/repositories/orgapachecommons-1576/org/apache/commons/commons-jcs3/3.1/ >

Re: [VOTE] Release Apache Commons JCS 3.1 based on rc2

2022-01-17 Thread Thomas Vandahl
Hi Gilles, > Am 17.01.2022 um 14:11 schrieb Gilles Sadowski : > > No; the remark is for making the reviewer's life easier, i.e just copy/paste > the command and see the build succeed. Without the environment variable, > the "javadoc" step fails IIRC. Ok, thanks for the hint. I didn’t know

Re: [Geometry] Issues (?) with the "hull" module[1]

2022-01-17 Thread Matt Juntunen
Hi Gilles, The main things I want to do on the hull module are - Review the public API to see if any changes need to be made. (ex: make AklToussaintHeuristic internal) - Add QuickHull implementations for 2D/3D (GEOMETRY-110). This is currently blocked due to the need for a PointMap

Re: [Geometry] Issues (?) with the "hull" module[1]

2022-01-17 Thread Matt Juntunen
Hello. > OK. Did I understand correctly that the functionality is already > there, with several implementations)? We only have one convex hull implementation (MonotoneChain) and that one is only for 2D. Before we release, I'd like to at least have implementations for Euclidean 2D and 3D. I'm

[Math][All] "dist-archive" module

2022-01-17 Thread Gilles Sadowski
Hi. Is the "dist-archive" module/directory still in use. I noticed that the command $ cd dist-archive && mvn assembly::single (as documented e.g. in [1]) generates "bin" archives (".tar.gz" and ".zip" files) that only contain the NOTICE and LICENCE files). The "src" seem OK. However, I also