Re: svn commit: r1470311 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/MapUtils.java

2013-04-22 Thread Thomas Neidhart
My idea was that 90% of the potential users will use Java 6+, thus it made sense to me, but of course we can change it and wait till we move to Java 6 ourselves. Thomas On Sun, Apr 21, 2013 at 11:10 PM, sebb seb...@gmail.com wrote: On 21 April 2013 21:30, Thomas Neidhart

Re: [io] readying release?

2013-04-22 Thread sebb
On 22 April 2013 03:41, Henri Yandell flame...@gmail.com wrote: On Sun, Apr 21, 2013 at 5:27 AM, sebb seb...@gmail.com wrote: On 21 April 2013 05:44, Henri Yandell flame...@gmail.com wrote: Proposed fix: https://issues.apache.org/jira/browse/IO-295 I did wonder about using

Re: [io] readying release?

2013-04-22 Thread Henri Yandell
On Mon, Apr 22, 2013 at 2:33 AM, sebb seb...@gmail.com wrote: On 22 April 2013 03:41, Henri Yandell flame...@gmail.com wrote: On Sun, Apr 21, 2013 at 5:27 AM, sebb seb...@gmail.com wrote: On 21 April 2013 05:44, Henri Yandell flame...@gmail.com wrote: Proposed fix:

[IO] CharSequenceInputStream - strange code

2013-04-22 Thread sebb
I'm trying to fix IO-356, and having problems. I think this is because the code is a bit confused. The read() method reads bytes from the encoded byte buffer. However skip(int) skips the underlying CharBuf, and available() checks the CharBuf I would expect read() and skip(1) to have the same

Re: [IO] CharSequenceInputStream - strange code

2013-04-22 Thread Gary Gregory
I looked at this a couple of month ago and found it equally confusing. Gary On Mon, Apr 22, 2013 at 12:14 PM, sebb seb...@gmail.com wrote: I'm trying to fix IO-356, and having problems. I think this is because the code is a bit confused. The read() method reads bytes from the encoded byte

Re: [VOTE] Release Commons Codec 1.8-RC4

2013-04-22 Thread Gary Gregory
Would anyone else care to check the RC and VOTE? Thank you, Gary On Fri, Apr 19, 2013 at 12:56 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.8-RC4. Commons Codec 1.8 requires a minimum of Java 1.6 Changes from 1.8-RC3 are: Add pmd.xml

Re: [VOTE] Release Commons Codec 1.8-RC4

2013-04-22 Thread Thomas Neidhart
On 04/19/2013 06:56 PM, Gary Gregory wrote: Hello All: This is a VOTE to release Commons Codec 1.8-RC4. Commons Codec 1.8 requires a minimum of Java 1.6 Changes from 1.8-RC3 are: Add pmd.xml to source distribution to build the site. Changes from 1.8-RC2 are: Clarify NOTICE.txt

Re: [VOTE] Release Commons Codec 1.8-RC4

2013-04-22 Thread Jörg Schaible
Gary Gregory wrote: Hello All: This is a VOTE to release Commons Codec 1.8-RC4. Commons Codec 1.8 requires a minimum of Java 1.6 Changes from 1.8-RC3 are: Add pmd.xml to source distribution to build the site. Changes from 1.8-RC2 are: Clarify NOTICE.txt Changes from 1.8-RC1

Re: [VOTE] Release Commons Codec 1.8-RC4

2013-04-22 Thread Gary Gregory
My +1. Gary On Fri, Apr 19, 2013 at 12:56 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.8-RC4. Commons Codec 1.8 requires a minimum of Java 1.6 Changes from 1.8-RC3 are: Add pmd.xml to source distribution to build the site. Changes

[RESULT][VOTE] Release Commons Codec 1.8-RC4

2013-04-22 Thread Gary Gregory
The VOTE to release Commons Codec 1.8-RC4 passes with the following votes: +1 Oliver Heger PMC +1 Thomas Neidhart PMC +1 Bruno Kinoshita (non-binding) +1 Gary Gregory PMC +1 Jörg Schaible PMC Only PMC votes are binding. See http://people.apache.org/committers-by-project.html#commons-pmc Gary

[ALL] release instructions warning

2013-04-22 Thread Gary Gregory
To release Codec 1.8, I just tried following https://commons.apache.org/releases/prepare.html In particular: Before you closehttp://www.apache.org/dev/publishing-maven-artifacts.html#close-stagethe staging repository you must remove the tarballs/zips together with their PGP signatures and

Re: [ALL] release instructions warning

2013-04-22 Thread Henri Yandell
This fills me with foreboding for doing a release again someday :( On Mon, Apr 22, 2013 at 6:19 PM, Gary Gregory garydgreg...@gmail.comwrote: To release Codec 1.8, I just tried following https://commons.apache.org/releases/prepare.html In particular: Before you close