Re: [ALL] Moving view on builds.a.o

2017-07-27 Thread Dennis Kieselhorst
You can't move it as https://issues.jenkins-ci.org/browse/JENKINS-6961
isn't resolved yet.

I noticed there is already another one
https://builds.apache.org/view/A-D/view/Commons/ so we can delete the
top level view.

Regards
Dennis



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [ALL] Moving view on builds.a.o

2017-07-27 Thread Gary Gregory
You don't have karma to use what in the UI? I do not see a "move" kind of
operation, only "new" ops.

Gary

On Wed, Jul 26, 2017 at 11:53 AM, Rob Tompkins  wrote:

> Happy to do it, but I don't have the correct permissions.
>
> > On Jul 26, 2017, at 2:10 PM, Gary Gregory 
> wrote:
> >
> > Hi All:
> >
> > Does anyone know how to move our view?
> >
> > Please see the warning on https://builds.apache.org/
> view/Apache%20Commons/
> >
> > Gary
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [collections][proposal] Java 7

2017-07-27 Thread Gary Gregory
git master is now Java 7.

Gary

On Thu, Jul 27, 2017 at 9:53 AM, Gary Gregory 
wrote:

> We have not in the past forced a major version and Maven coordinate change
> when updating the Java platform. We could do that of course.
>
> Gary
>
> On Jul 27, 2017 06:47, "Jochen Wiedmann" 
> wrote:
>
>> Wouldn't that make it 5.0? (Binary incompatible change)
>>
>> Note: I am not opposing the change, I just propose an additional
>> change in the version number.
>>
>> Jochen
>>
>>
>> On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory 
>> wrote:
>> > Hi All:
>> >
>> > I propose we make Java 7 the minimum for Commons Collection 4.2.
>> >
>> > Gary
>>
>>
>>
>> --
>> The next time you hear: "Don't reinvent the wheel!"
>>
>> http://www.keystonedevelopment.co.uk/wp-content/uploads/
>> 2014/10/evolution-of-the-wheel-300x85.jpg
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>


Re: [all/travis-ci] Regarding using ibmjava on travis

2017-07-27 Thread Amey Jadiye
Hi Rob,

If this is still pending I would like to pickup this task. If docker is not
much  helpful OR we need to wait for it I think we should try what jacoco
did. what do you think ?

Is it mandatory to use official java images ?Else I am also thinking to
create my own ibmjdk8 image on top of given by IBM and have some tools and
scrips  ready in that so on fail it should return -1.

Not sure how much travis-ci be helpful here since I saw Pascal removed
oraclejdk7 from .travis configuration because its not available. I'm not
keeping much hopes on Travis  at this point as their provision on different
jdk images seems very slow to me .

Regards,
Amey

On Sat, Jul 1, 2017, 6:43 PM Rob Tompkins  wrote:

> Hello all,
>
> Pardon my disappearance for the last week or so. My day job has been a
> little over consuming (c’est la vie). Regardless, I’ve been looking at how
> we can use the current appetite in the travis-ci community to push them to
> install ibmjava8 and ibmjava9 in this working thread:
> https://github.com/travis-ci/travis-ci/issues/2682 <
> https://github.com/travis-ci/travis-ci/issues/2682>. Hopefully we can
> gain some traction there.
>
> Regardless, they seem to have far more idk’s installed in their build
> environment than documented
> https://github.com/travis-ci/travis-cookbooks/tree/master/cookbooks/travis_java/recipes
> <
> https://github.com/travis-ci/travis-cookbooks/tree/master/cookbooks/travis_java/recipes>.
> Which, as Amey noted earlier, jacoco seems to be utilizing
> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23 <
> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23>.
>
> I’m not particularly looking for any responses to this email. I more just
> wanted to document my current research efforts here.
>
> Cheers,
> -Rob


[GitHub] commons-collections issue #9: COLLECTIONS-551

2017-07-27 Thread chtompki
Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/9
  
Ok no stress. I'll try to see what I can do with it. Cheers, -Rob.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections issue #9: COLLECTIONS-551

2017-07-27 Thread gonmarques
Github user gonmarques commented on the issue:

https://github.com/apache/commons-collections/pull/9
  
Hi,

It has been almost two and a half years since I opened this PR. I did a 
quick rebase just to have an idea of any eventual existing conflicts and got a 
non-trivial conflict list. The overall resolution would require a degree of 
availability that unfortunately I don't have at the present time.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Modern dependencies among commons

2017-07-27 Thread Dave Brosius

I have pushed a first patch to move in this direction with commons-beanutils

https://issues.apache.org/jira/browse/BEANUTILS-500


It is breaking in a couple deprecated methods, thus, targetted at a 2.0. 
given that, there are probably other things we'd want to do.



On 07/27/2017 09:48 AM, Jochen Wiedmann wrote:

On Thu, Jul 27, 2017 at 1:52 PM, Jörg Schaible
 wrote:

Claude Warren wrote:


Perhaps change dependency so that it specifies minimum but leaves maximum
open. (unless there is an upper limit)

commons-lang and commons-lang3 are no replacements, they are different
artifacts. Switching from old to new requires changes in code.


I understand the proposal is about making these required changes
*now*. And I am +1 about that.

Jochen





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #58: Add tests

2017-07-27 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/58#discussion_r129910754
  
--- Diff: 
src/test/java/org/apache/commons/text/similarity/CosineSimilarityTest.java ---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.text.similarity;
+
+import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link CosineSimilarity}.
+ *
+ * @date 2017-07-26
+ * @see CosineSimilarity
+ *
+ **/
+public class CosineSimilarityTest{
+
+  @Test
+  public void testCosineSimilarityWithNonEmptyMap() {
+  CosineSimilarity cosineSimilarity = new CosineSimilarity();
+  Map hashMap = new HashMap();
+  Integer integer = new Integer((-397));
+  hashMap.put("3J/$3.L", integer);
+  Map hashMapTwo = new HashMap(hashMap);
+  Map hashMapThree = new HashMap();
+
+  assertEquals(0.0, (double) 
cosineSimilarity.cosineSimilarity(hashMapTwo, hashMapThree), 0.01);
+  }
+
+  @Test
--- End diff --

I think these tests should just use 
`@Test(expected=IllegalArgumentException.class)` instead fo the try-catch-fail 
construct. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collections][proposal] Java 7

2017-07-27 Thread Gary Gregory
We have not in the past forced a major version and Maven coordinate change
when updating the Java platform. We could do that of course.

Gary

On Jul 27, 2017 06:47, "Jochen Wiedmann"  wrote:

> Wouldn't that make it 5.0? (Binary incompatible change)
>
> Note: I am not opposing the change, I just propose an additional
> change in the version number.
>
> Jochen
>
>
> On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory 
> wrote:
> > Hi All:
> >
> > I propose we make Java 7 the minimum for Commons Collection 4.2.
> >
> > Gary
>
>
>
> --
> The next time you hear: "Don't reinvent the wheel!"
>
> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/
> evolution-of-the-wheel-300x85.jpg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [collections][proposal] Java 7

2017-07-27 Thread Matt Benson
I think Jochen is correct wrt the major version bump. But that gets me
thinking: what did Java 7 bring that is of any particular relevance
for [collections]? Wouldn't it present a much larger opportunity to
make the jump to Java 8?

Matt

On Thu, Jul 27, 2017 at 8:47 AM, Jochen Wiedmann
 wrote:
> Wouldn't that make it 5.0? (Binary incompatible change)
>
> Note: I am not opposing the change, I just propose an additional
> change in the version number.
>
> Jochen
>
>
> On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory  wrote:
>> Hi All:
>>
>> I propose we make Java 7 the minimum for Commons Collection 4.2.
>>
>> Gary
>
>
>
> --
> The next time you hear: "Don't reinvent the wheel!"
>
> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Modern dependencies among commons

2017-07-27 Thread Jochen Wiedmann
On Thu, Jul 27, 2017 at 1:52 PM, Jörg Schaible
 wrote:
> Claude Warren wrote:
>
>> Perhaps change dependency so that it specifies minimum but leaves maximum
>> open. (unless there is an upper limit)
>
> commons-lang and commons-lang3 are no replacements, they are different
> artifacts. Switching from old to new requires changes in code.


I understand the proposal is about making these required changes
*now*. And I am +1 about that.

Jochen


-- 
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collections][proposal] Java 7

2017-07-27 Thread Jochen Wiedmann
Wouldn't that make it 5.0? (Binary incompatible change)

Note: I am not opposing the change, I just propose an additional
change in the version number.

Jochen


On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory  wrote:
> Hi All:
>
> I propose we make Java 7 the minimum for Commons Collection 4.2.
>
> Gary



-- 
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Modern dependencies among commons

2017-07-27 Thread Jörg Schaible
Claude Warren wrote:

> Perhaps change dependency so that it specifies minimum but leaves maximum
> open. (unless there is an upper limit)

commons-lang and commons-lang3 are no replacements, they are different 
artifacts. Switching from old to new requires changes in code.

- Jörg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Modern dependencies among commons

2017-07-27 Thread Claude Warren
Perhaps change dependency so that it specifies minimum but leaves maximum
open. (unless there is an upper limit)

On Wed, Jul 26, 2017 at 4:41 PM, Gary Gregory 
wrote:

> Go for it! :-)
>
> Gary
>
> On Jul 26, 2017 05:23, "Dave Brosius"  wrote:
>
> > Hi Folks,
> >
> >
> > I'd like to see all of our common components uptake the 'latest'
> > versions of other commons components, to encourage their adoption. For
> > instance, commons-beanutils still uses commons-collections 3, and so
> when i
> > want to use commons-collections4 myself, i now have to have both in the
> > classpath. While there are no conflicts, it's just messy. People
> > auto-import the wrong version of collections classes into our code base,
> > for instance. If we could get updates to at least the right (major)
> version
> > of jars that would be great.
> >
> >
> > --dave
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>



-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren


Re: [collections][proposal] Java 7

2017-07-27 Thread Claude Warren
+1 -- time to move forward

On Wed, Jul 26, 2017 at 1:23 PM, Dave Brosius 
wrote:

> +1
>
>
> On 07/25/2017 06:18 PM, Gary Gregory wrote:
>
>> Hi All:
>>
>> I propose we make Java 7 the minimum for Commons Collection 4.2.
>>
>> Gary
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren