[GitHub] darkma773r commented on issue #12: Geometry 19

2018-09-21 Thread GitBox
darkma773r commented on issue #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12#issuecomment-423707558 Closing this pr based on the discussion here: https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-19. In short, the issue is not with commons-geometry

[GitHub] darkma773r closed pull request #12: Geometry 19

2018-09-21 Thread GitBox
darkma773r closed pull request #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

Re: [All] CP definitions

2018-09-21 Thread Gilles
On Fri, 21 Sep 2018 09:26:07 -0600, Gary Gregory wrote: On Fri, Sep 21, 2018 at 7:05 AM Gilles wrote: On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote: >> On Sep 20, 2018, at 9:31 AM, Gilles >> wrote: >> >> On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote: On Sep 20,

Re: [All] CP definitions

2018-09-21 Thread Rob Tompkins
> On Sep 21, 2018, at 11:26 AM, Gary Gregory wrote: > > On Fri, Sep 21, 2018 at 7:05 AM Gilles > wrote: > >> On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote: On Sep 20, 2018, at 9:31 AM, Gilles wrote: On Thu, 20 Sep 2018

[GitHub] commons-rng issue #10: Improvement rng 51

2018-09-21 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-rng/pull/10 [![Coverage Status](https://coveralls.io/builds/19124726/badge)](https://coveralls.io/builds/19124726) Coverage increased (+0.4%) to 97.501% when pulling

[GitHub] commons-rng pull request #10: Improvement rng 51

2018-09-21 Thread aherbert
GitHub user aherbert opened a pull request: https://github.com/apache/commons-rng/pull/10 Improvement rng 51 RNG-51: Added a PoissonSamplerCache that exploits the fact that the state of the LargeMeanPoissonSampler is constant for all means in the range `n <= mean < n+1` where `n`

Re: [All] CP definitions

2018-09-21 Thread Gilles
On Fri, 21 Sep 2018 08:52:37 -0400, Rob Tompkins wrote: On Sep 20, 2018, at 9:31 AM, Gilles wrote: On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote: On Sep 20, 2018, at 3:10 AM, Benedikt Ritter wrote: Hello, Reverting this change was discussed here [1]. It was a result of this

Re: [All] CP definitions

2018-09-21 Thread Rob Tompkins
> On Sep 20, 2018, at 9:31 AM, Gilles wrote: > > On Thu, 20 Sep 2018 08:53:38 -0400, Rob Tompkins wrote: >>> On Sep 20, 2018, at 3:10 AM, Benedikt Ritter wrote: >>> >>> Hello, >>> >>> Reverting this change was discussed here [1]. It was a result of this >>> commit [2] breaking multiple

[GitHub] commons-collections issue #53: updating containsKey method in PassiveExpirin...

2018-09-21 Thread thePatmanMI
Github user thePatmanMI commented on the issue: https://github.com/apache/commons-collections/pull/53 I can do that. Do you have a preference on whether I should use reflection to access the underlying map(s) (to determine size) or if I should change the underlying map(s) to be