Re: [VOTE] Release Apache Commons Configuration 2.4 based on RC2

2018-10-24 Thread Gary Gregory
I do not understand why Clirr is showing one error here: https://dist.apache.org/repos/dist/dev/commons/configuration/2.4-RC2/site/clirr-report.html Could this be a false positive? Gary On Tue, Oct 23, 2018 at 8:10 PM Rob Tompkins wrote: > We have fixed quite a few bugs and added some

[GitHub] commons-pool issue #11: POOL-356 add unit test for the deadlock

2018-10-24 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-pool/pull/11 [![Coverage Status](https://coveralls.io/builds/19703092/badge)](https://coveralls.io/builds/19703092) Coverage increased (+0.3%) to 85.174% when pulling

[GitHub] commons-pool issue #11: POOL-356 add unit test for the deadlock

2018-10-24 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-pool/pull/11 [![Coverage Status](https://coveralls.io/builds/19703092/badge)](https://coveralls.io/builds/19703092) Coverage increased (+0.3%) to 85.174% when pulling

POOL-356 deadlock patch

2018-10-24 Thread Mark Struberg
hi folks! Would be cool if someone firm in this project might review my patch for POOL-356https://github.com/apache/commons-pool/pull/11 I gonna commit it tomorrow morning if there was no negative feedback. txs and LieGrue,strub

Re: usage of System.currentTimeMillis();

2018-10-24 Thread Matt Sicker
Java 8 introduced the java.time.Clock class which can be used to customize this behavior. In Log4j, we have a similar Clock class (from back when we were on Java 6) which is used instead of System to allow for the user to customize their performance requirements. On Wed, 24 Oct 2018 at 07:57,

Re: usage of System.currentTimeMillis();

2018-10-24 Thread Romain Manni-Bucau
Hi Mark, AFAIK currenttimemillis is still "cached" compared to nanotime but for duration computation nanotime is prefered (whereas when the time must be aligned on the watch currenttimemillis is the only valid choice). Romain Manni-Bucau @rmannibucau | Blog

usage of System.currentTimeMillis();

2018-10-24 Thread Mark Struberg
Hi folks! While fixing a deadlock in commons-pool I also stumbled across System.currentTimeMillis();quite a few times.It's no biggie but I would still love to get your feedback and experience. If I remember correctly then one should use Sytem.nanoTime() in those cases.a.) afair

[GitHub] commons-pool pull request #11: POOL-356 add unit test for the deadlock

2018-10-24 Thread struberg
GitHub user struberg opened a pull request: https://github.com/apache/commons-pool/pull/11 POOL-356 add unit test for the deadlock Please review! Will ship a first fix candidate soon. You can merge this pull request into a Git repository by running: $ git pull