Re: [pool] Recovering from transient factory outages

2024-02-13 Thread Romain Manni-Bucau
Hi Phil, You are right it can be done in pool - I'm not sure it is the right level (for instance in my previous example it will need to expose some "getCircuitBreakerState" to see if it can be used or not) but maybe I'm too used to decorators ;). The key point for [pool] is the last one, the

Re: [pool] Recovering from transient factory outages

2024-02-13 Thread Phil Steitz
Thanks, Romain, this is awesome. I would really like to find a way to get this kind of thing implemented in [pool] or via enhanced factories. See more on that below. On Tue, Feb 13, 2024 at 1:27 PM Romain Manni-Bucau wrote: > Hi Phil, > > What I used by the past for this kind of thing was to

Re: [pool] Recovering from transient factory outages

2024-02-13 Thread Romain Manni-Bucau
Hi Phil, What I used by the past for this kind of thing was to rely on the timeout of the pool plus in the healthcheck - external to the pool - have some trigger (the simplest was "if 5 healthchecks fail without any success in between" for ex), such trigger will spawn a task (think thread even if

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Phil Steitz
On Tue, Feb 13, 2024 at 1:03 PM Bernd Eckenfels wrote: > Phil Steitz wrote on 13. Feb 2024 20:46 (GMT +01:00): > > Thanks, Gary. I agree with everything below. I think it's best to just > > leave things as they are. > > If it’s plugable the project might not have to care, > But then how to fix

[pool] Recovering from transient factory outages

2024-02-13 Thread Phil Steitz
POOL-407 tracks a basic liveness problem that we have never been able to solve: A factory "goes down" resulting in either failed object creation or failed validation during the outage. The pool has capacity to create, but the factory fails to serve threads as they arrive, so they end up parked

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Bernd Eckenfels
Phil Steitz wrote on 13. Feb 2024 20:46 (GMT +01:00): > Thanks, Gary. I agree with everything below. I think it's best to just > leave things as they are. If it’s plugable the project might not have to care, But then how to fix the reported problem? Do we have an idea what’s causing it? And a

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Phil Steitz
Thanks, Gary. I agree with everything below. I think it's best to just leave things as they are. Phil On Mon, Feb 12, 2024 at 7:25 PM Gary Gregory wrote: > I've used many JDBC drivers from different vendors, FOSS and > proprietary, and if I've learned one thing, it is that each is its own >

Re: (commons-net) branch master updated: Add Javadoc @return comments

2024-02-13 Thread Gary Gregory
Note that I try to always make the @since tag the last one. YMMV. Gary On Tue, Feb 13, 2024 at 6:55 AM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-net.git > >

Re: [LOGGING] 2.0

2024-02-13 Thread Piotr P. Karwasz
Hi Gary, On Sat, 10 Feb 2024 at 17:26, Gary Gregory wrote: > The package would change from org.apache.commons.logging to > org.apache.commons.logging2. > The Maven coordinates would change from > commons-logging:commons-logging to org.apache.commons:commons-logging2 The only case in

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-13 Thread sebb
On Tue, 13 Feb 2024 at 00:40, sebb wrote: > > On Mon, 12 Feb 2024 at 16:40, Elliotte Rusty Harold > wrote: > > > > Be careful with this one. I don't have full context, but this looks > > likely to be a real bug on some code paths and perhaps not a bug on > > others. We'll need to make sure that