Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/60
You're welcome!
Thought it would be preferred by comments.
However, I will try to keep in mind.
And be cautious what you wish. ;-)
---
If your project is set up for it, you can
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/27
Increase code coverage one
I have created Unit Tests to increase code coverage which I want to
contribute.
You can merge this pull request into a Git repository by running:
$ git
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
@garydgregory
Thanks for your response.
Looked over the secretary@ section ...
Referring to your question if some of the tests were generated:
I use a lot of tools
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
@garydgregory
You're welcome.
Where to send the pdf to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770520
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
As the pull request is already closed shall I reopen another with the same
name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768831
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770670
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127761190
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768274
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127769590
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
---
@@ -0,0 +1,35 @@
+package
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Improvements made in #28.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127775941
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/28
Increase code coverage one
Added various improvements to selected Unit Tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-collections/pull/24
What does it mean that the asfgit bot closed my pull request?
Was it accepted or rejected?
Or even worse - ignored completely?
As there is no reaction in this pull request
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-collections/pull/24
@jvz
Thanks for your answer!
I really haven't got any glue as I am not so much experienced with the
habits here at Github and Open Source development conventions in general
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-collections/pull/24
Okay ...
Now it's getting definitely a little bit wired. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Just submitted my ICLA to secret...@apache.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Just sent it to you via email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Well, now I did a "mvn clean verify".
It didn't complain about anything than for too less code coverage.
However, I've checked what you claimed referring the
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-text/pull/56
add-some-Unit Tests
I have created new Unit Tests which cover previously untested lines of code
which I want to contribute.
You can merge this pull request into a Git repository
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127843760
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-collections/pull/24#discussion_r128054680
--- Diff:
src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
---
@@ -16,12 +16,14 @@
*/
package
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/56
You mean the cases reported by the checkstyle plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/56
Reformatted requested code artifacts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
The CI fails due to the GrayscaleRountripTest which wasn't changed by me.
As it runs locally on my side I consider the timeout problem issued by the
Travis server to be a local
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/27
@garydgregory
Here we go, directory naming problem solved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/56
You're welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129108740
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129106989
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/56
Obviously a problem occurred with Travis:
> The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true
-B -V " failed. Retrying, 2 of 3.
>
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129109286
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-text/pull/58
Add tests
Created Unit Tests which cover previously uncovered lines and which I want
to contribute.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/29
You're welcome.
However, have to get used to the importance of style topics yet ...
Regarding the GreyScaleRoundTripTest:
Yes.
However, I thing or better guess it has
Github user TheRealHaui closed the pull request at:
https://github.com/apache/commons-imaging/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/29
Improve various unit tests style
Code formatting changed as desired in #27 and #28.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/28
Done in #29.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/58
You're welcome!
Here we go regarding the exception detection code style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-text/pull/60
additional-tests
Added Unit Tests which cover previously untested code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/30
Checks failed due to Travis JDK crashing not due to problems in code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130609309
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/60
Rechecked for blank lines and removed them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/30
add-tests
Added new Unit Tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-imaging add-tests
Alternatively
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132308184
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
Well, Equalsverifier
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132311416
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
Understand your point
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306981
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132307800
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java
---
@@ -0,0 +1,55
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/30
Changes incorporated.
Build working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306138
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-compress/pull/33
add-some-Unit-Tests Added some Unit Tests to increase code coverage.
I have added some Unit Tests to increase code coverage and want to
contribute them.
You can merge this pull
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
@bodewig
Could you be so kind an review my contribution and - of course - most of
all pull it into the code base.
---
If your project is set up for it, you can reply to this email
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
Link to the pull request: https://github.com/apache/commons-compress/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-compress/pull/35
Compress 412
Fixed Jira issue Compress 412:
https://issues.apache.org/jira/browse/COMPRESS-412
You can merge this pull request into a Git repository by running:
$ git pull https
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-compress/pull/33
@bodewig
Thank you for your kind response!
Really appreciate that!
Therefore I've made all the changes you requested/proposed.
And of course added myself
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/63
@chtompki
If you want me to re-push any minor change to re-trigger the build just
tell.
---
-
To unsubscribe, e
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/63
You're welcome.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/63
Well, of course!
And much, much, much more in Java!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/63
:-)
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-text/pull/63
small-code-quality-improvements
Made small code quality improvements.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140526276
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,13 +615,11 @@ public static String swapCase(final String str
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140528491
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit tools
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140524746
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit tools
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140525860
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,13 +615,11 @@ public static String swapCase(final String str
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140548121
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,10 +614,7 @@ public static String swapCase(final String str
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/31
add-missing-license-headers
Added missing license headers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r139785201
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
---
@@ -1,3 +1,19 @@
+/*
--- End diff
66 matches
Mail list logo
