Re: [ALL] Parent pom - test.jar and test-sources.jar

2012-03-09 Thread sebb
On 9 March 2012 08:00, Luc Maisonobe luc.maison...@free.fr wrote: Le 09/03/2012 03:03, sebb a écrit : Some while back, we discussed including binary (and source) jars for the test code in releases. [The test source code is already included in the source archive]. The intention was to make

Re: [math] javadoc unbalanced code

2012-03-09 Thread sebb
On 9 March 2012 10:50, Benedikt Ritter benerit...@googlemail.com wrote: Thanks for the patch Dennis! Feel free create a JIRA ticket [1] for this issue, where you can attach your patch (and maybe more ;). One little suggestion for improvement: According to [2] {@code } should be used in instead

Re: [math] javadoc unbalanced code

2012-03-09 Thread sebb
On 9 March 2012 11:12, Gilles Sadowski gil...@harfang.homelinux.org wrote: On Fri, Mar 09, 2012 at 11:50:15AM +0100, Benedikt Ritter wrote: Thanks for the patch Dennis! Feel free create a JIRA ticket [1] for this issue, where you can attach your patch (and maybe more ;). One little suggestion

Re: [PARENT] Ready for release 24?

2012-03-09 Thread sebb
On 9 March 2012 17:25, Gary Gregory garydgreg...@gmail.com wrote: Sebb and others: Wondering about updating wagon-ssh 1.0 to 2.2. Thoughts? No idea. What's 2.2 got that 1.0 hasn't? And vice versa? Only seems to be relevant to Maven3 site invocations. I don't use M3 by default so have no idea

Re: [PARENT] Ready for release 24?

2012-03-09 Thread sebb
On 9 March 2012 18:43, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 1:09 PM, sebb seb...@gmail.com wrote: On 9 March 2012 17:25, Gary Gregory garydgreg...@gmail.com wrote: Sebb and others: Wondering about updating wagon-ssh 1.0 to 2.2. Thoughts? No idea. What's 2.2 got

Re: [codec] What version should implement a behavior change?

2012-03-09 Thread sebb
person.   Bad habit. yours, Julius On Tue, Mar 6, 2012 at 11:40 AM, sebb seb...@gmail.com wrote: On 6 March 2012 19:33, Gary Gregory garydgreg...@gmail.com wrote: What about passing in a boolean strict to the constructor of the codecs? What does strict mean? See my comment

Re: [codec] What version should implement a behavior change?

2012-03-09 Thread sebb
On 9 March 2012 19:15, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 2:12 PM, sebb seb...@gmail.com wrote: On 9 March 2012 19:02, Gary Gregory garydgreg...@gmail.com wrote: Ok, so now, it look like the next release will be 1.7 and not 1.6.1 because of the addition

Re: [PARENT] 24-SNAPSHOT pushed again

2012-03-09 Thread sebb
On 9 March 2012 20:35, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 2:50 PM, sebb seb...@gmail.com wrote: I've just updated the CP24-SNAPSHOT in case anyone wants to try using it. I must not have Maven set up to pick SNAPSHOTS, where is that doc's for our snapshots

Re: [PARENT] Ready for release 24?

2012-03-09 Thread sebb
/ On Fri, Mar 9, 2012 at 7:51 PM, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 1:49 PM, sebb seb...@gmail.com wrote: On 9 March 2012 18:43, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 1:09 PM, sebb seb...@gmail.com wrote: On 9 March 2012 17

Re: [VOTE][RESULT] Promote [csv] to Commons proper

2012-03-09 Thread sebb
On 9 March 2012 22:06, Emmanuel Bourg ebo...@apache.org wrote: The vote to promote Commons CSV to Commons proper has passed with 13 +1: Christian Grobmeier +1 Damjan Jovanovic    +1 Dennis Lundberg     +1 Emmanuel Bourg      +1 Gary Gregory        +1 James Carman        +1 Jörg Schaible  

Re: [VOTE][RESULT] Promote [csv] to Commons proper

2012-03-09 Thread sebb
On 9 March 2012 23:41, sebb seb...@gmail.com wrote: On 9 March 2012 22:06, Emmanuel Bourg ebo...@apache.org wrote: The vote to promote Commons CSV to Commons proper has passed with 13 +1: Christian Grobmeier +1 Damjan Jovanovic    +1 Dennis Lundberg     +1 Emmanuel Bourg      +1 Gary

[CSV] Site tidyup

2012-03-09 Thread sebb
I think CSV is now converted to be a proper component; the website should synch in an hour or two. Someone needs to create a logo and store it at src/site/resources/images/csv-logo.png Also, I cannot remember how to derive the JIRA id for the pom; it will need to be changed as it presumably

[VOTE] Release Commons Parent 24 based on RC2 (lazy consensus)

2012-03-09 Thread sebb
This is a VOTE to release commons-parent 24 based on RC2. As agreed previously, commons parent release votes operate on lazy consensus, i.e. the vote is assumed to have passed if 72 hours have elapsed without an objection. Release notes (including changes):

Re: [CSV] Site tidyup

2012-03-10 Thread sebb
On 10 March 2012 10:45, Emmanuel Bourg ebo...@apache.org wrote: Gary, Sebastian, thank you for the help! Do you know how we get the old site location to redirect to the new one? Done. It was a question of updating the file: sandbox/.htaccess Emmanuel Bourg

Re: [VOTE][RESULT] Promote [csv] to Commons proper

2012-03-10 Thread sebb
On 10 March 2012 14:44, Matt Benson gudnabr...@gmail.com wrote: On Fri, Mar 9, 2012 at 6:02 PM, sebb seb...@gmail.com wrote: On 9 March 2012 23:41, sebb seb...@gmail.com wrote: On 9 March 2012 22:06, Emmanuel Bourg ebo...@apache.org wrote: The vote to promote Commons CSV to Commons proper has

Re: svn commit: r1299315 - in /commons/proper/csv/trunk: pom.xml src/site/xdoc/issue-tracking.xml

2012-03-10 Thread sebb
On 11 March 2012 00:13, nia...@apache.org wrote: Author: niallp Date: Sun Mar 11 00:13:46 2012 New Revision: 1299315 URL: http://svn.apache.org/viewvc?rev=1299315view=rev Log: Fix issue-tracking page config re-generate Thanks! Modified:    commons/proper/csv/trunk/pom.xml    

[ALL] Assembly descriptors belong under src/main/assembly

2012-03-11 Thread sebb
Maven assembly descriptors should normally reside under src/main/assembly (not src/assembly), according to the standard Maven directory layout at http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html The following projects currently use a different

Re: [csv] Serializable on CSVFormat

2012-03-11 Thread sebb
On 11 March 2012 23:27, Emmanuel Bourg ebo...@apache.org wrote: Le 12/03/2012 00:16, Benedikt Ritter a écrit : Hi, I just saw that CSVFormat implements Serializable, but neither does it provide a no-arg constructor nor any of the special serialization methods (and it has no custom

Re: [PARENT] 24-SNAPSHOT pushed again

2012-03-11 Thread sebb
On 11 March 2012 17:15, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 6:24 PM, sebb seb...@gmail.com wrote: On 9 March 2012 20:35, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 9, 2012 at 2:50 PM, sebb seb...@gmail.com wrote: I've just updated the CP24

Re: [csv] Serializable on CSVFormat

2012-03-12 Thread sebb
On 12 March 2012 09:02, Jörg Schaible joerg.schai...@scalaris.com wrote: Emmanuel Bourg wrote: Le 12/03/2012 00:16, Benedikt Ritter a écrit : I just saw that CSVFormat implements Serializable, but neither does it provide a no-arg constructor nor any of the special serialization methods (and

Re: [ANNOUNCE] Commons Math version 3.0 is released

2012-03-12 Thread sebb
On 12 March 2012 15:08, Thomas Neidhart thomas.neidh...@gmail.com wrote: 2012/3/12 Sébastien Brisard sebastien.bris...@m4x.org Hi, I was unable to download the binaries of this release from the website. Downloading the source works fine. Maybe I did something wrong, could anyone else check?

Re: [csv] Performance comparison

2012-03-12 Thread sebb
On 12 March 2012 10:31, Emmanuel Bourg ebo...@apache.org wrote: I have identified the performance killer, it's the ExtendedBufferedReader. It implements a complex logic to fetch one character ahead, but this extra character is rarely used. I have implemented a simpler look ahead using

[MATH] Does website really need Javadoc for versions prior to 2.2?

2012-03-12 Thread sebb
In addition to Javadoc for 3.0 and 2.2, the website still offers the following: Javadoc (2.1 release) Javadoc (2.0 release) Javadoc (1.2 release) Javadoc (1.1 release) Javadoc (1.0 release) This seems rather unnecessary. Surely we should only offer Javadoc for current releases?

Re: [csv] Serializable on CSVFormat

2012-03-12 Thread sebb
of serialisation adds extra testing and maintenance overhead. On Mar 12, 2012 11:23 AM, sebb seb...@gmail.com wrote: On 12 March 2012 09:02, Jörg Schaible joerg.schai...@scalaris.com wrote: Emmanuel Bourg wrote: Le 12/03/2012 00:16, Benedikt Ritter a écrit : I just saw that CSVFormat

Re: svn commit: r1299580 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java

2012-03-12 Thread sebb
On 12 March 2012 08:45, ebo...@apache.org wrote: Author: ebourg Date: Mon Mar 12 08:45:34 2012 New Revision: 1299580 URL: http://svn.apache.org/viewvc?rev=1299580view=rev Log: Serialization test for CSVFormat Note: this does not test serialisation between versions or JDKs as the same JVM

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread sebb
On 12 March 2012 17:38, Emmanuel Bourg ebo...@apache.org wrote: Le 12/03/2012 18:31, Benedikt Ritter a écrit : I'm not sure if I got you right. You have to pass a CSVFormat if you want to construct a CSVLexer(), so we could use the lexer's internal CSVformat. Yes that's what I understood,

Re: [csv] Headers

2012-03-12 Thread sebb
On 12 March 2012 22:11, Emmanuel Bourg ebo...@apache.org wrote: [csv] is missing some elements to ease the use of headers. I have no clear idea on how to address this, here are my thoughts. Headers are used when the fields are accessed by the column name rather than by the index. This

Re: [csv] Performance comparison

2012-03-12 Thread sebb
On 13 March 2012 00:12, Emmanuel Bourg ebo...@apache.org wrote: I kept tickling ExtendedBufferedReader and I have some interesting results. First I tried to simplify it by extending java.io.LineNumberReader instead of BufferedReader. The performance decreased by 20%, probably because the

Re: [csv] Performance comparison

2012-03-12 Thread sebb
On 13 March 2012 00:29, Emmanuel Bourg ebo...@apache.org wrote: Le 13/03/2012 01:25, sebb a écrit : I'm concerned that the CSV code may grow and grow with private versions of code that could be provided by the JDK. By all means make sure the code is efficient in the way it uses the JDK

[VOTE][RESULT] Release Commons Parent 24 based on RC2 (lazy consensus)

2012-03-12 Thread sebb
On 10 March 2012 01:02, sebb seb...@gmail.com wrote: This is a VOTE to release commons-parent 24 based on RC2. As agreed previously, commons parent release votes operate on lazy consensus, i.e. the vote is assumed to have passed if 72 hours have elapsed without an objection. 72 hours have

Re: [csv] Performance comparison

2012-03-12 Thread sebb
On 13 March 2012 01:47, Niall Pemberton niall.pember...@gmail.com wrote: On Tue, Mar 13, 2012 at 12:29 AM, Emmanuel Bourg ebo...@apache.org wrote: Le 13/03/2012 01:25, sebb a écrit : I'm concerned that the CSV code may grow and grow with private versions of code that could be provided

Re: [csv] Headers

2012-03-13 Thread sebb
On 13 March 2012 08:52, Emmanuel Bourg ebo...@apache.org wrote: Le 13/03/2012 09:21, Jörg Schaible a écrit : If the file has a header, the fields are matched by attribute name, and an annotation can override the name of the column associated to an attribute. Yeah, but that's not required.

Re: [csv] Performance comparison

2012-03-13 Thread sebb
On 13 March 2012 09:01, Emmanuel Bourg ebo...@apache.org wrote: Le 13/03/2012 01:44, sebb a écrit : I don't think we should be trying to recode JDK classes. I'd rather not, but we have done that in the past. FastDateFormat and StrBuilder come to mind. And now Java has StringBuilder, which

[ANNOUNCE] Commons Parent 24 released

2012-03-13 Thread sebb
Commons Parent has been released. Main changes: - added tests and test-source jars to the release profile. - Added cobertura: 2.5.1 to reporting and buildManagement - Add default project info reports: excluded license/plugins/plugin management Release notes (including all changes):

[ALL] Commons Parent reports

2012-03-13 Thread sebb
Commons Parent 24 includes the following reports: Javadoc Jxr Surefire RAT Cobertura Clirr JDepend I think the following should be added: Changes/JIRA The following could be added: Findbugs Checkstyle Any others? - To

Re: [io] Help with CharSequenceInputStream [WAS: [GUMP@vmgump]: Project commons-io-test (in module apache-commons) failed]

2012-03-13 Thread sebb
On 13 March 2012 13:23, Gary Gregory garydgreg...@gmail.com wrote: Hello All, Can the author/committer of CharSequenceInputStream[Test] take a look at why Gump is failing? Seems to be intermittent. I've added a bit more debug which I hope will help next time. Thank you, Gary On Mon, Mar

Re: [ALL] Commons Parent reports

2012-03-13 Thread sebb
On 13 March 2012 17:59, Gary Gregory garydgreg...@gmail.com wrote: On Mar 13, 2012, at 12:40, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hi. [...] The tools are there, but you have to tell people that they _must_ use them. Commons has already enough rules and process. As

Re: [io] Help with CharSequenceInputStream [WAS: [GUMP@vmgump]: Project commons-io-test (in module apache-commons) failed]

2012-03-13 Thread sebb
On 13 March 2012 18:17, Gary Gregory garydgreg...@gmail.com wrote: On Tue, Mar 13, 2012 at 12:27 PM, sebb seb...@gmail.com wrote: On 13 March 2012 13:23, Gary Gregory garydgreg...@gmail.com wrote: Hello All, Can the author/committer of CharSequenceInputStream[Test] take a look at why

Re: svn commit: r1300298 - in /commons/proper/io/trunk/src/site: site.xml xdoc/index.xml xdoc/upgradeto2_2.xml

2012-03-13 Thread sebb
On 13 March 2012 19:29, ggreg...@apache.org wrote: Author: ggregory Date: Tue Mar 13 19:29:16 2012 New Revision: 1300298 URL: http://svn.apache.org/viewvc?rev=1300298view=rev Log: Preparing 2.2 release. Added:    commons/proper/io/trunk/src/site/xdoc/upgradeto2_2.xml Modified:    

Re: svn commit: r1300429 - in /commons/proper/commons-parent/trunk: pom.xml src/changes/changes.xml

2012-03-13 Thread sebb
at 8:43 PM, s...@apache.org wrote: Author: sebb Date: Wed Mar 14 00:43:23 2012 New Revision: 1300429 URL: http://svn.apache.org/viewvc?rev=1300429view=rev Log: Add changes and Jira reports Modified:    commons/proper/commons-parent/trunk/pom.xml    commons/proper/commons-parent/trunk/src

Re: svn commit: r1300516 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/UnicodeUnescapeReader.java test/java/org/apache/commons/csv/CharBufferTest.java test/java/org/apache/commo

2012-03-14 Thread sebb
On 14 March 2012 12:01, ebo...@apache.org wrote: Author: ebourg Date: Wed Mar 14 12:01:47 2012 New Revision: 1300516 URL: http://svn.apache.org/viewvc?rev=1300516view=rev Log: Improved test coverage Modified:    

Re: [ALL] Is that 1 or l or I ?

2012-03-14 Thread sebb
On 14 March 2012 14:00, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Mar 14, 2012 at 9:33 AM, sebb seb...@gmail.com wrote: I noticed that some of the CSV methods uses int l (ell). This is unfortunately very similar to 1 (one) in many fonts. ExtendedBufferedReader.read

Re: [ALL] Commons Parent reports

2012-03-14 Thread sebb
On 14 March 2012 16:27, Honton, Charles charles_hon...@intuit.com wrote: As a user of commons libraries, I look at several reports.  I'll consult Javadoc first.  In the case the javadoc is silent about behavior, I look at JXR. +1, JXR has been very useful to me. When I am debugging my

Re: [ALL] Commons Parent reports

2012-03-14 Thread sebb
On 13 March 2012 11:48, sebb seb...@gmail.com wrote: Commons Parent 24 includes the following reports: Javadoc Jxr Surefire RAT Cobertura Clirr JDepend I think the following should be added: Changes/JIRA Done. The following could be added: Findbugs Checkstyle Any others

Re: [ALL] Is that 1 or l or I ?

2012-03-14 Thread sebb
. in for loops, using i and j is such a common idiom that renaming won't necessarily improve readability. -Adrian On 3/14/2012 1:33 PM, sebb wrote: I noticed that some of the CSV methods uses int l (ell). This is unfortunately very similar to 1 (one) in many fonts. ExtendedBufferedReader.read

Re: svn commit: r1300659 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVParser.java main/java/org/apache/commons/csv/CharBuffer.java test/java/org/apache/commons/csv/CharBuffe

2012-03-14 Thread sebb
On 14 March 2012 17:42, ebo...@apache.org wrote: Author: ebourg Date: Wed Mar 14 17:42:28 2012 New Revision: 1300659 URL: http://svn.apache.org/viewvc?rev=1300659view=rev Log: Replaced CharBuffer with StringBuilder (CSV-59) Removed:    

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread sebb
On 14 March 2012 21:02, Emmanuel Bourg ebo...@apache.org wrote: Le 14/03/2012 21:52, Benedikt Ritter a écrit : the subject of this mail is pretty self-explanatory. Why do we need a package private validate() method, given the fact, that users can not create custom instances (constructor is

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread sebb
On 14 March 2012 21:41, Emmanuel Bourg ebo...@apache.org wrote: Le 14/03/2012 22:16, sebb a écrit : In which case, reversing the order would work. We would just have to document this as a restriction. Too much burden on the user. The problem with leaving the validation until later

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread sebb
On 14 March 2012 21:40, Benedikt Ritter benerit...@googlemail.com wrote: Am 14. März 2012 22:33 schrieb Emmanuel Bourg ebo...@apache.org: Le 14/03/2012 22:25, Benedikt Ritter a écrit : I agree with you on this. However, I think it would be better to tie validation to the object creation.

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread sebb
On 14 March 2012 21:56, Emmanuel Bourg ebo...@apache.org wrote: Le 14/03/2012 22:44, sebb a écrit : It's not possible to use null for a char value. It assumed we changed the signature of the methods with java.lang.Character, while retaining the primitive internally. But that's not possible

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-14 Thread sebb
On 14 March 2012 22:54, Emmanuel Bourg ebo...@apache.org wrote: Le 14/03/2012 23:35, sebb a écrit : It's not too late to change to using Character. The issue is the parser, this will probably degrade the performance. Unless the fields are made package private and accessed directly

Re: svn commit: r1300925 - /commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/AccessibleObjectsRegistry.java

2012-03-15 Thread sebb
On 15 March 2012 11:26, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 11:26:25 2012 New Revision: 1300925 URL: http://svn.apache.org/viewvc?rev=1300925view=rev Log: just incrementally built the hashcode in the constructor I wondered why you did not use the

[CSV] Performance

2012-03-15 Thread sebb
In my testing, using final class variables for delimiter, escape etc (set in ctor) shaves about 1 sec off the time to read the world town data file compared with accessing these fields inline through the format field. Average time goes from c. 25.5 to c. 24.5 which is a 4% improvement. I suspect

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 12:43, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 13:34, sebb a écrit : In my testing, using final class variables for delimiter, escape etc (set in ctor) shaves about 1 sec off the time to read the world town data file compared with accessing these fields inline

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 13:17, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 14:13, sebb a écrit : Eclipse, so probably client VM? Probably. You can print the java.vm.name system property at the beginning of the test, that will tell you the VM used. It was client. I've now tried

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 16:10, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 16:45, sebb a écrit : So I then tried hauling the format method calls out of the loops into final local variables. This improves performance (slightly) in both client and server mode. Could you show some code

Re: [CSV] Performance

2012-03-15 Thread sebb
On 15 March 2012 16:48, Emmanuel Bourg ebo...@apache.org wrote: Le 15/03/2012 17:42, sebb a écrit : I also used local vars in the other methods. See http://people.apache.org/~sebb/CSV/ Thank you. You also reordered the if in simpleTokenLexer, that may explain the difference. I'll give

Re: svn commit: r1301177 - /commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/binder/AbstractRulesModule.java

2012-03-15 Thread sebb
On 15 March 2012 20:09, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 15 20:09:31 2012 New Revision: 1301177 URL: http://svn.apache.org/viewvc?rev=1301177view=rev Log: potential fix for [DIGESTER-163] If the problem is due to multi-threading issues, isn't that

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread sebb
Have a look at the sample builder implementation in https://issues.apache.org/jira/browse/CSV-68 On 16 March 2012 09:45, Emmanuel Bourg ebo...@apache.org wrote: Hi Benedikt, I accept that, and I respect your decision. I don't want to argue with you on this, I just want to understand your

Re: [csv] Improving readability in CSVLexer

2012-03-16 Thread sebb
On 16 March 2012 12:33, Benedikt Ritter benerit...@googlemail.com wrote: Hey, I'm thinking of ways to improve the readability of CSVLexer. I think that it might be easier to improve performance if the code is easier to understand. Here is, what I think can be improved: 1. eliminate Token

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread sebb
Emmanuel? Could sebb convince you? ;-) How about this: I'll create a patch and attach it to JIRA. Then we'll have a better basis for discussion. Sorry but I'm not convinced. I see exactly where this leads. Hey Emmanuel, I accept that, and I respect your decision. I don't want

Re: [VOTE] Release Commons IO 2.2-RC1

2012-03-16 Thread sebb
. Thanks to jsteuerwald, detinho. o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to kaykay.unique. o IOUtils.closeQuietly() should take a ServerSocket as a parameter  Issue: IO-292. Thanks to sebb. o Add read/readFully methods to IOUtils  Issue: IO-290. Thanks to sebb. o

Re: svn commit: r1242742 - in /commons/proper/pool/trunk: build.xml pom.xml

2012-03-17 Thread sebb
On 10 February 2012 11:08, ma...@apache.org wrote: Author: markt Date: Fri Feb 10 11:08:55 2012 New Revision: 1242742 URL: http://svn.apache.org/viewvc?rev=1242742view=rev Log: Target Java 6 since 1.5 is out of support unless you pay for it. But the code does not actually use any 1.6

Re: [math] Checkstyle too stringent?

2012-03-18 Thread sebb
2012/3/18 Sébastien Brisard sebastien.bris...@m4x.org: Hi, I'm trying to clean up the SymmLQ class (see MATH-761 [1]). The problem is the heart of the algorithm is very long (it would probably amount to more thatn 600 lines). When I first implemented it, I figured that I could split this

Re: [math] Checkstyle too stringent?

2012-03-18 Thread sebb
2012/3/18 Sébastien Brisard sebastien.bris...@m4x.org: Hi, 2012/3/18 sebb seb...@gmail.com: 2012/3/18 Sébastien Brisard sebastien.bris...@m4x.org: Hi, I'm trying to clean up the SymmLQ class (see MATH-761 [1]). The problem is the heart of the algorithm is very long (it would probably

Re: svn commit: r1302060 - in /commons/proper/io/tags/2.2-RC2: ./ src/main/java/org/apache/commons/io/ src/main/java/org/apache/commons/io/comparator/ src/main/java/org/apache/commons/io/filefilter/ s

2012-03-18 Thread sebb
On 18 March 2012 03:36, ggreg...@apache.org wrote: Author: ggregory Date: Sun Mar 18 03:36:32 2012 New Revision: 1302060 URL: http://svn.apache.org/viewvc?rev=1302060view=rev Log: Create commons-io-2.2-RC2. Not sure what happened there - looks rather messy. But I see you have now moved

Re: svn commit: r1302179 - /commons/proper/io/trunk/RELEASE-NOTES.txt

2012-03-18 Thread sebb
On 18 March 2012 17:41, ggreg...@apache.org wrote: Author: ggregory Date: Sun Mar 18 17:41:29 2012 New Revision: 1302179 URL: http://svn.apache.org/viewvc?rev=1302179view=rev Log: Add compatibility section. Modified:    commons/proper/io/trunk/RELEASE-NOTES.txt Modified:

Re: [math] Checkstyle too stringent?

2012-03-19 Thread sebb
2012/3/19 Sébastien Brisard sebastien.bris...@m4x.org: 2012/3/18 sebb seb...@gmail.com: 2012/3/18 Sébastien Brisard sebastien.bris...@m4x.org: Hi, 2012/3/18 sebb seb...@gmail.com: 2012/3/18 Sébastien Brisard sebastien.bris...@m4x.org: Hi, I'm trying to clean up the SymmLQ class (see MATH

Re: svn commit: r1302298 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/SymmLQ.java

2012-03-19 Thread sebb
On 19 March 2012 06:46, celes...@apache.org wrote: Author: celestin Date: Mon Mar 19 06:46:32 2012 New Revision: 1302298 URL: http://svn.apache.org/viewvc?rev=1302298view=rev Log: In class o.a.c.math3.linear.SymmLQ  - Changed parameter order for the constructor of nested class State (for

Re: svn commit: r1302387 - in /commons/proper/math/trunk/src: main/resources/assets/org/apache/commons/math3/exception/util/LocalizedFormats_fr.properties site/xdoc/userguide/filter.xml

2012-03-19 Thread sebb
$ in the @version javadoc tag? I was just fixing the incorrect format - removing the enclosing double-quotes - not adjusting the keywords. Sébastien 2012/3/19  s...@apache.org: Author: sebb Date: Mon Mar 19 12:00:54 2012 New Revision: 1302387 URL: http://svn.apache.org/viewvc?rev

Re: [BCEL] 6.0 release

2012-03-19 Thread sebb
On 19 March 2012 14:18, Honton, Charles charles_hon...@intuit.com wrote: Any idea when BCEL 6.0 (with support for annotations) will be released? No idea. Is there a maven repository available for the snapshot version? Continuum builds are uploaded here:

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-19 Thread sebb
without BOM multiple times  Issue: IO-302. Thanks to jsteuerwald, detinho. o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to kaykay.unique. o IOUtils.closeQuietly() should take a ServerSocket as a parameter  Issue: IO-292. Thanks to sebb. o Add read/readFully methods

Re: [continuum] BUILD FAILURE: Apache Commons - Commons IO - Default Maven 2 Build Definition (Java 1.5)

2012-03-20 Thread sebb
On 20 March 2012 07:40, Jörg Schaible joerg.schai...@scalaris.com wrote: Gary Gregory wrote: What is this all about? [ERROR] BUILD ERROR [INFO] [ [INFO] Error deploying artifact: Authorization failed: Access denied

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-20 Thread sebb
On 20 March 2012 01:51, Gary Gregory garydgreg...@gmail.com wrote: On Mon, Mar 19, 2012 at 6:45 PM, sebb seb...@gmail.com wrote: On 18 March 2012 19:03, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons IO 2.2-RC3 The changes from RC2 are: - Remove

Re: svn commit: r1302748 - in /commons/proper/io/trunk: ./ src/main/java/org/apache/commons/io/ src/main/java/org/apache/commons/io/comparator/ src/main/java/org/apache/commons/io/filefilter/ src/main

2012-03-20 Thread sebb
On 20 March 2012 01:35, ggreg...@apache.org wrote: Author: ggregory Date: Tue Mar 20 01:35:32 2012 New Revision: 1302748 URL: http://svn.apache.org/viewvc?rev=1302748view=rev Log: Remove noisy and unnecessary parens. Especially painful in return statements: return (foo + bar); vs. return

Re: [parent] incorrect documentation on site

2012-03-20 Thread sebb
On 20 March 2012 15:43, Honton, Charles charles_hon...@intuit.com wrote: At http://commons.apache.org/commons-parent-pom.html, the section Configuring the Java Source/Target options indicates I should use maven.compiler.source and maven.compiler.target to specify the component's compiler

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-21 Thread sebb
multiple times  Issue: IO-302. Thanks to jsteuerwald, detinho. o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to kaykay.unique. o IOUtils.closeQuietly() should take a ServerSocket as a parameter  Issue: IO-292. Thanks to sebb. o Add read/readFully methods to IOUtils  Issue: IO

Re: svn commit: r1303488 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

2012-03-21 Thread sebb
the builder pattern. Am 21. März 2012 19:20 schrieb  s...@apache.org: Author: sebb Date: Wed Mar 21 18:20:05 2012 New Revision: 1303488 URL: http://svn.apache.org/viewvc?rev=1303488view=rev Log: CSV-74 - CSVFormat definitions are difficult to read and maintain Modified:     commons/proper/csv

Re: [csv] Improving readability in CSVLexer

2012-03-21 Thread sebb
On 21 March 2012 19:16, Benedikt Ritter benerit...@googlemail.com wrote: Hey, I've tried to remove the Token input parameter in CSVLexer.nextToken(). First by creating ne new Token on every invocation of nextToken(). That slowed execution of that method by about 100ms. 100ms per iteration?

Re: [csv] Improving readability in CSVLexer

2012-03-22 Thread sebb
On 22 March 2012 07:33, Benedikt Ritter benerit...@googlemail.com wrote: Am 22. März 2012 00:19 schrieb sebb seb...@gmail.com: On 21 March 2012 19:16, Benedikt Ritter benerit...@googlemail.com wrote: Hey, I've tried to remove the Token input parameter in CSVLexer.nextToken(). First

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-22 Thread sebb
Presumably you have seen IO-311 ? -1 to proceeding with release until this is investigated, and resolved as appropriate. On 21 March 2012 22:23, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Mar 21, 2012 at 6:05 PM, Thomas Neidhart thomas.neidh...@gmail.comwrote: On 03/18/2012 08:03 PM,

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-22 Thread sebb
On 22 March 2012 17:21, sebb seb...@gmail.com wrote: Presumably you have seen IO-311 ? -1 to proceeding with release until this is investigated, and resolved as appropriate. I don't mean cancel the release vote - at least not just yet - but the issue needs to be evaluated before proceeding

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-22 Thread sebb
On 22 March 2012 19:03, Gary Gregory garydgreg...@gmail.com wrote: On Thu, Mar 22, 2012 at 1:24 PM, sebb seb...@gmail.com wrote: On 22 March 2012 17:21, sebb seb...@gmail.com wrote: Presumably you have seen IO-311 ? -1 to proceeding with release until this is investigated, and resolved

Re: [csv] Improving readability in CSVLexer

2012-03-22 Thread sebb
On 22 March 2012 10:40, sebb seb...@gmail.com wrote: On 22 March 2012 07:33, Benedikt Ritter benerit...@googlemail.com wrote: Am 22. März 2012 00:19 schrieb sebb seb...@gmail.com: On 21 March 2012 19:16, Benedikt Ritter benerit...@googlemail.com wrote: Hey, I've tried to remove the Token

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-22 Thread sebb
On 22 March 2012 19:27, Gary Gregory garydgreg...@gmail.com wrote: On Mar 22, 2012, at 15:19, sebb seb...@gmail.com wrote: On 22 March 2012 19:03, Gary Gregory garydgreg...@gmail.com wrote: On Thu, Mar 22, 2012 at 1:24 PM, sebb seb...@gmail.com wrote: On 22 March 2012 17:21, sebb seb

Re: [VOTE] Release Commons IO 2.2-RC3

2012-03-22 Thread sebb
On 22 March 2012 20:10, sebb seb...@gmail.com wrote: On 22 March 2012 19:27, Gary Gregory garydgreg...@gmail.com wrote: On Mar 22, 2012, at 15:19, sebb seb...@gmail.com wrote: On 22 March 2012 19:03, Gary Gregory garydgreg...@gmail.com wrote: On Thu, Mar 22, 2012 at 1:24 PM, sebb seb

[CSV] trimming spaces - are both leading/trailing required?

2012-03-23 Thread sebb
Do we really need to support independent leading/trailing spaces? I've been unable to find any reference to formats that require this. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [CSV] trimming spaces - are both leading/trailing required?

2012-03-23 Thread sebb
On 23 March 2012 11:50, Simone Tripodi simonetrip...@apache.org wrote: I agree with you! spaces maybe are intentionally there, or not? best, Some formats allow spaces either side of a delimiter (or line), some don't. What I'm suggesting is having a single option to either keep spaces or to

Re: svn commit: r1303878 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/PerformanceTest.java

2012-03-23 Thread sebb
On 23 March 2012 07:31, Benedikt Ritter benerit...@googlemail.com wrote: Am 22. März 2012 17:28 schrieb  s...@apache.org: Author: sebb Date: Thu Mar 22 16:28:47 2012 New Revision: 1303878 URL: http://svn.apache.org/viewvc?rev=1303878view=rev Log: Allow testing of dynamically loaded

Re: svn commit: r1304377 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java

2012-03-23 Thread sebb
On 23 March 2012 18:54, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/23/2012 03:39 PM, s...@apache.org wrote: Author: sebb Date: Fri Mar 23 14:39:56 2012 New Revision: 1304377 URL: http://svn.apache.org/viewvc?rev=1304377view=rev Log: Refix bug introduced in r1304137

Re: svn commit: r1305374 - /commons/proper/io/trunk/RELEASE-NOTES.txt

2012-03-26 Thread sebb
:  ArrayIndexOutOfBoundsException in BOMInputStream when reading a file without BOM multiple times Thanks to jsteuerwald, detinho. -o IO-301:  Add IOUtils.closeQuietly(Selector) necessary Thanks to kaykay.unique. -o IO-292:  IOUtils.closeQuietly() should take a ServerSocket as a parameter Thanks to sebb. -o IO-290:  Add

Re: [VOTE] Release Commons IO 2.2-RC4

2012-03-26 Thread sebb
 Issue: IO-302. Thanks to jsteuerwald, detinho. o Add IOUtils.closeQuietly(Selector) necessary  Issue: IO-301. Thanks to kaykay.unique. o IOUtils.closeQuietly() should take a ServerSocket as a parameter  Issue: IO-292. Thanks to sebb. o Add read/readFully methods to IOUtils  Issue: IO-290

Re: svn commit: r1305706 - in /commons/proper/dbutils/trunk/src: main/java/org/apache/commons/dbutils/AbstractQueryRunner.java main/java/org/apache/commons/dbutils/AsyncQueryRunner.java test/java/org/

2012-03-26 Thread sebb
On 27 March 2012 02:39, wspe...@apache.org wrote: Author: wspeirs Date: Tue Mar 27 01:39:27 2012 New Revision: 1305706 URL: http://svn.apache.org/viewvc?rev=1305706view=rev Log: - Applied DBUTILS88v2 patch - Cleaned up a few things CheckStyle and FindBugs were unhappy about Modified:  

Re: [math] Improvement: Interpreter for mathematical expressions

2012-03-27 Thread sebb
2012/3/27 Detlef Günther detlef.guent...@gmx.net: Hello, it would be nice to have an interpreter for mathematical expressions so that functions may be defined at runtime. Example for f(x):  ExpInter ei = new ExpInter();  ei.setFunction(ln(3*sin(2*x)+3));  // Plot the function:  for

Re: [math] Improvement: Interpreter for mathematical expressions

2012-03-27 Thread sebb
On 27 March 2012 13:18, Gary Gregory garydgreg...@gmail.com wrote: On Tue, Mar 27, 2012 at 5:50 AM, sebb seb...@gmail.com wrote: 2012/3/27 Detlef Günther detlef.guent...@gmx.net: Hello, it would be nice to have an interpreter for mathematical expressions so that functions may be defined

Re: [Math] changes HTML report

2012-03-28 Thread sebb
On 28 March 2012 12:26, Thomas Neidhart thomas.neidh...@gmail.com wrote: On Wed, Mar 28, 2012 at 12:27 PM, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hello. [I think that this had already been reported earlier by Thomas.] The HTML page generated from the changes.xml file does not

Re: [Math] On-demand cobertura report

2012-03-28 Thread sebb
On 28 March 2012 15:46, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hello. Please disable the default running of cobertura in mvn site. It is unbearably slow: e.g. on my machine, FastMathTest takes 1,544 seconds (that's a comma there; i.e. ~25 minutes!). If on-demand

Re: svn commit: r1306437 - in /commons/proper/codec/trunk/src: main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java

2012-03-28 Thread sebb
On 28 March 2012 16:43, ggreg...@apache.org wrote: Author: ggregory Date: Wed Mar 28 15:43:55 2012 New Revision: 1306437 URL: http://svn.apache.org/viewvc?rev=1306437view=rev Log: (empty) ??? - To unsubscribe, e-mail:

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Codec - Default Maven 2 Build Definition (Java 1.5)

2012-03-28 Thread sebb
On 28 March 2012 16:53, Gary Gregory garydgreg...@gmail.com wrote: How do I configure Continuum to say -Pjava-1.6 instead of -Pjava-1.5? It's not as easy as it should be. You have to add another project build definition as it's not possible to have multiple group-level definitions. Whatever

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Codec - Default Maven 2 Build Definition (Java 1.5)

2012-03-28 Thread sebb
On 28 March 2012 18:17, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Mar 28, 2012 at 12:50 PM, sebb seb...@gmail.com wrote: On 28 March 2012 16:53, Gary Gregory garydgreg...@gmail.com wrote: How do I configure Continuum to say -Pjava-1.6 instead of -Pjava-1.5? It's not as easy

  1   2   3   4   5   6   7   8   9   10   >