Re: [fileupload] drop JDK1.3 support, update to 1.5 and bump to 2.0.0

2013-03-05 Thread sebb
On 5 March 2013 19:57, Simone Tripodi simonetrip...@apache.org wrote: Just for the record: I don't intend to do a major rewrite ATM, just update and bugfix. So why the change to 2.0? I intend to add at least generics, where possible - in the past, the introduction of generics in digester

Re: [fileupload] drop JDK1.3 support, update to 1.5 and bump to 2.0.0

2013-03-05 Thread sebb
On 5 March 2013 20:56, Simone Tripodi simonetrip...@apache.org wrote: Thanks both Gary and Sebb, It seems very unlikely that anyone will still be running Java 1.3 or Java 1.4, so the change to 1.5 is not likely to concern users, even though it is a bit of a jump. Is the addition of generics

Re: [OGNL] A new release

2013-03-06 Thread sebb
On 6 March 2013 06:49, Lukasz Lenart lukaszlen...@apache.org wrote: Hi, I was checking out what should be solved before releasing a new version and in my opinion most of PMD [1] errors can be omitted, maybe These nested if statements could be combined should be resolved, but the rest I don't

Re: [fileupload] Uploading large files - DONE

2013-03-06 Thread sebb
On 6 March 2013 08:53, Simone Tripodi simonetrip...@apache.org wrote: Is there anybody that can suggest how to handle that situation? Create new methods which return long rather than int; deprecate the old methods. e.g. @Deprecated public int getContentLength() { ... } /** * @since

Re: [fileupload] FileItemHeadersSupport has a wrong @since tag

2013-03-06 Thread sebb
One way to do this is to add SVN tag markers - Eclipse then shows these in the SVN History list. On 6 March 2013 09:20, Simone Tripodi simonetrip...@apache.org wrote: A dummy search on changes-report[1] doesn't show up anything useful - I'll dig later after some work is already done danke

Re: [fileupload] FileItemHeadersSupport has a wrong @since tag

2013-03-06 Thread sebb
for the Maven plugin, but I've never used it). On 6 March 2013 09:40, sebb seb...@gmail.com wrote: One way to do this is to add SVN tag markers - Eclipse then shows these in the SVN History list. On 6 March 2013 09:20, Simone Tripodi simonetrip...@apache.org wrote: A dummy search on changes

Re: [fileupload] FileItemHeadersSupport has a wrong @since tag

2013-03-06 Thread sebb
Same applies to the FileItemHeadersImpl class. On 6 March 2013 09:57, sebb seb...@gmail.com wrote: I've added some tags. Looks like the files were added in 1.2.1; this was in r523066 I expect it was intended that the next release would be 1.3, but for some reason a point release was made

Re: [fileupload] FileItemHeadersSupport has a wrong @since tag

2013-03-06 Thread sebb
I fixed the 3 @since 1.3 markers. On 6 March 2013 09:57, sebb seb...@gmail.com wrote: I've added some tags. Looks like the files were added in 1.2.1; this was in r523066 I expect it was intended that the next release would be 1.3, but for some reason a point release was made. Normally

Re: [BeanUtils] Update to Java 1.5 for next release?

2013-03-06 Thread sebb
On 6 March 2013 11:32, Benedikt Ritter brit...@apache.org wrote: Hi, I have recently learned that changing the required Java version for a component does not necessarily affect binary compartibility [1]. I'm thinking about updating [BeanUtils] to Java 1.5. We would have the following

Re: [fileupload] Uploading large files - DONE

2013-03-06 Thread sebb
On 6 March 2013 11:51, Benedikt Ritter brit...@apache.org wrote: 2013/3/6 sebb seb...@gmail.com On 6 March 2013 08:53, Simone Tripodi simonetrip...@apache.org wrote: Is there anybody that can suggest how to handle that situation? Create new methods which return long rather than int

Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-06 Thread sebb
On 5 March 2013 22:28, Lawrence Angrave angr...@illinois.edu wrote: Hi, Thanks for the feedback. Some comments that are relevant to Apache3 UnicodeEscaper and Apache2's StringEscapeUtils.java Summary- * I noticed the current Apache code creates three String objects each time it

[SITE] more broken links - menu items in LHS for proper components

2013-03-06 Thread sebb
There are yet more broken links on the commons site for all components. Most of the stuff below Project Reports is broken; the only links that aren't are the external ones, i.e. those that don't point to commons.apache.org. This is presumably because the components are now under proper/ rather

Re: [SITE] more broken links - menu items in LHS for proper components

2013-03-06 Thread sebb
On 6 March 2013 16:30, sebb seb...@gmail.com wrote: There are yet more broken links on the commons site for all components. Most of the stuff below Project Reports is broken; the only links that aren't are the external ones, i.e. those that don't point to commons.apache.org

Re: [fileupload] dropping the 'tasks' page

2013-03-07 Thread sebb
OK by me On 7 March 2013 11:29, Simone Tripodi simonetrip...@apache.org wrote: thoughts? :) http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Mar 6, 2013 at 4:21 PM, Simone Tripodi

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread sebb
Remember there is a -Ptest-deploy profile that can be used to test what will be deployed. This puts the output in target/deploy I've found it's sometimes necessary to use package as well as deploy to ensure everything is included in the deploy phase. On 7 March 2013 11:36, Thomas Neidhart

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
OK by me. On 7 March 2013 12:11, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, while the Maven parent and specific component pom continue to evolve during the time, last update on Ant files is back to 2010, gump related files to 2007, I think it would make sense to drop them

Re: [fileupload] suppressing Line is longer than 80 characters. rules

2013-03-07 Thread sebb
On 7 March 2013 12:33, Simone Tripodi simonetrip...@apache.org wrote: Hi all, I am going to increase the Line length up to 120 chars - any objections? OK to change Checkstyle/PMD to eliminate warnings. But I would avoid rewrapping to the new line length unless it's obviously easier to read.

Re: svn commit: r1453909 - /commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml

2013-03-07 Thread sebb
On 7 March 2013 15:05, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 7 15:05:17 2013 New Revision: 1453909 URL: http://svn.apache.org/r1453909 Log: checkstyle: PackageHtml module no longer needed, package documentation moved from package.html to package-info.java

Re: svn commit: r1453831 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java

2013-03-07 Thread sebb
On 7 March 2013 12:52, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 7 12:52:04 2013 New Revision: 1453831 URL: http://svn.apache.org/r1453831 Log: checkstyle: Avoid inline conditionals. I think Checkstyle is wrong in this case. Modified:

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 15:34, Mark Thomas ma...@apache.org wrote: On 07/03/2013 12:11, Simone Tripodi wrote: Hi all guys, while the Maven parent and specific component pom continue to evolve during the time, last update on Ant files is back to 2010, gump related files to 2007, I think it would make

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 16:02, Simone Tripodi simonetrip...@apache.org wrote: I agree the build file cannot be dropped whilst it is still used by Gump, but can't we update FileUpload to use Maven for Gump builds? [Most other components now use Maven with Gump] If so, that would surely satisfy the

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 16:16, sebb seb...@gmail.com wrote: On 7 March 2013 16:02, Simone Tripodi simonetrip...@apache.org wrote: I agree the build file cannot be dropped whilst it is still used by Gump, but can't we update FileUpload to use Maven for Gump builds? [Most other components now use Maven

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread sebb
On 7 March 2013 18:49, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/05/2013 11:08 PM, Thomas Neidhart wrote: Hi, I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. This release candidate has the following changes compared to 1.1.1 (copied from the release

Re: svn commit: r1453990 - /commons/proper/math/trunk/doc/release/release.howto.txt

2013-03-07 Thread sebb
On 7 March 2013 18:36, t...@apache.org wrote: Author: tn Date: Thu Mar 7 18:36:15 2013 New Revision: 1453990 URL: http://svn.apache.org/r1453990 Log: Fix first step in release howto. Modified: commons/proper/math/trunk/doc/release/release.howto.txt Modified:

Re: svn commit: r1454037 - /commons/proper/math/trunk/src/main/assembly/src.xml

2013-03-07 Thread sebb
On 7 March 2013 19:29, t...@apache.org wrote: Author: tn Date: Thu Mar 7 19:29:41 2013 New Revision: 1454037 URL: http://svn.apache.org/r1454037 Log: Exclude download cgi from source distribution. Modified: commons/proper/math/trunk/src/main/assembly/src.xml Modified:

Re: svn commit: r1454057 - /commons/proper/fileupload/trunk/pom.xml

2013-03-07 Thread sebb
On 7 March 2013 19:52, simonetrip...@apache.org wrote: Author: simonetripodi Date: Thu Mar 7 19:52:39 2013 New Revision: 1454057 URL: http://svn.apache.org/r1454057 Log: releng: added RC profile for staging site deployment Is that intended to merge with / override the rc profile in

Re: svn commit: r1454057 - /commons/proper/fileupload/trunk/pom.xml

2013-03-08 Thread sebb
On 8 March 2013 06:52, Simone Tripodi simonetrip...@apache.org wrote: releng: added RC profile for staging site deployment Is that intended to merge with / override the rc profile in parent, or does it have a different function? If so, it should have a different name. to be merged in the

Re: [fileupload] working forward 1.3 RC1

2013-03-08 Thread sebb
On 8 March 2013 13:06, Gary Gregory garydgreg...@gmail.com wrote: Thanks for the pointer. So it looks like Gump is set up for Maven: http://vmgump.apache.org/gump/public/apache-commons/commons-fileupload/ That was from an earlier run using Ant. The Maven config has yet to be tested;

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-08 Thread sebb
On 8 March 2013 07:31, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/08/2013 01:25 AM, sebb wrote: On 7 March 2013 18:49, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/05/2013 11:08 PM, Thomas Neidhart wrote: Hi, I'd like to call a vote for releasing Commons Logging 1.1.2

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-08 Thread sebb
On 8 March 2013 20:28, sebb seb...@gmail.com wrote: On 8 March 2013 07:31, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/08/2013 01:25 AM, sebb wrote: On 7 March 2013 18:49, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/05/2013 11:08 PM, Thomas Neidhart wrote: Hi, I'd like

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread sebb
On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be changed for him to remove the veto. If the requested change is made then all should be fine with the world again

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread sebb
On 9 March 2013 11:56, Niall Pemberton niall.pember...@gmail.com wrote: On Sat, Mar 9, 2013 at 9:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified

Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1

2013-03-09 Thread sebb
On 9 March 2013 14:31, Thomas Neidhart thomas.neidh...@gmail.com wrote: On 03/09/2013 03:23 PM, Simone Tripodi wrote: Hi Thomas, The user proposed a solution - without a patch - that, in his opinion, should work. We do not have a testcase which proves the reported issue, which would affect

Re: [DBUTILS] Working on a DBUtils 2.0 Release Candidate

2013-03-10 Thread sebb
On 10 March 2013 15:53, William Speirs wspe...@apache.org wrote: As the subject implies, I'm trying to get a release candidate ready for DBUtils 2.0. I haven't heard any feedback from the community on my changes, so I'm going to assume everyone loves them ;-) A few issues I'm running into:

Re: [math] releasing 3.2?

2013-03-11 Thread sebb
On 11 March 2013 08:33, Luc Maisonobe luc.maison...@free.fr wrote: Le 11/03/2013 08:51, Luc Maisonobe a écrit : Le 11/03/2013 00:47, sebb a écrit : On 10 March 2013 16:35, Luc Maisonobe luc.maison...@free.fr wrote: Le 10/03/2013 15:28, Thomas Neidhart a écrit : On 03/04/2013 01:24 PM, Luc

Re: svn commit: r1455005 - in /commons/proper/compress/tags/COMPRESS-1.5_RC1: ./ pom.xml

2013-03-11 Thread sebb
On 11 March 2013 06:10, bode...@apache.org wrote: Author: bodewig Date: Mon Mar 11 06:10:51 2013 New Revision: 1455005 URL: http://svn.apache.org/r1455005 Log: Tagging first RC for Compress 1.5 Please don't recreate a tag with the same name. If you need to re-roll, choose the next RC

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread sebb
On 11 March 2013 08:57, Stefan Bodewig bode...@apache.org wrote: Hi all, [took me a few days longer since I wanted to incorporate fixes for the two issues that popped up last week. So here we go.] With 30 JIRA issues fixed it is about time to cut a new release of Commons Compress.

Re: [VOTE] Release Compress 1.5 based on RC1

2013-03-11 Thread sebb
On 11 March 2013 21:18, Benedikt Ritter brit...@apache.org wrote: Hello Stefan, 2013/3/11 Stefan Bodewig bode...@apache.org Hi all, [took me a few days longer since I wanted to incorporate fixes for the two issues that popped up last week. So here we go.] With 30 JIRA issues fixed it is

[ALL] DOAP file placement - move out of trunk?

2013-03-11 Thread sebb
The DOAP files are currently held under /commons/proper/component/trunk/doap_component.rdf This is sort of convenient for editting, but means the doap file gets included in tags and branches and may get included in source. If included in source, the release date may be missing or inaccurate.

Re: [ALL] DOAP file placement - move out of trunk?

2013-03-12 Thread sebb
/doap_fileupload.rdf http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, Mar 12, 2013 at 12:30 AM, sebb seb...@gmail.com wrote: The DOAP files are currently held under /commons/proper/component/trunk

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-12 Thread sebb
On 12 March 2013 09:05, simonetrip...@apache.org wrote: Author: simonetripodi Date: Tue Mar 12 09:05:06 2013 New Revision: 1455456 URL: http://svn.apache.org/r1455456 Log: trivial: extracted POST string constant Modified:

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-12 Thread sebb
On 12 March 2013 11:17, James Carman jcar...@carmanconsulting.com wrote: On Mar 9, 2013, at 7:32 AM, sebb seb...@gmail.com wrote: I would have voted -1 on the RC, because the tag would not agree with the source archive. However, releases cannot be vetoed. In which case, vetoing the commit

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-12 Thread sebb
On 12 March 2013 09:23, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Thu, Mar 7, 2013 at 5:16 PM, sebb seb...@gmail.com wrote: BTW it all happens in https://svn.apache.org/repos/asf/gump/metadata/project/commons-proper.xml If I understand that correctly, the Gump build is already

Re: [continuum] BUILD FAILURE: Apache Commons - Commons FileUpload -

2013-03-12 Thread sebb
: Changed: sebb @ Tue 12 Mar 2013 17:08:43 + Comment: Document use of default charset Files changed: /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java ( 1455626

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-15 Thread sebb
On 15 March 2013 17:48, Luc Maisonobe luc.maison...@free.fr wrote: Le 15/03/2013 16:42, Phil Steitz a écrit : On 3/15/13 8:11 AM, Luc Maisonobe wrote: Le 15/03/2013 15:20, Continuum@vmbuild a écrit : Group (shared) Maven 2 Build Definition (Java 1.5) MIME-Version: 1.0 Content-Type:

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 15 March 2013 10:37, simonetrip...@apache.org wrote: Author: simonetripodi Date: Fri Mar 15 10:37:01 2013 New Revision: 1456871 URL: http://svn.apache.org/r1456871 Log: checkstyle: '256' is a magic number. Modified:

Re: svn commit: r1456857 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread sebb
On 15 March 2013 10:11, simonetrip...@apache.org wrote: Author: simonetripodi Date: Fri Mar 15 10:11:09 2013 New Revision: 1456857 URL: http://svn.apache.org/r1456857 Log: checkstyle: '4' is a magic number. Modified:

Re: svn commit: r1456852 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread sebb
See other comments on magic number fixes. I don't think these changes achieve anything apart from keeping Checkstyle happy. IMO the number is still magic (unexplained) when it is turned into a constant, and it seems stilly to have a constant that is only used once. On 15 March 2013 10:02,

Re: svn commit: r1456804 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/MimeUtility.java

2013-03-17 Thread sebb
On 15 March 2013 08:47, simonetrip...@apache.org wrote: Author: simonetripodi Date: Fri Mar 15 08:47:53 2013 New Revision: 1456804 URL: http://svn.apache.org/r1456804 Log: checkstyle: Expected @throws tag Modified:

Re: svn commit: r1457387 - /commons/cms-site/trunk/content/xdoc/releases/prepare.xml

2013-03-17 Thread sebb
On 17 March 2013 06:51, bode...@apache.org wrote: Author: bodewig Date: Sun Mar 17 06:51:22 2013 New Revision: 1457387 URL: http://svn.apache.org/r1457387 Log: xdocs doesn't know a subsubsection Modified: commons/cms-site/trunk/content/xdoc/releases/prepare.xml Modified:

Re: svn commit: r1456871 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-17 Thread sebb
On 17 March 2013 13:18, Simone Tripodi simonetrip...@apache.org wrote: /** + * the decoding table size. + */ +private static final int DECODING_TABLE_SIZE = 256; + The Javadoc does not say why the value 256 is used, so the number is still a magic number ... What should

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math -

2013-03-17 Thread sebb
I temporarily changed the (shared) build definition to use Build Fresh rather than SCM update and triggered a build. I've reverted to change to the build definition. Continuum ought to have an easier way to do this ... On 17 March 2013 13:37, Luc Maisonobe luc.maison...@free.fr wrote: Hi all,

Re: [DBUTILS] [VOTE] Release commons-dbutils 2.0 based on RC1

2013-03-17 Thread sebb
On 17 March 2013 20:02, Bill Speirs bill.spe...@gmail.com wrote: I have worked on some significant enhancements to commons-dbutils, so I would like to release 2.0. *Note: This is backwards incompatible change with the 1.x versions. As such I've changed the maven coordinates and package

Re: svn commit: r1457541 - /commons/proper/dbutils/tags/DBUTILS_2_0_RC1/pom.xml

2013-03-17 Thread sebb
On 17 March 2013 19:43, wspe...@apache.org wrote: Author: wspeirs Date: Sun Mar 17 19:43:06 2013 New Revision: 1457541 URL: http://svn.apache.org/r1457541 Log: - Setting to RC1 Modified: commons/proper/dbutils/tags/DBUTILS_2_0_RC1/pom.xml Tags are supposed to be immutable. If you

Re: svn commit: r1457003 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-18 Thread sebb
On 15 March 2013 16:20, simonetrip...@apache.org wrote: Author: simonetripodi Date: Fri Mar 15 16:20:27 2013 New Revision: 1457003 URL: http://svn.apache.org/r1457003 Log: checkstyle: magic numbers -1 Although these changes don't affect the code, they are wrong. Just because the same

Re: [jira] [Commented] (DIGESTER-171) Add DefaultThrowingErrorHandler to Digester API.

2013-03-18 Thread sebb
On 18 March 2013 08:46, Sebb (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/DIGESTER-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604945#comment-13604945 ] Sebb commented on DIGESTER-171

Re: svn commit: r1456852 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-18 Thread sebb
On 17 March 2013 11:02, sebb seb...@gmail.com wrote: See other comments on magic number fixes. I don't think these changes achieve anything apart from keeping Checkstyle happy. IMO the number is still magic (unexplained) when it is turned into a constant, and it seems stilly to have

Re: svn commit: r1456857 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-18 Thread sebb
On 17 March 2013 13:19, Simone Tripodi simonetrip...@apache.org wrote: /** + * The default number of byte shift for decode. [Actually, it's not a default - the value is fixed, and cannot be changed without breaking the code.] + */ +private static final int OUT_SHIFT = 4; +

Re: [jira] [Commented] (DIGESTER-171) Add DefaultThrowingErrorHandler to Digester API.

2013-03-18 Thread sebb
On 18 March 2013 09:17, Jörg Schaible joerg.schai...@scalaris.com wrote: Simone Tripodi wrote: http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Mar 18, 2013 at 9:51 AM, sebb seb...@gmail.com

Re: svn commit: r1457387 - /commons/cms-site/trunk/content/xdoc/releases/prepare.xml

2013-03-18 Thread sebb
On 18 March 2013 08:56, Stefan Bodewig bode...@apache.org wrote: On 2013-03-17, sebb wrote: a name=Manual Methodh4Manual Method/h4/a Surely names are normally lower-case only and no spaces? I think spaces make the links look odd (and awkward to type). Uses the same syntax as the mvn

[FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread sebb
The new utils.mime classes for MIME decoding are mostly package-protected. However, they have public methods (and ctors) which is a bit misleading. I think it would make sense to reduce the visibility to package protected. Any objections?

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread sebb
On 18 March 2013 10:07, Benedikt Ritter brit...@apache.org wrote: 2013/3/18 sebb seb...@gmail.com The new utils.mime classes for MIME decoding are mostly package-protected. However, they have public methods (and ctors) which is a bit misleading. I think it would make sense to reduce

Re: [jira] [Commented] (DIGESTER-171) Add DefaultThrowingErrorHandler to Digester API.

2013-03-18 Thread sebb
On 18 March 2013 09:58, Jörg Schaible joerg.schai...@scalaris.com wrote: sebb wrote: On 18 March 2013 09:17, Jörg Schaible joerg.schai...@scalaris.com wrote: [snip] Actually, for my own projects I always add @since upcoming or @deprecated As of upcoming ... When I prepare

Re: svn commit: r1457003 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-18 Thread sebb
://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Mar 18, 2013 at 9:34 AM, sebb seb...@gmail.com wrote: On 15 March 2013 16:20, simonetrip...@apache.org wrote: Author: simonetripodi Date: Fri Mar 15 16:20:27

Re: [RESULTS] Was: [VOTE] Release Apache Commons Daemon 1.0.14

2013-03-18 Thread sebb
On 18 March 2013 13:14, Mladen Turk mt...@apache.org wrote: With 3 binding +1 votes (Luc, Gary and Mladen) and no other votes I declare this vote as passed. I'll copy the artefacts and create ANN message after mirrors pick up the release (within 24 hrs). Please also add the files to the SVN

Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java

2013-03-18 Thread sebb
On 18 March 2013 20:31, Simone Tripodi simonetrip...@apache.org wrote: but there are too many discussions about checkstyle rules and perfect releases. We should aim to follow more the open-source credo: release early, release often, imho. I 150% agree with you mate - it's pity here we

Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-18 Thread sebb
On 18 March 2013 14:56, simonetrip...@apache.org wrote: Author: simonetripodi Date: Mon Mar 18 14:56:34 2013 New Revision: 1457788 URL: http://svn.apache.org/r1457788 Log: [FILEUPLOAD-232] started importing MimeUtility test case from

Re: [RESULT] Release Compress 1.5 based on RC1

2013-03-18 Thread sebb
On 14 March 2013 08:25, Stefan Bodewig bode...@apache.org wrote: The vote has passed with +1s by Gary, Sebb, Benedict, Jörg and myself (which I didn't cast expplicitly, sorry) - four of which are binding. I'll promote the staging and copy over the tarballs now. I'll update the site and send

Re: svn commit: r1457003 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java

2013-03-18 Thread sebb
at introducing function-specific constants shortly. http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Mar 18, 2013 at 12:12 PM, sebb seb...@gmail.com wrote: On 18 March 2013 10:45, Simone Tripodi

Re: svn commit: r1457915 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java

2013-03-18 Thread sebb
On 18 March 2013 18:45, ggreg...@apache.org wrote: Author: ggregory Date: Mon Mar 18 18:45:56 2013 New Revision: 1457915 URL: http://svn.apache.org/r1457915 Log: Fix Javadoc. Modified:

Re: svn commit: r1457876 - in /commons/proper/collections/trunk/src: main/java/org/apache/commons/collections/ main/java/org/apache/commons/collections/bidimap/ main/java/org/apache/commons/collection

2013-03-18 Thread sebb
On 18 March 2013 17:16, ggreg...@apache.org wrote: Author: ggregory Date: Mon Mar 18 17:16:42 2013 New Revision: 1457876 URL: http://svn.apache.org/r1457876 Log: Use final for read-only local variables. Modified:

Re: svn commit: r1457876 - in /commons/proper/collections/trunk/src: main/java/org/apache/commons/collections/ main/java/org/apache/commons/collections/bidimap/ main/java/org/apache/commons/collection

2013-03-18 Thread sebb
Thanks! On 18 March 2013 21:43, Gary Gregory garydgreg...@gmail.com wrote: Fixed: Committed revision 1458025. G On Mon, Mar 18, 2013 at 5:37 PM, Gary Gregory garydgreg...@gmail.comwrote: Very odd indeed, I'll need to fix... Gary On Mon, Mar 18, 2013 at 5:32 PM, sebb seb...@gmail.com

Re: svn commit: r1457915 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java

2013-03-18 Thread sebb
Gregory garydgreg...@gmail.com wrote: Hm... I consider this a bug in checkstyle or whatever does the complaining... Gary On Mon, Mar 18, 2013 at 5:30 PM, sebb seb...@gmail.com wrote: On 18 March 2013 18:45, ggreg...@apache.org wrote: Author: ggregory Date: Mon Mar 18 18:45:56 2013 New

Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-19 Thread sebb
It's all getting a bit unnecessary here. My comment was about a new file; I did not see the point of including properties that are not going to be used. I did not veto the commit; it was just an observation. Having said that, if the properties are set it might suggest that they can be used. But

Re: [RESULTS] Was: [VOTE] Release Apache Commons Daemon 1.0.14

2013-03-19 Thread sebb
. On 19 March 2013 05:54, Mladen Turk mt...@apache.org wrote: On 03/18/2013 10:00 PM, sebb wrote: On 18 March 2013 13:14, Mladen Turk mt...@apache.org wrote: With 3 binding +1 votes (Luc, Gary and Mladen) and no other votes I declare this vote as passed. I'll copy the artefacts and create ANN

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
On 19 March 2013 14:44, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, is there anything you want to discuss before I go ahead with a new RC? I am performing some ITs in non-public projects and I planned to cut a new RC in 1-2 days... I think there are still some issues in

[ALL] uploading releases to dist/commons and/or SVN

2013-03-19 Thread sebb
Commons is currently still publishing mon-Maven releases from people.a.o dist/commons. There is an outstanding JIRA issue for this to be changed to svnpubsub: https://issues.apache.org/jira/browse/INFRA-5929 Until this is implemented, it is vital that the dist SVN and people directories are

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
On 19 March 2013 18:27, Simone Tripodi simonetrip...@apache.org wrote: Hi there, is there anything you want to discuss before I go ahead with a new RC? I am performing some ITs in non-public projects and I planned to cut a new RC in 1-2 days... I think there are still some issues in

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
On 19 March 2013 18:32, Gary Gregory garydgreg...@gmail.com wrote: Yes, why not depend on commons-codec? Codec is nearly 4 times the size of file upload. Not an ideal partner. Gary On Mar 19, 2013, at 14:28, Simone Tripodi simonetrip...@apache.org wrote: Hi there, is there anything you

Re: [CSV] Finishing v1.0

2013-03-19 Thread sebb
On 19 March 2013 18:38, Benedikt Ritter brit...@apache.org wrote: How do you feel about postponing some of the improvement tickets until after the initial release? Is this possible with commons release policy or do we have to resolve all open issues? As far as I'm concerned, Improvement

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
in this implementation there's always the need to decode the whole buffer r1458240 | sebb | 2013-03-19 13:18:39 +0100 (Tue, 19 Mar 2013) | 3 lines FILEUPLOAD-233 Base64Decoder doesn't correctly implement RFC 4648 Oops

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
On 19 March 2013 18:48, Gary Gregory garydgreg...@gmail.com wrote: How many gigs of ram do phone that run Java have these days? Some not a lot, see for example: https://issues.apache.org/jira/browse/COMPRESS-221 Gary On Mar 19, 2013, at 14:39, sebb seb...@gmail.com wrote: On 19 March 2013

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
-1 if this results in a huge increase in size of the jar. If shading can extract only the required classes, that might be OK, but it seems like a lot of work when the code already works for valid input. I think the only outstanding problems are the way the decoders handle invalid input. On 19

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
On Tue, Mar 19, 2013 at 2:30 PM, sebb seb...@gmail.com wrote: -1 if this results in a huge increase in size of the jar. If shading can extract only the required classes, that might be OK, but it seems like a lot of work when the code already works for valid input. I think the only outstanding

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
On 19 March 2013 19:16, sebb seb...@gmail.com wrote: On 19 March 2013 18:52, Simone Tripodi simonetrip...@apache.org wrote: 3 commits? :O This one, and: r1458269 http://mail-archives.apache.org/mod_mbox/commons-commits/201303.mbox/%3C20130319132232.8ABD023888EA%40eris.apache.org%3E

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-19 Thread sebb
On 19 March 2013 20:45, Oliver Heger oliver.he...@oliver-heger.de wrote: Am 18.03.2013 11:19, schrieb sebb: On 18 March 2013 10:07, Benedikt Ritter brit...@apache.org wrote: 2013/3/18 sebb seb...@gmail.com The new utils.mime classes for MIME decoding are mostly package-protected. However

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
Turns out the problem was caused by a NUL in the string in decodeWithInnerPad() - diff then treats the file as binary. Replaced with \0 for now. On 19 March 2013 20:02, sebb seb...@gmail.com wrote: On 19 March 2013 19:16, sebb seb...@gmail.com wrote: On 19 March 2013 18:52, Simone Tripodi

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-19 Thread sebb
) but maybe it would be better to only allow 1 or 2 PADs at the end? On 19 March 2013 19:50, sebb seb...@gmail.com wrote: There's one other issue - Commons Codec does not support soft line breaks in quoted printable decoding. As far as I know, those are required. On 19 March 2013 19:46, Matt

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-20 Thread sebb
On 20 March 2013 08:26, Simone Tripodi simonetrip...@apache.org wrote: priceless!!! At present it treats an embedded PAD as the end of input (as per Codec) but maybe it would be better to only allow 1 or 2 PADs at the end? IMHO having such behaviour is acceptable, but if it doesn't cost you

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-20 Thread sebb
On 20 March 2013 14:42, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Mar 20, 2013 at 10:25 AM, Mark Thomas ma...@apache.org wrote: On 20/03/2013 01:09, sebb wrote: I think QPD(ecode) is now OK; it handles lowercase hex and rejects invalid characters. Base64Decode handles valid

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-20 Thread sebb
On 20 March 2013 19:46, Gary Gregory garydgreg...@gmail.com wrote: Hi All: It seems to be that the B64 code needs work for 1.3 no matter what. So I am not sure I agree with Simo because: - We rework B64 for 1.3 as proposed by Sebb. It's not really rework - just tidying up the new code so

Re: [ANNOUNCE] Commons Logging version 1.1.2 released

2013-03-20 Thread sebb
On 20 March 2013 20:05, Thomas Neidhart thomas.neidh...@gmail.com wrote: Hello. The Apache Commons team is pleased to announce the release of commons-logging-1.1.2. Please ensure you upload the release to the SVN dist release area ASAP or it may get lost when svnpubsub is implemented by

Re: [Commons Wiki] Trivial Update of MarlaQuin by MarlaQuin

2013-03-20 Thread sebb
, sebb seb...@gmail.com wrote: On 20 March 2013 13:53, Christian Grobmeier grobme...@gmail.com wrote: Should we move to the AdminGroups with this wiki too? I think yes +1 On Wed, Mar 20, 2013 at 2:37 PM, Apache Wiki wikidi...@apache.org wrote: Dear Wiki user, You have subscribed to a wiki

Re: [fileupload] towards 1.3 release - feedbacks required

2013-03-21 Thread sebb
On 20 March 2013 18:22, sebb seb...@gmail.com wrote: On 20 March 2013 14:42, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Mar 20, 2013 at 10:25 AM, Mark Thomas ma...@apache.org wrote: On 20/03/2013 01:09, sebb wrote: I think QPD(ecode) is now OK; it handles lowercase hex and rejects

Re: svn commit: r1459447 - in /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv: CSVFormat.java CSVParser.java

2013-03-21 Thread sebb
On 21 March 2013 18:47, ggreg...@apache.org wrote: Author: ggregory Date: Thu Mar 21 18:47:40 2013 New Revision: 1459447 URL: http://svn.apache.org/r1459447 Log: Javadoc. Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

Re: svn commit: r1459653 - in /commons/proper/lang/trunk/src: main/java/org/apache/commons/lang3/ main/java/org/apache/commons/lang3/builder/ test/java/org/apache/commons/lang3/

2013-03-22 Thread sebb
On 22 March 2013 07:37, bay...@apache.org wrote: Author: bayard Date: Fri Mar 22 07:37:03 2013 New Revision: 1459653 URL: http://svn.apache.org/r1459653 Log: Fixing urls to point to new oracle pages and not old, sometimes broken, sun urls We should not have to do this, but given that

Re: [ALL] uploading releases to dist/commons and/or SVN

2013-03-22 Thread sebb
On 19 March 2013 17:05, sebb seb...@gmail.com wrote: Commons is currently still publishing mon-Maven releases from people.a.o dist/commons. There is an outstanding JIRA issue for this to be changed to svnpubsub: https://issues.apache.org/jira/browse/INFRA-5929 Until this is implemented

Re: [ALL] uploading releases to dist/commons and/or SVN

2013-03-22 Thread sebb
On 22 March 2013 14:24, Gary Gregory garydgreg...@gmail.com wrote: On Fri, Mar 22, 2013 at 10:20 AM, sebb seb...@gmail.com wrote: On 22 March 2013 13:16, Stefan Bodewig bode...@apache.org wrote: On 2013-03-22, sebb wrote: On 19 March 2013 17:05, sebb seb...@gmail.com wrote: Commons

Re: svn commit: r1459912 - in /commons/proper: bcel/trunk/ beanutils/trunk/ betwixt/trunk/ bsf/trunk/ chain/trunk/ cli/trunk/ codec/trunk/ collections/trunk/ compress/trunk/ configuration/trunk/ csv/t

2013-03-22 Thread sebb
to fix the redirects. Gary On Fri, Mar 22, 2013 at 1:49 PM, s...@apache.org wrote: Author: sebb Date: Fri Mar 22 17:49:27 2013 New Revision: 1459912 URL: http://svn.apache.org/r1459912 Log: Fix up URLs so they point to actual sites; this allows relative URLs to work properly Modified

Re: svn commit: r1459912 - in /commons/proper: bcel/trunk/ beanutils/trunk/ betwixt/trunk/ bsf/trunk/ chain/trunk/ cli/trunk/ codec/trunk/ collections/trunk/ compress/trunk/ configuration/trunk/ csv/t

2013-03-22 Thread sebb
On 23 March 2013 00:19, Jörg Schaible joerg.schai...@gmx.de wrote: sebb wrote: On 22 March 2013 19:58, Gary Gregory garydgreg...@gmail.com wrote: I published the CSV site after your commit, but some links are still incorrect, for example: https://commons.apache.org/proper/releases/index.html

<    1   2   3   4   5   6   7   8   9   10   >