[GitHub] commons-collections pull request #37: COLLECTIONS-673: Fix inspired by the G...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/37 COLLECTIONS-673: Fix inspired by the Guava partition() implementation A fix for the COLLECTIONS-673 bug and a unit test proving the fix for the shown defect. See https

[GitHub] commons-collections pull request #38: COLLECTIONS-681: New unit test for Mul...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/38 COLLECTIONS-681: New unit test for MultiSetUtils A unit test for the MultiSetUtils. The MultiSetUtils had no tests at all, so this will improve the overall coverage. You can merge

[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...

2018-06-12 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/40 COLLECTIONS-685: IterableUtils has public constructor Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private

[GitHub] commons-collections issue #40: COLLECTIONS-685: IterableUtils has public con...

2018-06-12 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 BTW, TravisCI is right, technically this is an API change, but I suggest that all API uses are neither useful nor make sense

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-10 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @kinow thanks for your review! Oops, my maven build had a hickup and all tests were green. There's a design problem in the code you pointed me to. Every Option instance may

[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...

2018-06-10 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-cli/pull/25 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...

2018-06-10 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @kinow thanks for your review! Oops, my maven build had a hickup and all tests were green. There's a design problem in the code you pointed me to. Every Option instance may

[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...

2018-06-10 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-cli/pull/25 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #40: COLLECTIONS-685: IterableUtils has public con...

2018-06-12 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 Closing because of breaking the API. May be interesting for commons-cli 5.0. --- - To unsubscribe, e-mail: dev

[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...

2018-06-12 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...

2018-06-12 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections pull request #41: Fix checkstyle config.

2018-06-12 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/41 Fix checkstyle config. mvn clean checkstyle:checkstyle was failing. Error was: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle

[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...

2018-06-13 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/42 Fix for 5 CheckStyle 3.0.0 plugin warnings. Fixed 5 CheckStyle warnings. There are still 11 warnings left which are false positive (JavadocMethod Unable to get class

[GitHub] commons-collections pull request #43: Javadoc fixes

2018-06-13 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/43 Javadoc fixes Multiple small Javadoc fixes for obvious mistakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons

[GitHub] commons-collections pull request #39: Flat3Map: Some test cases going more i...

2018-06-11 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/39 Flat3Map: Some test cases going more into the details Flat3Map is quite complex in that there are many many ifs. I've added some test cases to validate the correct function of the map

[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...

2018-06-09 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-cli/pull/25 CLI-284: Fix inconsistent behaviour for short and long name == null Fix for https://issues.apache.org/jira/browse/CLI-284 You can merge this pull request into a Git repository by running

[GitHub] commons-collections pull request #44: Moved some JUnit 3 tests to JUnit 4

2018-06-20 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/44 Moved some JUnit 3 tests to JUnit 4 This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. Actually this was the easy part without base class inheritance

[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.

2018-07-21 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/42 Hi @kinow well I'm a little bit confused, neither ``` mvn checkstyle:checkstyle ``` nor ``` mvn clean site ``` bring an error

[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...

2018-07-21 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...

2018-07-21 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h