[GitHub] commons-text pull request #90: Travis: Also build with openjdk-ea
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/90 Travis: Also build with openjdk-ea You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text travis_openjdk_ea Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit 98194c7c013c44703fe8bf76ca42a677b721b8ed Author: Pascal Schumacher Date: 2018-09-30T08:02:14Z Travis: Also build with openjdk-ea --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #86: Travis: Use Java 11 supplied by travis (simpl...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/86 Travis: Use Java 11 supplied by travis (simplifies .travis.yml) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text travis_jdk11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit 54e761af40baa29807f2251b8d904a6e946b08e0 Author: Pascal Schumacher Date: 2018-07-26T19:01:31Z Travis: Use Java 11 supplied by travis (simplifies .travis.yml) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #84: Update StringSubstitutor JavaDoc
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/84 Thanks! ð --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-io pull request #63: Travis: Add oraclejdk10
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-io/pull/63 Travis: Add oraclejdk10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-io travis_java_10 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-io/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit 6aeb140ebd5fb087a881cfadde2b00c2c987ab92 Author: Pascal Schumacher Date: 2018-06-09T07:59:39Z Travis: Add oraclejdk10 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #82: Replace FindBugs with SpotBugs
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/82 Replace FindBugs with SpotBugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text spotbugs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit c2b3730c6701016ec6aba3566ac5c76068a49407 Author: Pascal Schumacher <pascalschumacher@...> Date: 2018-05-10T12:55:28Z Replace FindBugs with SpotBugs --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #81: Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK",...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/81 Currently javadoc fails on java 11 with: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc (default-cli) on project commons-text: An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m [ERROR] /home/travis/build/apache/commons-text/src/main/java/org/apache/commons/text/StrTokenizer.java:61: error: attribute not supported in HTML5: summary [ERROR] * [ERROR] ^ [ERROR] /home/travis/build/apache/commons-text/src/main/java/org/apache/commons/text/StringTokenizer.java:58: error: attribute not supported in HTML5: summary [ERROR] * [ERROR] ^ [ERROR] /home/travis/build/apache/commons-text/src/main/java/org/apache/commons/text/WordUtils.java:65: error: attribute not supported in HTML5: summary [ERROR] * [mERROR] ^ [ERROR] /home/travis/build/apache/commons-text/src/main/java/org/apache/commons/text/WordUtils.java:114: error: attribute not supported in HTML5: summary [ERROR] * [ERROR] ^ [ERROR] /home/travis/build/apache/commons-text/src/main/java/org/apache/commons/text/WordUtils.java:195: error: attribute not supported in HTML5: summary [ERROR] * [ERROR] ^ ``` that should be easy to fix. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #81: Travis: Add Java 10 "Oracle JDK", Java 10 "Op...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/81 Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle ⦠â¦JDK" You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text travis_latests_jdks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit 723ffe488682b84870b29235522a20d38fbabf3a Author: Pascal Schumacher <pascalschumacher@...> Date: 2018-05-04T19:13:55Z Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle JDK" --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #80: travis: add Java 10
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/80 Not yet available on travis: `Sorry, but JDK 'oraclejdk10' is not known.` --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #80: travis: add Java 10
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-text/pull/80 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #80: travis: add Java 10
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/80 travis: add Java 10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text travis_jdk10 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit d599cc75157985fc6dbf33f35b795369a0a5d7d4 Author: Pascal Schumacher <pascalschumacher@...> Date: 2018-04-22T07:36:41Z travis: add Java 10 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 Great! @kinow Thanks in-depth check! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 JUnit 5 should work with any Eclipse Version released during the last year (as long as you delete existing run configurations for the project). @garydgregory Can you give running this a try? I would like to merge it. Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/79 The only problem I encountered was that I had to delete the existing JUnit run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not seem to be able to update a run configuration from JUnit 4 to JUnit 5). --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #79: Upgrade to JUnit 5.1
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/79 Upgrade to JUnit 5.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text junit_5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit f37a81c7bf965d593722d55ba1108c0c19b0fdb4 Author: Pascal Schumacher <pascalschumacher@...> Date: 2018-04-04T20:33:48Z Upgrade to JUnit 5.1 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #78: Require Java 8
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/78 Require Java 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text java_8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit a383506a21c82ae85fee109f7013686f2bf6ce64 Author: Pascal Schumacher <pascalschumacher@...> Date: 2018-04-04T16:29:17Z Require Java 8 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: TEXT-80: Fixed confusing StrLookup API
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/44 I'm closing this as `StrLookup` will deprecated and replaced with `StringLookup` in the next release. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #73: TEXT-106: Exception thrown in ExtendedMessageFormat ...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/73 +1 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #76: Align sample in JavaDoc
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/76 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #73: TEXT-106: Exception thrown in ExtendedMessageFormat ...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/73 patch has some check-style violations, see: https://travis-ci.org/apache/commons-text/jobs/294087452 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #75: Minor refactorings
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/75 Thanks! ð It would be nice if you could fix the check-style violations, see: https://travis-ci.org/apache/commons-text/jobs/297158450 Run `mvn checkstyle:check` (or just `mvn`) to replicated it locally. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #74: Use non-deprecated method.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/74 Thanks! ð --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #69: Fix typos, minor clean ups
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/69 No problem. I just wanted to make sure not to do it myself in cause you would have liked to submit a pull requests. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #70: partial automated migration to assertj
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 @chtompki What do you think? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-codec pull request #10: pom.xml: add java 9 profile
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-codec/pull/10 pom.xml: add java 9 profile .travis.yml: also build on java 9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-codec travis_java_9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-codec/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 10872fc646628f03b6731ceb9a4f38b89c2bf67c Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-22T08:10:27Z pom.xml: add java 9 profile .travis.yml: also build on java 9 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #70: partial automated migration to assertj
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 Sure. AssertJ 2.x for java 7 and 3.x for java 8 have been developed in parallel for a few years (and currently still are). Java 7 compatible changes are done in 2.x and then merged into 3.x, so 3.x is essentially 2.x plus support for lambdas, predicates and java 8 classes. Migrating for AssertJ 2.x to 3.x is easy, I did it for multiple projects without problems. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #69: Fix typos, minor clean ups
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/69 typo issue fixed in: https://github.com/apache/commons-text/commit/804e4599bd63e4bb14c905613711eac8829e54fb Thanks again for reporting! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #69: Fix typos, minor clean ups
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/69 created https://issues.apache.org/jira/browse/TEXT-105 for the typo in `LongestCommonSubsequence#logestCommonSubsequence`. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #71: Apply (relaxed) checkstyle rules to test and fix exi...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/71 Now complete. If I knew before how much work this would be, I would not have started. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #71: Apply (relaxed) checkstyle rules to test and ...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/71 Apply (relaxed) checkstyle rules to test and fix existing violations ⦠â¦(incomplete) Similar to lang. Not yet finished, there are still around 70 violations left to fix. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text checkstyle_for_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 72ad2bc749f3d1a8ae978239b61f68137bf27c8e Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-15T17:57:21Z apply (relaxed) checkstyle rules to test and fix existing violations (incomplete) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #70: partial automated migration to assertj
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 >Cool! Have missed the discussion about introducing this for Text. I like it. These was no discussion yet. I just thought I do a quick prototype with a component after the general discussion of assertj. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #70: partial automated migration to assertj
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/70 partial automated migration to assertj Migrated using a modified version of https://github.com/joel-costigliola/assertj-core/blob/master/src/main/scripts/convert-junit-assertions-to-assertj.sh I reverted changes where the automated migration did not work to minimize effort for this prototype. The script use only the most basic assertj assertions, so the full power is not evident. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text partial_automated_migration_to_assertj Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 9fd5bdd5973e64c1fbdce230f21d038c5eee0502 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-15T10:11:39Z partial automated migration to assertj --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #32: Update testcase
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/32 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 I'm sure we will, but as far as I know there is no concrete plan when that will happen. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 A possible solution for this problem would be to use reflection instead. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Thanks for the pull request. DBUtils currently still requires only java 6, but you are using classes which were introduced in java 8. Therefore the builds on java 6/7 fail because these classes can not be found. See e.g.: https://travis-ci.org/apache/commons-dbutils/jobs/287860481 for details. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #29: Added unit tests to increase code coverage
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 Sorry about that. :( But the correct parameter order part of you pull request is still relevant. It would be nice if you could create a new rebased pull request for that. Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #29: Added unit tests to increase code coverage
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 Thanks! Looking forward to the pull request! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #69: Fix typos, minor clean ups
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/69 Thanks! ð Concerning the typo in `org.apache.commons.text.similarity.LongestCommonSubsequence#logestCommonSubsequence`. If you like, you can submit a new pull request which marks this method as deprecated adds a new method with the correct spelling instead. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #29: Added unit tests to increase code coverage
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 `assertEquals(MapUtils.getDouble(in,"key", 0.0), 2.0, 0);` etc. should be `assertEquals(2.0, MapUtils.getDouble(in,"key", 0.0), 0);` because it is `assertEquals(double expected, double actual, double delta)` Also two test fail for locales that do no use `.` as the decimal separator (e.g. germany) ``` Failed tests: MapUtilsTest.testgetDoubleValue:956 expected:<20.0> but was:<2.0> MapUtilsTest.testgetFloatValue:974 expected:<20.0> but was:<2.0> ``` --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #30: COLLECTIONS-662 : Override Jacoco version for...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/30 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #29: Added unit tests to increase code coverage
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/68 Thanks! Imho this pull request is good to merge. Only thing that is missing are `@since 1.2` tags in the javadoc of the new methods. @chtompki What do you think? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-fileupload/pull/10 @maxxedev Thanks! The jdk6/7 build failures are unrelated. https://github.com/apache/commons-fileupload/pull/11 contains the fix for these failures. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #11: travis: fix buffer overflow in Java_jav...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-fileupload/pull/11 travis: fix buffer overflow in Java_java_net_Inet4AddressImpl_getLoca⦠â¦lHostName of OpenJDK6 and OpenJDK7 when using precise distribution To fix this use the current (trusty) distribution and manually install openjdk-6-jdk and a java 6 compatible maven version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-fileupload fix_travis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 6fdb82e5040e058f8a67929579bf88f60fa41986 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-08T09:34:18Z travis: fix buffer overflow in Java_java_net_Inet4AddressImpl_getLocalHostName of OpenJDK6 and OpenJDK7 when using precise distribution To fix this use the current (trusty) distribution and manually install openjdk-6-jdk and a java 6 compatible maven version. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/68 Thanks for the pull request! It would be nice if you could fix the checkstyle violations. See https://travis-ci.org/apache/commons-text/jobs/284821493 for details or run "mvn checkstyle:check" locally. Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 Thanks! I solved the findbugs version problem with: https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 Thanks! I solved the findbugs version problem with: https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #20: Findbug checkstyle support
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-cli/pull/20 Findbug checkstyle support You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-cli findbug_checkstyle_support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-cli/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit fa6e8c821d3d0bc3ec6044a7fbffbbc0e46f1e31 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-08-01T18:45:47Z added findbug and checkstyle support while building commit f0259961bd5f3c3f5c78d6f4a04083bf71ca8421 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-07T08:55:36Z pom.xml: use commons.findbugs.version as maven-findbugs-plugin version, because it is adjusted according to the java version in use --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-fileupload/pull/10 @maxxedev Thanks for the pull request! It would be nice if you could close it, now that @jochenw has merged it. Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #66: Adding validation for pair
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/66 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #27: travis: add java 9 to build
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/27 test failure on java 9: `ListIteratorWrapperTest.testRemove:116 » ServiceConfiguration sun.util.locale` --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #27: travis: add java 9 to build
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-collections/pull/27 travis: add java 9 to build pom.xml: add java 9 profile to make build pass You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-collections travis_add_java_9 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 61ed424d6841f4a7feae1f06d4e0b3970889227d Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-02T09:46:34Z travis: add java 9 to build pom.xml: add java 9 profile to make build pass --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/67
The reason for the coveralls failure:
```
Failed to execute goal
[32morg.eluder.coveralls:coveralls-maven-plugin:4.3.0:report[m
[1m(default-cli)[m on project [36mcommons-text[m: [1;31mProcessing of
input or output data failed[m: Unable to parse timestamp "2017-10-02
07:50:36+": For input string: "2017-10-02 07:50:36+"
```
The cause: `{0,date,-MM-dd
HH:mm:ssZ}` which was required because
coveralls-plugin-versions before 4.2 did not support the maven default of
`EpochMillis`. The commons-parent coveralls configuration sets
`${commons.coveralls.timestampFormat}` and
`commons.coveralls.timestampFormat` defaults to `EpochMillis`.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #67: travis: remove travis profile from pom and use travi...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/67 Seems to break coverall somehow. (By now there should have been an comment from the coveralls bot concerning code coverage,) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #67: travis: remove travis profile from pom and us...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/67 travis: remove travis profile from pom and use travis-jacoco profile ⦠â¦commons-parent You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text travis_profile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 15b200c60a4f17a6e6616e20265e2a8eee062607 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-10-01T14:29:26Z travis: remove travis profile from pom and use travis-jacoco profile commons-parent --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/64 Thanks for the pull request. Imho we should make it absolutely clear that users should not use this method. Therefore I'm against making the formulation "softer". --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #65: Sort pom file
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/65 Thanks for the suggestion, but I'm against merging this, as this makes the order different from other commons projects. Replacing `/>` with `>` makes no sense imho (why make xml more verbose?). --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 As I said before this can not be merged as it is, because it fails on java 6. The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do not work on java 8. A possible solution would be to create a java 6 profile which detects java 6 and with uses the java 6 compatible maven-findbugs-plugin version 2.x. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 As I said before this can not be merged as it is, because it fails on java 6. The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do not work on java 8. A possible solution would be to create a java 6 profile which detects java 6 and with uses the java 6 compatible maven-findbugs-plugin version 2.x. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #63: small-code-quality-improvements
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/63 Merged in : https://github.com/apache/commons-text/commit/5598109efb2365384b9a9110323ed9a7004cc905 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140526804
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit tools that require a
JavaBean
* instance to operate.
*/
+@SuppressWarnings("squid:S1118")
--- End diff --
-1 to this
Eclipse was not displaying any warning before, but with this change it
displays this warning: `Unsupported @SuppressWarnings("squid:S1118")`
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #18: .travis.yml: install open-jdk6, as it was remo...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-cli/pull/18 .travis.yml: install open-jdk6, as it was removed from the default image (see https://github.com/travis-ci/travis-ci/issues/8199) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-cli fix_jdk_6_build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-cli/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit 9bdb3dbe184a8a481bf6e8b26167e462c29f4ad8 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-09-21T19:06:48Z .travis.yml: install open-jdk6, as it was removed from the default image (see https://github.com/travis-ci/travis-ci/issues/8199) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23494230 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java on line 80: Thanks! Build on travis is now green again. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23482473 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java on line 80: `StandardCharset` is java 7+ and I think commons-fileupload is still java 6, correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/61 Also note that currently this script only compiles and runs test. Rat, clirr, findbugs and javadoc are not executed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 The findbugs version used is not java 6 compatible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 The findbugs version used is not java 6 compatible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/61 +1 for moving this discussion to the mailing list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/61 In my opinion this is overkill. I don't think commons-text needs to be tested against the eclipse java compiler and early access version of java 8 and 9. The script looks difficult to debug and maintain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #60: additional-tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/60 Thanks! :+1: By the way: Feel free to raise a jira issue for anything you think that maybe be a bug (e.g. NullPointerExceptions). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #60: additional-tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130633380
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI() {
assertEquals("", unescapeXSI("\\"));
}
+@Test
+public void testUnescapeEcmaScript() {
+assertNull("Should be null.",
StringEscapeUtils.unescapeEcmaScript(null));
+assertEquals("8lvc1u+6B#-I",
StringEscapeUtils.unescapeEcmaScript("8lvc1u+6B#-I"));
+assertEquals("",
+StringEscapeUtils.unescapeEcmaScript("")
+);
+assertEquals(">",
+StringEscapeUtils.unescapeEcmaScript(">")
+);
+}
+
+@Test
+public void testEscapeHtmlFour() {
+assertNull("Should be null.", StringEscapeUtils.escapeHtml3(null));
+assertEquals("a", StringEscapeUtils.escapeHtml3("a"));
+assertEquals("ba", StringEscapeUtils.escapeHtml3("a"));
+}
+
+@Test
+public void testUnescapeJson() {
+
+String jsonString =
"{\"age\":100,\"name\":\"kyong.com\n\",\"messages\":[\"msg 1\",\"msg 2\",\"msg
3\"]}";
+
+assertEquals("", StringEscapeUtils.unescapeJson(""));
+assertEquals(" ", StringEscapeUtils.unescapeJson(" "));
+assertEquals("a:b", StringEscapeUtils.unescapeJson("a:b"));
+assertEquals(jsonString,
StringEscapeUtils.unescapeJson(jsonString));
+}
+
+@Ignore("Bug found.")
+@Test
+public void testUnescapeJsonFoundBug() {
--- End diff --
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #60: additional-tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130549181
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI() {
assertEquals("", unescapeXSI("\\"));
}
+@Test
+public void testUnescapeEcmaScript() {
+assertNull("Should be null.",
StringEscapeUtils.unescapeEcmaScript(null));
+assertEquals("8lvc1u+6B#-I",
StringEscapeUtils.unescapeEcmaScript("8lvc1u+6B#-I"));
+assertEquals("",
+StringEscapeUtils.unescapeEcmaScript("")
+);
+assertEquals(">",
+StringEscapeUtils.unescapeEcmaScript(">")
+);
+}
+
+@Test
+public void testEscapeHtmlFour() {
+assertNull("Should be null.", StringEscapeUtils.escapeHtml3(null));
+assertEquals("a", StringEscapeUtils.escapeHtml3("a"));
+assertEquals("ba", StringEscapeUtils.escapeHtml3("a"));
+}
+
+@Test
+public void testUnescapeJson() {
+
+String jsonString =
"{\"age\":100,\"name\":\"kyong.com\n\",\"messages\":[\"msg 1\",\"msg 2\",\"msg
3\"]}";
+
+assertEquals("", StringEscapeUtils.unescapeJson(""));
+assertEquals(" ", StringEscapeUtils.unescapeJson(" "));
+assertEquals("a:b", StringEscapeUtils.unescapeJson("a:b"));
+assertEquals(jsonString,
StringEscapeUtils.unescapeJson(jsonString));
+}
+
+@Ignore("Bug found.")
+@Test
+public void testUnescapeJsonFoundBug() {
--- End diff --
Thanks for the pull request!
It would be nice if you could raise an isssue at
https://issues.apache.org/jira/projects/TEXT for this.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #58: Add tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/58 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/59 Looks like a very complex setup. But the actual travis report looks good: https://travis-ci.org/jacoco/jacoco/builds/255021437?utm_source=github_status_medium=notification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #59: add oraclejdk9 to travis configuration
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/59 add oraclejdk9 to travis configuration add maven java9 profile: - use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0 do not work on java 9 - skip maven-coveralls-plugin, because version 4.3.0 does not work on java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text add_jdk9_to_travis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit be0a5aa0af58d184948cf044532f49f04a8f03f4 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-07-28T17:43:44Z add oraclejdk9 to travis configuration add maven java9 profile: - use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0 do not work on java 9 - skip maven-coveralls-plugin, because version 4.3.0 does not work on java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #58: Add tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/58#discussion_r129910754
--- Diff:
src/test/java/org/apache/commons/text/similarity/CosineSimilarityTest.java ---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.text.similarity;
+
+import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link CosineSimilarity}.
+ *
+ * @date 2017-07-26
+ * @see CosineSimilarity
+ *
+ **/
+public class CosineSimilarityTest{
+
+ @Test
+ public void testCosineSimilarityWithNonEmptyMap() {
+ CosineSimilarity cosineSimilarity = new CosineSimilarity();
+ Map<String, Integer> hashMap = new HashMap();
+ Integer integer = new Integer((-397));
+ hashMap.put("3J/$3.L", integer);
+ Map<CharSequence, Integer> hashMapTwo = new HashMap(hashMap);
+ Map<CharSequence, Integer> hashMapThree = new HashMap();
+
+ assertEquals(0.0, (double)
cosineSimilarity.cosineSimilarity(hashMapTwo, hashMapThree), 0.01);
+ }
+
+ @Test
--- End diff --
I think these tests should just use
`@Test(expected=IllegalArgumentException.class)` instead fo the try-catch-fail
construct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/57 @arunvinudss While I agree that `isDelimiter` should have been private, it is public and was released with commons-text `1.1`. Due to the strict binary compatibilities promise of commons it can not be removed before `2.0`. For now the best we can do is mark it as deprecated and explain that it will be removed in version `2.0`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128594766
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
--- End diff --
The name of this test method (and some of the ones below) seems misleading,
because the name suggests that the three argument constructor is tested, but
the tests calls the two argument constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595088
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
+Map<String, FormatFactory> map = new HashMap<String,
FormatFactory>();
--- End diff --
As commons-text requires Java 7 this can be reduced to `Map<String,
FormatFactory> map = new HashMap<>();`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #56: add-some-Unit Tests
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595517
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(),
new UpperCaseFormat()});
}
+@Test
+public void
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
{
+Map<String, FormatFactory> map = new HashMap<String,
FormatFactory>();
+ExtendedMessageFormat extendedMessageFormat = null;
--- End diff --
No need to create a variable if it is not used. This will produce unused
variable warnings in IDEs etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 @ameyjadiye Try adding the same suppression as commons-lang: ``` ``` That should reduce the errors. Maybe their are other checks which can be reasonably suppressed for tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/56 @jbduncan Check-style for commons-text does is currently not applied to tests. I think we should look into enabling it. @TheRealHaui Please fix the things @jbduncan suggested. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks. I was not as easy as I expected (I had to merge). I followed these steps: `git rebase -i head~5` Edit the rebase-todo-to to contain: ``` drop 06e8b3d test: Improved testcase coverage for StrBuilder drop 27e110b revert to master pick d23bd1d Test: Improved testcase coverage for StrBuilder squash 242ad5e Style fixes for StrBuilderTest pick 31a5cd1 Fixed formatting for StrBuilder ``` Edit merge conflict. `git rebase --continue` Editmerge conflicts (nothing to do, just confirm merge was good). `git rebase --continue` `push -f` Please remove my access to the repository. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks for splitting the changes. :+1: But please also address the second part: >Please stick to the existing code style for the new tests (no new line at the beginning and at the end of a test method; single new line between test methods). Furthermore it would be very nice if you would clean up the history of the pull request by using `git rebase` once it is ready to merge. After you commit the style fixes for the new tests you should be able to clean-up the history like this: Use `git rebase -i head~5`. Choose to drop the first two commits (06e8b3dd06ee2f86490b2e94359d29d2fe04786c and 27e110b37f8f1e1cceee18ab614424f8a807a747). Squash d23bd1db8c0f21f62006b8cf0f41eb0588997a1e and the last commit. Afterwards use `push -f` to update the pull request. After this there will be only two commits (one with the style changes and one with the new tests) and the commit history of commons-text will be pristine. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #53: revert "Added IBM Jdk8 build support to travi...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/53 revert "Added IBM Jdk8 build support to travis-ci configuration" The build fails, but this failure is not reflected in the travis build status. Code-coverage is broken. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text revert_ibm_jdk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit e100a60844841400d9191f5788536c68a3427900 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-06-18T06:48:41Z revert "Added IBM Jdk8 build support to travis-ci configuration" The build fails, but this failure is not reflected in the travis build status. Code-coverage is broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks! Please separate the formatting fixes and the test additions into different commits. Please stick to the existing code style for the new tests (no new line at the beginning and at the end of a test method; single new line between test methods). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/50#discussion_r122294037
--- Diff: src/main/java/org/apache/commons/text/CharacterPredicates.java ---
@@ -48,5 +48,73 @@ public boolean test(int codePoint) {
public boolean test(int codePoint) {
return Character.isDigit(codePoint);
}
-}
+},
+
+/**
+ * Tests if the code points represents a number between 0 and 9.
+ *
+ * @since 1.2
+ */
+ARABIC_NUMERALS {
+@Override
+public boolean test(int codePoint) {
+return codePoint >= ZERO_CODEPOINT && codePoint <=
NINE_CODEPOINT;
+}
+},
+
+/**
+ * Tests if the code points represents a letter between a and z.
+ *
+ * @since 1.2
+ */
+ASCII_LOWERCASE_LETTERS {
+@Override
+public boolean test(int codePoint) {
+return codePoint >= LOWERCASE_A_CODEPOINT && codePoint <=
LOWERCASE_Z_CODEPOINT;
+}
+},
+
+/**
+ * Tests if the code points represents a letter between A and Z.
+ *
+ * @since 1.2
+ */
+ASCII_UPPERCASE_LETTERS {
+@Override
+public boolean test(int codePoint) {
+return codePoint >= UPPERCASE_A_CODEPOINT && codePoint <=
UPPERCASE_Z_CODEPOINT;
+}
+},
+
+/**
+ * Tests if the code points represents a letter between a and Z.
+ *
+ * @since 1.2
+ */
+ASCII_LETTERS {
+@Override
+public boolean test(int codePoint) {
+return ASCII_LOWERCASE_LETTERS.test(codePoint) ||
ASCII_UPPERCASE_LETTERS.test(codePoint);
+}
+},
+
+/**
+ * Tests if the code points represents a letter between a and Z or a
number between 0 and 9.
+ *
+ * @since 1.2
+ */
+ASCII_ALPHA_NUMERALS {
+@Override
+public boolean test(int codePoint) {
+return ASCII_LOWERCASE_LETTERS.test(codePoint) ||
ASCII_UPPERCASE_LETTERS.test(codePoint)
+|| ARABIC_NUMERALS.test(codePoint);
+}
+};
+
+private static final int NINE_CODEPOINT = 57;
--- End diff --
Sure. I have updated the pull request. Thanks for the suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/50#discussion_r122292528
--- Diff:
src/test/java/org/apache/commons/text/CharacterPredicatesTest.java ---
@@ -44,4 +44,77 @@ public void testDigits() {
assertFalse(CharacterPredicates.DIGITS.test('.'));
assertFalse(CharacterPredicates.DIGITS.test('L'));
}
+
+@Test
+public void testArabicNumerals() {
--- End diff --
I personally do not like junit parametrized tests because every test method
has to be in its own class and you have to a lot of boiler plate. For
parametrized test I use https://github.com/TNG/junit-dataprovider
Theories can be nice for testing methods with multiple parameters, although
in my opinion well chosen parameter combinations are often enough. I think
theories are a bit lacking compared to "real" property based testing like
quick-check (no test data generation, no failure shrinking). For java
https://github.com/pholser/junit-quickcheck is the best option I'm aware of,
but it has been requiring java 8 for years.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 The build failure I quoted occurs after the findbugs exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 I guess this failure is also the reason that the coveralls integration is broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 This does not seem to really work. It looks like ibm jdk build is run after each (oracle8, openjdk(7|8)) build and actually fails, but the build is still marked successful, e.g.: ``` [INFO] BUILD FAILURE [INFO] [INFO] Total time: 2.039s [INFO] Finished at: Wed Jun 14 20:58:38 UTC 2017 [INFO] Final Memory: 10M/143M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:3.0.0:clean (default-clean) on project commons-text: Failed to clean project: Failed to delete /home/travis/build/apache/commons-text/target/surefire-reports/org.apache.commons.text.similarity.LevenshteinDetailedDistanceTest.txt -> [Help 1] ``` https://travis-ci.org/apache/commons-text/jobs/243003865 (see raw build log) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #51: TEXT-91: RandomStringGenerator should be able...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/51 TEXT-91: RandomStringGenerator should be able to generate a String wi⦠â¦th a random length You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text RandomStringGenerator_String_with_random_length Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 4659ea28ee66d0be4a21eeb6da927dbb65eb4d36 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-06-14T20:34:09Z TEXT-91: RandomStringGenerator should be able to generate a String with a random length --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/50 TEXT-90: Add CharacterPredicates for ASCII letters (uppercase/lowerca⦠â¦se) and Arabic numerals You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-text more_character_predicates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit fd7997ec780dd17f635086429352cd478d967f11 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-06-14T20:04:55Z TEXT-90: Add CharacterPredicates for ASCII letters (uppercase/lowercase) and Arabic numerals --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #41: TEXT-67: use [lang]'s Range to replace if/else logic
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/41 Let's merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-io pull request #34: IO-367: Add convenience methods for copyToDirec...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-io/pull/34 IO-367: Add convenience methods for copyToDirectory (closes #18) patch supplied by James Sawle You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-io copyToDirectory Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-io/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 861a4e87e19ec717bef84ec5e37b0b745a611300 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2017-04-23T19:02:29Z IO-367: Add convenience methods for copyToDirectory (closes #18) patch supplied by James Sawle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-compress/commit/7c93eb18bad8612fe7cd4e6d27bd413b1fafc978#commitcomment-19849282 In README.md: In README.md on line 104: done: https://github.com/apache/commons-compress/commit/14441dbaa14a4b1e98b8c2df5b7ae5c120290d97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-compress pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-compress/commit/7c93eb18bad8612fe7cd4e6d27bd413b1fafc978#commitcomment-19842390 In README.md: In README.md on line 104: Looks like some replacing did not work and now the link is dead. :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-io pull request #25: IO-514: Remove org.apache.commons.io.Java7Suppo...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-io/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-io pull request #26: README.md: update maven coordinates to version ...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-io/pull/26 README.md: update maven coordinates to version 2.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-io readme_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-io/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 287c6c2c40faedde7515d4392522076bf17dd981 Author: Pascal Schumacher <pascalschumac...@gmx.net> Date: 2016-11-05T21:49:23Z README.md: update maven coordinates to version 2.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
