Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/56
In git master. Please verify and close.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/56
Hi @ttulka ,
Do you have a unit test that demonstrates the pronlem?
Gary
---
-
To unsubscribe
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/17
I think this PR can be closed.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/57
You did not have to close the PR, I was hoping you would provide a more
complete solution
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/57
Hi @drajakumar ,
I'm not sure this patch makes sense. Take a look at
```org.apache.commons.collections4.list.Collections701Test```: For
```ArrayList``` and ```HashSet
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/35
+1 to merge. I'd prefer to see a 1.0-alpha1 or 1.0-beta1 released next
instead of 1.0 but I'm not RM'ing this one
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/35
In general I do not think a library should log at INFO, only DEBUG or TRACE.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287763
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
---
@@ -27,7 +27,7 @@
import
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287591
--- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java ---
@@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287298
--- Diff:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffField.java ---
@@ -355,9 +360,14 @@ private String getValueDescription
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287176
--- Diff:
src/main/java/org/apache/commons/imaging/formats/psd/PsdImageContents.java ---
@@ -40,9 +45,14 @@ public PsdImageContents(final
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287038
--- Diff:
src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java ---
@@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210286764
--- Diff:
src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java
---
@@ -42,9 +47,9 @@ public PngChunkText(final int
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210286324
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/86#discussion_r205575417
--- Diff: .travis.yml ---
@@ -14,25 +14,13 @@
# limitations under the License.
language: java
-sudo: false
-# Get
Github user garydgregory commented on the issue:
https://github.com/apache/commons-collections/pull/35
I'm not sure anyone wants to volunteer to release from such an old branch.
I recommend you update to 4.x
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/10
I am using:
```
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/10
When I apply this match to master, I get:
[INFO] Running org.apache.commons.pool2.impl.TestGenericObjectPool
[ERROR] Tests run: 82, Failures: 0, Errors: 3, Skipped: 0, Time
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/9
Hi @mcgitty,
Thank you for the PR.
Patch applied with slight modifications
Gary
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/7
If by "moving" you mean deleting a method from an interface, that would
break binary compatibility, which we cannot do outside of a major release
(where we would change the pa
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/7
Right, we cannot add method to existing interfaces outside of a major
release.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/5
Thank you for your patch. In git master now.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
I am concerned about:
- I create a class or jar with a subclass of `DiskFileItem` called
`FooDiskFileItem` that throws an `Exception` against FileUpload 1.3.3.
- We release
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/15
Committed to git master. Please verify and close.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
True, but what if I have a subclass of DiskFileItem that throws an
Exception?
Note: We are OK with breaking source compatibility but not BC outside of a
major release
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
If you have more, please update this PR based on what is in git master.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/14
Thank you for your report. I used Eclipse'd clean up feature to implement
this change instead of applying this patch. Please verify and close
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/13
I think that would break binary compatibility. So it would have to be for
2.0.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/79
Comitted! :-) Works for me as well in Eclipse 4.7.3.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/4
I should be able to take a look tomorrow or the next day.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/79
Hi Pascal! Thank you for the PR. My only hesitation with JUnit 5 is that it
does not work in Eclipse yet, for me at least
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/4
Hello @cdeneux !
Thank you for your PR.
Would you mind updating this PR with a unit test? It would be best if the
test failed without the changes to the main file
Github user garydgregory commented on the issue:
https://github.com/apache/commons-dbutils/pull/4
We could release what we have now and the at least update to Java 7 if not
8.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on the issue:
https://github.com/apache/commons-dbutils/pull/3
I created https://issues.apache.org/jira/browse/DBUTILS-135 to track this
fix. Committed to git master
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-dbutils/pull/3#discussion_r143822953
--- Diff: src/main/java/org/apache/commons/dbutils/BeanProcessor.java ---
@@ -65,19 +65,21 @@
*/
private static final Map
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-dbutils/pull/3#discussion_r143814271
--- Diff: src/main/java/org/apache/commons/dbutils/BeanProcessor.java ---
@@ -65,19 +65,21 @@
*/
private static final Map
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/28
You want a fresh PR, yes, but you still need to base it off of git master,
not just continue the previous patch please.
---
If your project is set up for it, you can reply
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Yes, you want a fresh PR.
Gary
On Mon, Jul 17, 2017 at 9:59 AM, TheRealHaui <notificati...@github.com>
wrote:
> As the pull request is already clo
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Did you try a build like "mvn clean verify"?
This PR format seems bogus as it contains folders like
"org.apache.commons.imaging.common.itu_t4" instead
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Under what name? Feel free to email me at ggreg...@apache.org if you do not
want to state your name here.
---
If your project is set up for it, you can reply to this email and have
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Please see https://www.apache.org/licenses/#submitting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
@TheRealHaui:
Thank you for your PR.
This is a lot of code, I think it would be appropriate for you to file a
ICLA with us. Please see https://www.apache.org/licenses
Github user garydgregory commented on the issue:
https://github.com/apache/commons-imaging/pull/27
Where some of these generated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/44
BTW, this will break source compatibility for certain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi All,
Why is it confusing? Why is the patch better? You get the idea, you have to
make a point that what you propose is better beyond changing source.
Gary
---
If your
Github user garydgregory commented on the issue:
https://github.com/apache/commons-compress/pull/26
Hi,
Should any of this work also apply to commons-parent?
Gary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-compress/commit/522b6c67c28f2bcb0d9b09fd47b10449cb1c578c#commitcomment-21978708
In pom.xml:
In pom.xml on line 74:
I'm pretty sure you do not need to state the scope to `compile`. We do
Github user garydgregory commented on the issue:
https://github.com/apache/commons-compress/pull/23
Thank you for your patch. The only thing missing at first glance is a patch
to `org.apache.commons.compress.compressors.CompressorStreamFactory`.
---
If your project is set up
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/20#discussion_r113141961
--- Diff:
src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java
---
@@ -56,7 +56,7 @@ public
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/5
Don't you still get an NPE if you call DiskFileItem.isInMemory()?
You should really have one @Test method for each DiskFileItem method you
modified to show where NPEs have
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/5
You might have to catch up your fork to the HEAD of the master branch. See
https://garygregory.wordpress.com/2016/11/10/how-to-catch-up-my-git-fork-to-master/
---
If your project
Github user garydgregory commented on the issue:
https://github.com/apache/commons-fileupload/pull/5
Hi @OleHornischer,
1) Can you update your patch based on our Git master.
2) Can you provide a unit test that shows the bug in action before if your
patch is not applied
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197425393
Hi,
Thank you for the patch.
Do you have a unit test that show the problem and it being fixed by the
patch?
Gary
---
If your
Github user garydgregory commented on the pull request:
https://github.com/apache/commons-compress/pull/11#issuecomment-197518791
Yes, one of:
- Use Mockito or Powermock to assert that the end() method has been called
(best)
- add an isClosed method somewhere that sets
(posting from nabble as I've lost the thread in my inbox)
I want to revive using Java 6 this for trunk. Java 5 is dead, no only is
forcing projects to update to the trunk stream from VFS 2.0.
In addition to the list below:
- Make VFS more attractive for new user/developers, new committers in
55 matches
Mail list logo
