[GitHub] commons-collections issue #42: Fix for 5 CheckStyle 3.0.0 plugin warnings.
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/42 Hi @kinow well I'm a little bit confused, neither ``` mvn checkstyle:checkstyle ``` nor ``` mvn clean site ``` bring an error. I'm closing this. Thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #44: Moved some JUnit 3 tests to JUnit 4
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/44 Moved some JUnit 3 tests to JUnit 4 This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. Actually this was the easy part without base class inheritance. Verified that the tests in master branch and this PR are the same: `[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0 ` You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections JUnit4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit 4702e747323690ecba6bb3a80940b4a2c1aebce1 Author: Stephan Fuhrmann Date: 2018-06-20T18:42:02Z Moved some JUnit 3 tests to JUnit 4 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #43: Javadoc fixes
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/43 Javadoc fixes Multiple small Javadoc fixes for obvious mistakes You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections JavadocFixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 5e44c8e3d79ec36235530a310d9181fd7f0ee4b2 Author: Stephan Fuhrmann Date: 2018-06-13T19:17:14Z Javadoc fixes --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #42: Fix for 5 CheckStyle 3.0.0 plugin warn...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/42 Fix for 5 CheckStyle 3.0.0 plugin warnings. Fixed 5 CheckStyle warnings. There are still 11 warnings left which are false positive (JavadocMethod Unable to get class information for @throws tag 'FunctorException'.). See also: https://github.com/checkstyle/checkstyle/issues/5088 Maven Checkstyle Plugin 3.0.0 uses CheckStyle 6.18. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections CheckStyleFixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 2a9a1105428fc37a1dea4b50baac3c5fce796b49 Author: Stephan Fuhrmann Date: 2018-06-13T17:30:01Z Fixed 5 CheckStyle 3.0.0 plugin warnings. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #41: Fix checkstyle config.
GitHub user sfuhrm opened a pull request:
https://github.com/apache/commons-collections/pull/41
Fix checkstyle config.
mvn clean checkstyle:checkstyle was failing.
Error was: [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle (default-cli)
on project commons-collections4: An error has occurred in Checkstyle report
generation.: Failed during checkstyle execution: Failed during checkstyle
configuration: unable to parse configuration stream: Property
${checkstyle.suppressions.file} has not been set -> [Help 1]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sfuhrm/commons-collections CheckStyleMaven
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-collections/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
commit df3a7ef493a81441cdaac16b8c76fd4a0a782bc9
Author: Stephan Fuhrmann
Date: 2018-06-12T22:06:54Z
Fix checkstyle config.
Error was: [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle (default-cli)
on project commons-collections4: An error has occurred in Checkstyle report
generation.: Failed during checkstyle execution: Failed during checkstyle
configuration: unable to parse configuration stream: Property
${checkstyle.suppressions.file} has not been set -> [Help 1]
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #40: COLLECTIONS-685: IterableUtils has public con...
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 Closing because of breaking the API. May be interesting for commons-cli 5.0. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #40: COLLECTIONS-685: IterableUtils has public con...
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 BTW, TravisCI is right, technically this is an API change, but I suggest that all API uses are neither useful nor make sense. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/40 COLLECTIONS-685: IterableUtils has public constructor Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections COLLECTIONS-685 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit 49bc94faccddc2f81ce8af1db2bce8ccbede82d9 Author: Stephan Fuhrmann Date: 2018-06-12T06:02:06Z Constructor for Utils class was not private. This was obviously not intended as all other Utils classes have private constructors. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #39: Flat3Map: Some test cases going more i...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/39 Flat3Map: Some test cases going more into the details Flat3Map is quite complex in that there are many many ifs. I've added some test cases to validate the correct function of the map in many corner cases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections Flat3MapTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 883ea5426f372e2c181ae88b52ac8f60b65e01f8 Author: Stephan Fuhrmann Date: 2018-06-11T18:43:40Z Some test cases going more into the details of the Flat3Map implementation --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...
Github user sfuhrm commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @kinow thanks for your review! Oops, my maven build had a hickup and all tests were green. There's a design problem in the code you pointed me to. Every Option instance may be illegal (short and long == null) until first use. OptionBuilder (line 356) insists on creating an Option instance even if he long parameter is missing. Option.Builder does something similar. The setting happens after Option instance construction. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...
Github user sfuhrm commented on the issue: https://github.com/apache/commons-cli/pull/25 Hi @kinow thanks for your review! Oops, my maven build had a hickup and all tests were green. There's a design problem in the code you pointed me to. Every Option instance may be illegal (short and long == null) until first use. OptionBuilder (line 356) insists on creating an Option instance even if he long parameter is missing. Option.Builder does something similar. The setting happens after Option instance construction. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-cli/pull/25 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-cli/pull/25 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #38: COLLECTIONS-681: New unit test for Mul...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/38 COLLECTIONS-681: New unit test for MultiSetUtils A unit test for the MultiSetUtils. The MultiSetUtils had no tests at all, so this will improve the overall coverage. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections MultiSetUtilsTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit d0fefc5b50aeb7acbad5fbc4b36266d7ed6a855d Author: Stephan Fuhrmann Date: 2018-06-09T18:11:59Z New unit test for MultiSetUtils --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #37: COLLECTIONS-673: Fix inspired by the G...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/37 COLLECTIONS-673: Fix inspired by the Guava partition() implementation A fix for the COLLECTIONS-673 bug and a unit test proving the fix for the shown defect. See https://issues.apache.org/jira/browse/COLLECTIONS-673 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-collections COLLECTIONS-673 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit faf27f611f4429c77a800124b5fb6f641f871c0f Author: Stephan Fuhrmann Date: 2018-06-09T17:30:13Z COLLECTIONS-673: Fix inspired by the Guava partition() implementation --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #25: CLI-284: Fix inconsistent behaviour for short ...
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-cli/pull/25 CLI-284: Fix inconsistent behaviour for short and long name == null Fix for https://issues.apache.org/jira/browse/CLI-284 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sfuhrm/commons-cli master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-cli/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 4a2e95d01e39d89ffb2711f0b13f0020fef0d561 Author: Stephan Fuhrmann Date: 2018-06-09T11:24:13Z CLI-284: Fix inconsistent behaviour for short and long name == null --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
