Re: [ALL] Broken builds

2019-02-12 Thread Matt Sicker
Using something like prow via Jenkins X or similar helps in automating merging PRs after they've been approved and the build has passed. Otherwise, making it a manual process will just cause headaches. On Sun, 10 Feb 2019 at 08:52, Gary Gregory wrote: > > On Sun, Feb 10, 2019 at 9:20 AM Pascal

Re: [ALL] Broken builds

2019-02-10 Thread Gary Gregory
On Sun, Feb 10, 2019 at 9:20 AM Pascal Schumacher wrote: > I'm not sure if the error can be fixed in the Maven Javadoc Plugin. > > While the bug was rejected by OpenJDK at first, is was later reopened > and fixed, but only in Java 13 and 12.0.1: > >

Re: [ALL] Broken builds

2019-02-10 Thread Pascal Schumacher
I'm not sure if the error can be fixed in the Maven Javadoc Plugin. While the bug was rejected by OpenJDK at first, is was later reopened and fixed, but only in Java 13 and 12.0.1: https://bugs.openjdk.java.net/browse/JDK-8212233 Am 10.02.2019 um 14:24 schrieb Gary Gregory: Note that builds

Re: [ALL] Broken builds

2019-02-10 Thread Gary Gregory
Note that builds that break on Java 11 due to Javadoc errors with unnamed modules _should_ be fixed when the next version of the Maven Javadoc Plugin is released (3.1.0 IIRC) Gary On Sat, Feb 9, 2019 at 11:56 AM Gilles Sadowski wrote: > Hi. > > Le sam. 9 févr. 2019 à 17:10, Benedikt Ritter a

Re: [ALL] Broken builds

2019-02-09 Thread Gilles Sadowski
Hi. Le sam. 9 févr. 2019 à 17:10, Benedikt Ritter a écrit : > > Hi, > > several component have are broken builds on the master branch. Should be > change our policy for pushing to master to a pull request based model, > where each change has to pass the CI pipeline first? I think this would be >

[ALL] Broken builds

2019-02-09 Thread Benedikt Ritter
Hi, several component have are broken builds on the master branch. Should be change our policy for pushing to master to a pull request based model, where each change has to pass the CI pipeline first? I think this would be better as pushing stuff to master and then fixing it afterwards. Benedikt