Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Rob Tompkins
> On Aug 27, 2018, at 2:33 PM, Pascal Schumacher > wrote: > > At least RAT and clirr/japicmp should be part of default goal. > > I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer > error-prone nowadays) to be part of the default goal. > > On Java 8+ it is also

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Pascal Schumacher
At least RAT and clirr/japicmp should be part of default goal. I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer error-prone nowadays) to be part of the default goal. On Java 8+ it is also helpful to make javadoc part of the default goal. I think it is very convenient

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-20 Thread Gary Gregory
The RAT check should be turned on by default IMO. Gary On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter wrote: > Hi, > > one thing I always have to do when preparing a release is to fix all the > checkstyle and findbugs errors. This step could be eliminated if we added > checkstyle:check and

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-20 Thread Gilles
Hello. On Mon, 20 Aug 2018 08:45:03 +0200, Benedikt Ritter wrote: Hi, one thing I always have to do when preparing a release is to fix all the checkstyle and findbugs errors. This step could be eliminated if we added checkstyle:check and findbugs:check to the maven default goal. This way it

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-20 Thread Stefan Bodewig
On 2018-08-20, Benedikt Ritter wrote: > one thing I always have to do when preparing a release is to fix all the > checkstyle and findbugs errors. This step could be eliminated if we added > checkstyle:check and findbugs:check to the maven default goal. This way it > would be executed on CI

[ALL] Make checkstyle:check part of default maven goal?

2018-08-20 Thread Benedikt Ritter
Hi, one thing I always have to do when preparing a release is to fix all the checkstyle and findbugs errors. This step could be eliminated if we added checkstyle:check and findbugs:check to the maven default goal. This way it would be executed on CI builds and we would see failing