Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-28 Thread Elijah Zupancic
Oh, no blame taken. I'm actually really excited about all of the changes. Unfortunately, I've been missing for a while due to increased work responsibilities. The changes are all things way beyond what I was initially envisioning as a 2.0. What led me to contribute was that I was using Chain and

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-27 Thread Benedikt Ritter
Hi Elijah, nice to have you with us again :-) 2013/6/26 Elijah Zupancic eli...@zupancic.name Hi Benedikt, I made the decision to inherit from ConcurrentHashMap because the original implementation was inheriting from HashMap. I was doing an incremental refactoring approach and there was

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-26 Thread Elijah Zupancic
Hi Benedikt, I made the decision to inherit from ConcurrentHashMap because the original implementation was inheriting from HashMap. I was doing an incremental refactoring approach and there was never a good justification for that design rather I was trying to make evolutionary improvements. Being

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-25 Thread Benedikt Ritter
I have created CHAIN-101 [1] Benedikt [1] https://issues.apache.org/jira/browse/CHAIN-101 Am 24.06.2013 um 20:57 schrieb Adrian Crum adrian.c...@sandglass-software.com: I have always preferred the has-a approach over the is-a approach. It makes things easier to refactor down the road.

[CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-24 Thread Benedikt Ritter
Hi, I just wonder why ContextMap inherits from ConcurrentHashMap. This seems like an unnecessary restriction. The context interface makes explicit, that implementations do not have to be thread safe. Beside that we loose all thread safety a ConcurrentHashMap provides with our

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-24 Thread Adrian Crum
I have always preferred the has-a approach over the is-a approach. It makes things easier to refactor down the road. -Adrian On 6/24/2013 7:30 PM, Benedikt Ritter wrote: Hi, I just wonder why ContextMap inherits from ConcurrentHashMap. This seems like an unnecessary restriction. The context