[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-07-09 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Just adding this diff from the code above if needed for future reference. this pr can be closed - do we possibly need more committers for CLI? It doesn't seem like anyone is paying attention to

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-07-09 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Just adding this diff from the code above if needed for future reference. this pr can be closed - do we possibly need more committers for CLI? It doesn't seem like anyone is paying attention to

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-19 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 fwiw - this is what I had to fix ... probably better off not digging around in the default parser though if not needed :0 private void handleShortAndLongOption(String token) throws

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-19 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 fwiw - this is what I had to fix ... probably better off not digging around in the default parser though if not needed :0 private void handleShortAndLongOption(String token) throws

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Yep, that works for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 Yep, that works for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 No worries at all. While here, what are your thoughts about that scenario? To me it seems odd if you concatenated a flag with the value it represents. Clearly Java delimits arguments passed

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 No worries at all. While here, what are your thoughts about that scenario? To me it seems odd if you concatenated a flag with the value it represents. Clearly Java delimits arguments passed

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 my bad... I guess it makes sense to wait to merge the test until the bug is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread jlm429
Github user jlm429 commented on the issue: https://github.com/apache/commons-cli/pull/14 my bad... I guess it makes sense to wait to merge the test until the bug is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 My impression base on my reading of the [CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code: ```java private DefaultParser parser; private

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-18 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 My impression base on my reading of the [CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code: ```java private DefaultParser parser; private

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-17 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 I see you got it sorted. I'll give this a look in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-17 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 I see you got it sorted. I'll give this a look in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-17 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/14 [![Coverage Status](https://:/builds/12017835/badge)](https://:/builds/12017835) Coverage remained the same at 96.244% when pulling **a2b142847c452f27462575cce3534ef534796b69 on

[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test

2017-06-17 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-cli/pull/14 [![Coverage Status](https://:/builds/12017835/badge)](https://:/builds/12017835) Coverage remained the same at 96.244% when pulling **a2b142847c452f27462575cce3534ef534796b69 on