Agreed on switching to JUnit 5.
Gary
On Sun, Jul 3, 2022, 22:41 Matt Juntunen wrote:
> Thanks, Bruno and Gary!
>
> Gary,
> I think the unit tests as a whole could use some upgrading. I'm
> picturing a conversion to JUnit 5, during which we could ensure
> compatibility with the latest JDK
Agreed, we want to keep them in the Javadoc. An interesting side quest
would be to investigate switching to the latest version of JavaCC or
switching to Antlr.
Gary
On Mon, Jul 4, 2022, 10:38 Matt Juntunen wrote:
> Hello Alex,
>
> That would remove those files from the javadoc completely. As
Hello Alex,
That would remove those files from the javadoc completely. As of now,
the generated files are included in the javadoc [1]. These files are
part of the public API (per previous releases) so I don't believe we
would want them undocumented.
Regards,
Matt J
[1]
On Mon, 4 Jul 2022 at 03:41, Matt Juntunen
wrote:
> I'm not sure what to do
> about the javadoc warnings on the generated classes. From the comments
> in the pom, this seems to have been an issue since v2.4.
>
**/generated/*.java
Or whatever path is suitable [1].
Alex
[1]
Thanks, Bruno and Gary!
Gary,
I think the unit tests as a whole could use some upgrading. I'm
picturing a conversion to JUnit 5, during which we could ensure
compatibility with the latest JDK versions. I'm not sure what to do
about the javadoc warnings on the generated classes. From the comments
+1
Based on the source zip file.
Builds OK on Java 8 and Java 11 on macOS
SHA and ASC files OK
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /usr/local/Cellar/maven/3.8.6/libexec
Java version: 1.8.0_322, vendor: Homebrew, runtime:
Note that the tests do not pass with Java 18 because EasyMock does not
support Java 18:
[ERROR] Tests run: 11, Failures: 0, Errors: 5, Skipped: 0, Time
elapsed: 0.007 s <<< FAILURE! - in
org.apache.commons.configuration2.reloading.TestFileHandlerReloadingDetector
[ERROR]
[x] +1 Release these artifacts
Building tag OK with mvn clean test install site -e -X on
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.3, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale:
Missed this RC, sorry. Thanks for the reminder, on it.
On Sun, 3 Jul 2022 at 16:35, Matt Juntunen
wrote:
> Could we get some votes on RC3, please?
>
> Regards,
> Matt J
>
> On Fri, Jul 1, 2022 at 8:23 AM Gary Gregory
> wrote:
> >
> > Well, not fix the warnings since these are in generated code
Could we get some votes on RC3, please?
Regards,
Matt J
On Fri, Jul 1, 2022 at 8:23 AM Gary Gregory wrote:
>
> Well, not fix the warnings since these are in generated code but it
> would be nice to avoid polluting the build output just for generate
> code warnings while keeping warnings for our
Well, not fix the warnings since these are in generated code but it
would be nice to avoid polluting the build output just for generate
code warnings while keeping warnings for our main code...
Gary
On Fri, Jul 1, 2022 at 8:21 AM Gary Gregory wrote:
>
> Not a release blocker but a FTR TODO to
Not a release blocker but a FTR TODO to fix these Javadoc warnings:
[INFO] --- maven-javadoc-plugin:3.3.2:javadoc (default-cli) @
commons-configuration2 ---
[INFO] No previous run data found, generating javadoc.
[INFO]
100 warnings
[WARNING] Javadoc Warnings
[WARNING]
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons Configuration 2.7 was released, so I would like
to release Apache Commons Configuration 2.8.0.
Apache Commons Configuration 2.8.0 RC3 is available for review here:
13 matches
Mail list logo
