Hi
I'm going to address Dave's three mails in a single response
dam6923 . wrote:
In SevenZFile.java
Constructor...
1) Close file on exception instead of the current technique of keeping
a succeeded flag.
This means I have to catch and rethrow the exception. I don't think I
like this
On 2013-10-15, Stefan Bodewig wrote:
But we probably should store the password as a char[] anyway
s/char/byte/
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail:
Just a couple of immediate thoughts (just starting to look things over...)
In SevenZFile.java
Constructor...
1) Close file on exception instead of the current technique of keeping
a succeeded flag.
2) Move setting the password to the last line of the constructor so
that it isn't stored if an
org.apache.commons.compress.compressors.lzma.LZMACompressorInputStream#read()
Current: count(ret == -1 ? -1 : 1);
Change: count(ret == -1 ? 0 : 1);
On Mon, Oct 14, 2013 at 12:17 AM, Stefan Bodewig bode...@apache.org wrote:
I think enough issues have been identified to warrant a second RC.
On Mon, Oct 14, 2013 at 12:03 PM, dam6923 . dam6...@gmail.com wrote:
Just a couple of immediate thoughts (just starting to look things over...)
In SevenZFile.java
Constructor...
1) Close file on exception instead of the current technique of keeping
a succeeded flag.
2) Move setting the
org.apache.commons.compress.archivers.ar.ArArchiveInputStream#getNextArEntry()
The code to skip to the next available entry looks a bit inefficient
because it reads one byte at a time in a loop. Consider using
org.apache.commons.compress.utils.IOUtils.skip(InputStream, long)
Consider using
Am 14.10.2013 06:11, schrieb Stefan Bodewig:
On 2013-10-13, Oliver Heger wrote:
The artifacts look good, the build works fine with Java 1.7 on Windows
7. I tried to build with Java 1.5, but got:
Tests in error:
On 2013-10-14, Oliver Heger wrote:
Am 14.10.2013 06:11, schrieb Stefan Bodewig:
On 2013-10-13, Oliver Heger wrote:
When I build the site locally, I get a different clirr report showing 9
errors because some public methods have been made final.
Strange. Why would Clirr create different
Foo 1.2 RC1 is available for review ? ;)
Gary
On Sun, Oct 13, 2013 at 1:31 AM, Stefan Bodewig bode...@apache.org wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not created a
+1
BUT the following are not blockers but should be improved if another RC is cut:
- Low (27%) code coverage for the new class
https://commons.apache.org/proper/commons-compress/cobertura/org.apache.commons.compress.archivers.arj.ArjArchiveEntry.html
- PMD violations in new code, for example
On 2013-10-13, Gary Gregory wrote:
+1
Thanks.
BUT the following are not blockers but should be improved if another RC is
cut:
- Low (27%) code coverage for the new class
On 10/12/13 10:31 PM, Stefan Bodewig wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not created a RC website as the only difference to the current
website would be the
The artifacts look good, the build works fine with Java 1.7 on Windows
7. I tried to build with Java 1.5, but got:
Tests in error:
SevenZTestCase.testSevenZArchiveCreationUsingLZMA2:37-testSevenZArchiveCreati
on:59 ╗ OutOfMemory
XZTestCase.testXZCreation:44 ╗ OutOfMemory Java heap space
Tests
On 10/13/13 12:39 PM, Phil Steitz wrote:
On 10/12/13 10:31 PM, Stefan Bodewig wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not created a RC website as the only difference
+1
--
Olivier
On Oct 13, 2013 4:32 PM, Stefan Bodewig bode...@apache.org wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not created a RC website as the only difference to
--
Olivier
On Oct 14, 2013 6:39 AM, Phil Steitz phil.ste...@gmail.com wrote:
On 10/12/13 10:31 PM, Stefan Bodewig wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not
On 13 October 2013 20:43, Phil Steitz phil.ste...@gmail.com wrote:
On 10/13/13 12:39 PM, Phil Steitz wrote:
On 10/12/13 10:31 PM, Stefan Bodewig wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
On Sun, Oct 13, 2013 at 7:38 PM, sebb seb...@gmail.com wrote:
On 13 October 2013 20:43, Phil Steitz phil.ste...@gmail.com wrote:
On 10/13/13 12:39 PM, Phil Steitz wrote:
On 10/12/13 10:31 PM, Stefan Bodewig wrote:
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only
On 2013-10-13, Phil Steitz wrote:
I am sorry. I forgot one other thing to verify. The clirr report
complains about dropping a field. Is this spurious / not really an
issue?
Ah yes, I should have talked about that.
It is a protected field in the Tar*Stream classes which should have
never
On 2013-10-13, Oliver Heger wrote:
The artifacts look good, the build works fine with Java 1.7 on Windows
7. I tried to build with Java 1.5, but got:
Tests in error:
SevenZTestCase.testSevenZArchiveCreationUsingLZMA2:37-testSevenZArchiveCreati
on:59 ╗ OutOfMemory
On 10/13/13 9:05 PM, Stefan Bodewig wrote:
On 2013-10-13, Phil Steitz wrote:
I am sorry. I forgot one other thing to verify. The clirr report
complains about dropping a field. Is this spurious / not really an
issue?
Ah yes, I should have talked about that.
It is a protected field in the
I think enough issues have been identified to warrant a second RC.
I'll take care of the bad version number in the release notes as well as
the PMD warnings in the ARJ-Package. ArjArchiveEntry's test coverage
has already been increased in trunk.
We should talk about the Clirr report further and
Hi
since Compress 1.5 we've fixed a few bugs but most notably added
read-only support for LZMA standalone, uncompressed ARJ and full support
for 7z.
I have not created a RC website as the only difference to the current
website would be the download page and the version number - and I'd
23 matches
Mail list logo
