Re: [lang] Rationale for multiplying by one in Conversion?

2014-04-25 Thread Benedikt Ritter
go for it. 2014-04-25 6:19 GMT+02:00 Henri Yandell flame...@gmail.com: +1 to remove. On Mon, Apr 21, 2014 at 1:42 PM, Duncan Jones djo...@apache.org wrote: Hi everyone, The Conversion class has numerous instances in which a value is multiplied by one (e.g. line 1054): shift = i

Re: [lang] Rationale for multiplying by one in Conversion?

2014-04-24 Thread Henri Yandell
+1 to remove. On Mon, Apr 21, 2014 at 1:42 PM, Duncan Jones djo...@apache.org wrote: Hi everyone, The Conversion class has numerous instances in which a value is multiplied by one (e.g. line 1054): shift = i * 1 + dstPos; I suspect this is a copy/paste issue, since other parts of the

[lang] Rationale for multiplying by one in Conversion?

2014-04-21 Thread Duncan Jones
Hi everyone, The Conversion class has numerous instances in which a value is multiplied by one (e.g. line 1054): shift = i * 1 + dstPos; I suspect this is a copy/paste issue, since other parts of the class follow a similar pattern, e.g. line 881: shift = i * 8 + dstPos; The unit tests pass