Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Rob Spoor
Apparently you guys forgot about joinWith: https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#joinWith-java.lang.String-java.lang.Object...- However, even without this method, StringUtils.join can easily be replaced with streams: Stream.of(x,

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Tomo Suzuki
Gary, That's a good point. I wasn't thinking about StringUtil's applicability to Object array. On Wed, Mar 11, 2020 at 11:18 AM Gary Gregory wrote: > On Wed, Mar 11, 2020 at 10:24 AM Tomo Suzuki > wrote: > > > (I'm not a commons-lang user) > > Java 8 has String.join for the same purpose. > >

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Gary Gregory
On Wed, Mar 11, 2020 at 10:24 AM Tomo Suzuki wrote: > (I'm not a commons-lang user) > Java 8 has String.join for the same purpose. > > https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#join-java.lang.CharSequence-java.lang.CharSequence...- > I would deprecate StringUtils.join in

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Tomo Suzuki
(I'm not a commons-lang user) Java 8 has String.join for the same purpose. https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#join-java.lang.CharSequence-java.lang.CharSequence...- I would deprecate StringUtils.join in favor of String.join. On Wed, Mar 11, 2020 at 10:16 AM Matt

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Matt Benson
Definitely +1 if we didn't already do this, except I would put what I call a "Yoda preposition" in there, e.g. joinBy or joinWith. Matt On Wed, Mar 11, 2020, 9:00 AM Gary Gregory wrote: > HI All: > > Now that Java's had varargs for a while now, using APIs like >

[lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

2020-03-11 Thread Gary Gregory
HI All: Now that Java's had varargs for a while now, using APIs like org.apache.commons.lang3.StringUtils.join(Object[], char) feels backward to me. I want to say: StringUtils.join('.', "foo", "bar", "bang"); Not: StringUtils.join(new String[] { "foo", "bar", "bang" }, '.'); Any thoughts on