To: Commons Developers List
Subject: Re: strange change to
src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
Hi All:
The upshot here (to me) is that we have an opportunity to help Mark by:
- Simply agreeing that it is OK to change the visibility of the method(s) if
appropriate tests
Hi All:
The upshot here (to me) is that we have an opportunity to help Mark by:
- Simply agreeing that it is OK to change the visibility of the method(s)
if appropriate tests are added, or:
- Provide a new API _somewhere_, presumably in the _best/right_ place that
fulfills his app's needs.
The
Le 18/10/2019 à 11:10, Xeno Amess a écrit :
> Do commons follow semver?
No but we care about backward compatibility.
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail:
Do commons follow semver?
Emmanuel Bourg 于 2019年10月18日周五 下午5:05写道：
> Le 18/10/2019 à 10:52, sebb a écrit :
>
> > As noted in the OP, the change was part of changing the package name.
>
> If the visibility change triggered a regression I think it should be
> reverted.
>
> Emmanuel bourg
>
>
Le 18/10/2019 à 10:52, sebb a écrit :
> As noted in the OP, the change was part of changing the package name.
If the visibility change triggered a regression I think it should be
reverted.
Emmanuel bourg
-
To unsubscribe,
lto:seb...@gmail.com]
> > Sent: Thursday, October 17, 2019 3:55 PM
> > To: Commons Developers List
> > Subject: Re: strange change to
> > src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
> >
> > On Thu, 17 Oct 2019 at 23:16, Mark Roberts
> > w
change was necessary or not.
If there are use-cases that are not covered by the current tests, it
would be very useful to get those added.
> -Original Message-
> From: sebb [mailto:seb...@gmail.com]
> Sent: Thursday, October 17, 2019 3:55 PM
> To: Commons Developers List
> Subject: Re: strange c
to:seb...@gmail.com]
> Sent: Thursday, October 17, 2019 3:55 PM
> To: Commons Developers List
> Subject: Re: strange change to
> src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java
>
> On Thu, 17 Oct 2019 at 23:16, Mark Roberts
> wrote:
> >
> &g
by me and as we
move forward into Java 9 and beyond I'm sure others are going to run the
problem.
-Original Message-
From: sebb [mailto:seb...@gmail.com]
Sent: Thursday, October 17, 2019 3:55 PM
To: Commons Developers List
Subject: Re: strange change to
src/main/java/org/apache/bcel
On Thu, 17 Oct 2019 at 23:16, Mark Roberts wrote:
>
> When the BCEL package was renamed back to org.apache.bcel in:
>
> commit d522432b79044740831a132d8b92e7dab5477444
> Author: Benedikt Ritter
> Date: Tue Jun 7 17:28:43 2016 +
>
> The methods to add and delete annotations were changed
When the BCEL package was renamed back to org.apache.bcel in:
commit d522432b79044740831a132d8b92e7dab5477444
Author: Benedikt Ritter
Date: Tue Jun 7 17:28:43 2016 +
The methods to add and delete annotations were changed from public to protected
with a confusing comment:
< public
11 matches
Mail list logo
