I've not had a chance to review carefully because I'm traveling but I love
the idea and am +1 to the patch in concept. Since it is replacing something
that doesn't work, I see no risk in moving forward with this. Thanks!
Rich
On Fri, Feb 23, 2024, 03:44 bdelacretaz (via GitHub) wrote:
>
>
sebbASF commented on PR #146:
URL: https://github.com/apache/comdev-site/pull/146#issuecomment-1961091696
It's better, but there are still some changes that appear to be unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bdelacretaz commented on PR #146:
URL: https://github.com/apache/comdev-site/pull/146#issuecomment-1961058802
> it appears to have a lot of unrelated changes..
yes, sorry I messed up after rebasing, fixed now
--
This is an automated message from the Apache Git Service.
To respond
sebbASF commented on PR #146:
URL: https://github.com/apache/comdev-site/pull/146#issuecomment-1961033402
It's very difficult to review the PR, as it appears to have a lot of
unrelated changes.
It would be better to make separate changes in separate commits, otherwise
the history is
bdelacretaz commented on PR #146:
URL: https://github.com/apache/comdev-site/pull/146#issuecomment-1961010970
I'm planning to merge this early next week unless someone objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
