Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-05 Thread Christopher
On Mon, Nov 5, 2018 at 12:44 PM Dave Fisher wrote: > > > > > On Nov 5, 2018, at 8:35 AM, Christopher wrote: > > > > On Mon, Nov 5, 2018 at 3:49 AM Bertrand Delacretaz > > wrote: > >> > >> Hi, > >> > >> On Fri, Nov 2, 2018 at 7:02 PM Christopher wrote: > >>> ...it would be a mistake if ASF were

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-05 Thread Dave Fisher
> On Nov 5, 2018, at 8:35 AM, Christopher wrote: > > On Mon, Nov 5, 2018 at 3:49 AM Bertrand Delacretaz > wrote: >> >> Hi, >> >> On Fri, Nov 2, 2018 at 7:02 PM Christopher wrote: >>> ...it would be a mistake if ASF were to try to impose a more spammy >>> workflow to dev@ onto every PMC,

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-05 Thread Christopher
On Mon, Nov 5, 2018 at 3:49 AM Bertrand Delacretaz wrote: > > Hi, > > On Fri, Nov 2, 2018 at 7:02 PM Christopher wrote: > >...it would be a mistake if ASF were to try to impose a more spammy > > workflow to dev@ onto every PMC, as a requirement... > > FWIW I didn't suggest imposing anything like

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-05 Thread Bertrand Delacretaz
Hi, On Fri, Nov 2, 2018 at 7:02 PM Christopher wrote: >...it would be a mistake if ASF were to try to impose a more spammy > workflow to dev@ onto every PMC, as a requirement... FWIW I didn't suggest imposing anything like that - my only concern is that it should be possible to follow the

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-02 Thread Kenneth Knowles
This comes up a lot on Beam too. We have a practice where if a PR is a big change, or if discussion veers into into design details rather than just code, we expect our committers to say "let's move this to the dev list". We also try to encourage everyone to announce on dev@ not just for the design

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-02 Thread Christopher
In Accumulo and Fluo, we route to notifications@ also. If these went to dev@, it would be too spammy, and I suspect even fewer people would participate on important dev@ threads than they do now. Letting it go to notifications@, people can subscribe to all activity there, if they wish... or they

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-02 Thread Joan Touzet
We also use them successfully on CouchDB and I don't see the problem here. We do route these notifications to notifications@, not dev@. My email client properly threads multiple comments on the same PR. Another option is to use the GitHub "watch" functionality on a repository, which can provide

Re: Discussions in pull requests vs. dev list (was: The Apache Way and good developers...)

2018-11-02 Thread Christofer Dutz
Hi, Well in the PLC4X project we are using GitHub pull requests. All comments are forwarded to the list and this is fine. You are able to follow what's going on without much problems. However when it comes to the PR reviews, things tend to get it of hand. Every now and then I open my mail