Re: Dropping iOS 5.0 support

2013-12-20 Thread Shazron
I'm definitely all for customers first - the proposal is based on the practicality factors I've previously stated: http://markmail.org/message/mldr2mzrpf233h2r It's hard to vouch for a release runs on iOS 5.0 when we can't test on it, internally I've already asked around but no dice, and I

Re: Dropping iOS 5.0 support

2013-12-20 Thread Shazron
Oh, and I forgot - there are actually 4 more configurations to test (for a total of 12). I forgot iPhone only on an iPad (retina and non-retina) on iOS 6 and 7. Yes, there is an Apple bug on iOS 7 for iPhone only on iPad *sigh*... On Fri, Dec 20, 2013 at 2:50 AM, Shazron shaz...@gmail.com wrote:

Re: Dropping iOS 5.0 support

2013-12-20 Thread Josh Soref
Fwiw, If you have your installation media, getting 10.8/10.9 to install in the latest version of VirtualBox‎ is trivial. I believe that the same applies to 10.7, but I can't find my installation media :(. - This transmission

Re: Upleveled 3.3.x branch of cordova-amazon-fireos

2013-12-20 Thread Andrew Grieve
Hey Archana, Our branching strategy for platforms is to commit everything to master, and then cherry-pick things into release branches. Unless you're planning on doing a 3.3.1 point release, then I'd guess you want these commits on master? Andrew On Thu, Dec 19, 2013 at 6:42 PM, Naik, Archana

Started Implementing CB-2606 Add support for icon in config.xml

2013-12-20 Thread Axel Nennker
Hi, I started to implement CB-2606 https://github.com/AxelNennker/cordova-cli The code is here: https://github.com/AxelNennker/cordova-cli This https://github.com/AxelNennker/cordova-cli/blob/master/src/config_parser.js changes the config_parser to support the icon element. On Android using

[Contacts] Tests and FFOS plugin

2013-12-20 Thread Piotr Zalewa
I've added FFOS support (https://github.com/zalun/cordova-plugin-contacts) I needed to modify the tests as well to make it work under FFOS FFOS Contacts API requires the app to by privilleged which bans inline javascript. (https://github.com/zalun/cordova-mobile-spec) I've been working on

Re: Dropping iOS 5.0 support

2013-12-20 Thread Andrew Grieve
I think we'd be fine to drop official support for iOS 5, but as has been pointed out, there's very little code-wise that would change. If bug reports come that say this function is being called and it doesn't exist on iOS 5, then that's a trivial fix. Likely devs will just fix it themselves

Re: Cordova 3.3.1-0.1.2 doesn't load javascript for plugins

2013-12-20 Thread Don Coleman
*device.name http://device.name *was a bad example. The problems I'm seeing is that *device* doesn't exist. This also happens with other plugins I've tried. The plugin gets installed but the js-module code doesn't. $ cat ./platforms/ios/www/cordova_plugins.js

Re: Started Implementing CB-2606 Add support for icon in config.xml

2013-12-20 Thread Andrew Grieve
Had a quick look. Thanks for taking this on! It's truly an overdue feature. I've got a bunch of comments below, most of which I'm hoping others will chime in on as well because they are design opinions more than technical questions. - Should CLI be in the business of resizing icons or

Re: Cordova 3.3.1-0.1.2 doesn't load javascript for plugins

2013-12-20 Thread Andrew Grieve
I'm seeing the same thing. However: $ cat platforms/ios/.staging/www/cordova_plugins.js shows the correct info, and if I run cordova prepare, then $ cat ./platforms/ios/www/cordova_plugins.js shows the right stuff. I hit this bug last week, and Braden figured out that the fix for CB-5579 had a

RE: Camera targetWidth targetHeight

2013-12-20 Thread Wargo, John
Well I've not really received a consensus on anything. One or two people have spoken up, but not much beyond that. John M. Wargo SCN Blog: http://scn.sap.com/blogs/johnwargo Twitter: @johnwargo -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, December 17,

Re: Deleting Plugin Docs

2013-12-20 Thread Andrew Grieve
Thanks! The problem I saw with the full examples, is that they are copy pastes of the Quick Examples, but put within an html page and an onDeviceReady callback. Given that the default app templates already have this, is it really necessary to have it in every example? You can still copy paste

Re: Deleting Plugin Docs

2013-12-20 Thread Andrew Grieve
We'll point them to master as soon as the docs exist on master. On Thu, Dec 19, 2013 at 4:13 PM, Marcel Kinard cmarc...@gmail.com wrote: +1 to Michael's comments. And I know it is a bit too early to do this, but the links to the docs on github should point to the master branch, not the dev

Re: Plugins Release Tomorrow

2013-12-20 Thread Andrew Grieve
Well, I didn't do this yesterday and don't want to do a Friday release, so I'll do this Monday instead. I'll skip File plugin again until someone can test WP. On Thu, Dec 19, 2013 at 1:40 AM, purplecabbage purplecabb...@gmail.comwrote: I have not. Someone needs to test the impact on windows

RE: Deleting Plugin Docs

2013-12-20 Thread Wargo, John
Andrew, Will you be processing the plugin docs so they generate the pages like they used to? Being able to click and link around within a particular plugin's doc is super helpful. John M. Wargo Twitter: @johnwargo -Original Message- From: agri...@google.com

Re: Started Implementing CB-2606 Add support for icon in config.xml

2013-12-20 Thread Axel Nennker
inline. Do you know why the tests fail? They look ok for me but those are the first jasmine tests I ever wrote. BTW: the note in cordova-cli's README.md on test seems a little short npm test. I suggest to be a little more verbose here: - clone mobile-spec e.g.: git clone

Re: Camera targetWidth targetHeight

2013-12-20 Thread Andrew Grieve
Just to recap (correct if I'm wrong) - 1. targetWidth targetHeight are not being interpreted consistently across platforms. 2. What they should do is: - Never grow the image - Shrink the image while maintaining aspect ratio, such that both dimension of the resized image fit within targetWidth

Re: Deleting Plugin Docs

2013-12-20 Thread Carlos Santana
I'm a bit lost Is the eventual goal to build the docs as a single website (docs.cordova.io) with multiple repos cordova-docs repo and plugin repos? On Fri, Dec 20, 2013 at 11:00 AM, Wargo, John john.wa...@sap.com wrote: Andrew, Will you be processing the plugin docs so they generate the

Re: Cordova 3.3.1-0.1.2 doesn't load javascript for plugins

2013-12-20 Thread Joe Bowser
Is the CLI released along with the platforms? Today is kind of a bad day to release anything, as this is the last working day of Adobe for the year, and over half our team is already on PTO. I'm sure others are in the same boat. On Fri, Dec 20, 2013 at 7:30 AM, Andrew Grieve agri...@chromium.org

Re: Deleting Plugin Docs

2013-12-20 Thread Andrew Grieve
Not in the short-term. I think our docs should be easy enough to write such that all plugin authors take the time to do it. To me, that means simple .md files. Might be able to do more fancy things when we host on plugins.cordova.io, but for now, it's just github's .md formatting. On Fri, Dec

Re: Upleveled 3.3.x branch of cordova-amazon-fireos

2013-12-20 Thread Joe Bowser
I think there should be a 3.3.1 point release for FireOS if it's missing fixes from 3.3. 3.3.0 was rushed because of the Christmas break, and if there are still people working between now and January 2, I'd be OK with it. I won't be around to review any changes though. :S On Fri, Dec 20, 2013

Re: Deleting Plugin Docs

2013-12-20 Thread Andrew Grieve
The eventual goal (in my eyes) is to have plugin docs: 1. Appear with the plugins on plugins.cordova.io. 2. Be accessible to devs after they have installed the plugin (e.g. by looking at plugins/foo/doc, or maybe by having cordova serve show them) On Fri, Dec 20, 2013 at 11:38 AM, Carlos

Re: Cordova 3.3.1-0.1.2 doesn't load javascript for plugins

2013-12-20 Thread Andrew Grieve
CLI is released on its own as well as when we do a platforms release. I believe this is a pretty minor bug though, since running prepare again fixes things (which happens when you run cordova build). On Fri, Dec 20, 2013 at 11:39 AM, Joe Bowser bows...@gmail.com wrote: Is the CLI released

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ --- (Updated Dec. 20, 2013, 4:51 p.m.) Review request for cordova. Changes

Re: Deleting Plugin Docs

2013-12-20 Thread Carlos Santana
All docs for Cordova CLI, Plugman CLI, and Platforms hosted/rendered on docs.cordova.io and All docs for Plugins hosted/rendered on plugins.cordova.io If this is true, I would like to see consistencies on look and feel of both websites, and ability to link back and forth between sites via links.

Re: Started Implementing CB-2606 Add support for icon in config.xml

2013-12-20 Thread Josh Soref
Andrew wrote: Should CLI be in the business of resizing icons or converting image formats? Probably not ‎ Should you have to supply an icon for each platform separately, or should we support one icon tag that will be used as the default for all platforms? Different platforms may have

Re: Plugins Release Tomorrow

2013-12-20 Thread Ian Clelland
That sounds reasonable. There isn't a huge rush on it. On Fri, Dec 20, 2013 at 10:54 AM, Andrew Grieve agri...@chromium.orgwrote: Well, I didn't do this yesterday and don't want to do a Friday release, so I'll do this Monday instead. I'll skip File plugin again until someone can test WP.

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Andrew Grieve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review30753 --- src/config_parser.js

Re: Camera targetWidth targetHeight

2013-12-20 Thread Brian LeRoux
+1. Open bugs John :) On Dec 21, 2013 2:49 AM, Andrew Grieve agri...@chromium.org wrote: Just to recap (correct if I'm wrong) - 1. targetWidth targetHeight are not being interpreted consistently across platforms. 2. What they should do is: - Never grow the image - Shrink the image

Re: Deleting Plugin Docs

2013-12-20 Thread Brian LeRoux
Agreed, that is a goal. Mike is looking at Docs, Joni/Steve/Anis Plugins, and we can refresh WWW last. On Dec 21, 2013 3:05 AM, Carlos Santana csantan...@gmail.com wrote: Forgot to mentioned consistency look and feel (i.e. CSS) between the *three*primary websites ! www.cordova.io

Re: Deleting Plugin Docs

2013-12-20 Thread Brian LeRoux
Yes! On Dec 21, 2013 2:50 AM, Andrew Grieve agri...@chromium.org wrote: The eventual goal (in my eyes) is to have plugin docs: 1. Appear with the plugins on plugins.cordova.io. 2. Be accessible to devs after they have installed the plugin (e.g. by looking at plugins/foo/doc, or maybe by

Re: Cordova 3.3.1-0.1.2 doesn't load javascript for plugins

2013-12-20 Thread Don Coleman
Prepare seems like a good work around. I agree with Joe, pushing a new release today is a bad idea. On Dec 20, 2013 11:51 AM, Andrew Grieve agri...@chromium.org wrote: CLI is released on its own as well as when we do a platforms release. I believe this is a pretty minor bug though, since

Re: Review Request 15775: Add --src --link to cordova create

2013-12-20 Thread Mark Koudritsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review30757 --- src/create.js https://reviews.apache.org/r/15775/#comment58868

Re: Deleting Plugin Docs

2013-12-20 Thread Michael Brooks
The problem I saw with the full examples, is that they are copy pastes of the Quick Examples, but put within an html page and an onDeviceReady callback. Given that the default app templates already have this, is it really necessary to have it in every example? You can still copy paste

Re: Extending CordovaWebView

2013-12-20 Thread Lindsey Simon
I was wondering how this is progressing.. (maybe there's already a mechanism for this via config.xml?) I ask because, in the CLI world, I'm not sure how to update webview settings for android, in particular because I'd like to make the changes mentioned here:

Re: Extending CordovaWebView

2013-12-20 Thread Andrew Grieve
Ian ended up adding a setting to .cordova/config.json that allows you to point to a custom template for platform add to use. Probably not applicable to your use-case. I'd say you could go one of two routes for this change: 1. Just make the changes right in your Foo.java (extends CordovaActivity)

Re: Camera targetWidth targetHeight

2013-12-20 Thread Shazron
+1 On Fri, Dec 20, 2013 at 8:38 AM, Andrew Grieve agri...@chromium.org wrote: Just to recap (correct if I'm wrong) - 1. targetWidth targetHeight are not being interpreted consistently across platforms. 2. What they should do is: - Never grow the image - Shrink the image while

Re: Dropping iOS 5.0 support

2013-12-20 Thread Shazron
I think that last paragraph is key - let's provide instructions in a doc in cordova-ios/guides if they need this support. Not sure we need this in cordova-docs On Fri, Dec 20, 2013 at 6:15 AM, Andrew Grieve agri...@chromium.org wrote: I think we'd be fine to drop official support for iOS 5,