Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Michal Mocny
I expect that if it is going out to users it should have a vote. Since we need to roll CLI to actually surface this to users, we can probably vote for both at that time. -Michal On Fri, Mar 28, 2014 at 8:14 PM, Steven Gill wrote: > I think we can vote on it when we vote on the tools. > On Mar

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Steven Gill
I think we can vote on it when we vote on the tools. On Mar 28, 2014 4:43 PM, "Shazron" wrote: > I assume this does not need a vote since it doesn't go in the dist folder, > and only downloaded by the CLI tool? > > > On Fri, Mar 28, 2014 at 4:37 PM, Shazron wrote: > > > iOS: Changes are in the 3

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Shazron
I assume this does not need a vote since it doesn't go in the dist folder, and only downloaded by the CLI tool? On Fri, Mar 28, 2014 at 4:37 PM, Shazron wrote: > iOS: Changes are in the 3.4.x branch, and 3.4.1 is tagged. I'll do more > testing over the weekend. > > > > On Fri, Mar 28, 2014 at 1

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Shazron
iOS: Changes are in the 3.4.x branch, and 3.4.1 is tagged. I'll do more testing over the weekend. On Fri, Mar 28, 2014 at 12:09 PM, Shazron wrote: > Yeah lets do a 3.4.1 iOS, simpler for now until we figure out any new way > regarding independent releases. > > Plan: > - branch off 3.4.0 releas

[GitHub] cordova-plugin-camera pull request: Prevent NPE on processResiultF...

2014-03-28 Thread mgurreta
GitHub user mgurreta opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/19 Prevent NPE on processResiultFromGallery when intent comes null There are cases when onActivityResult returns with Activity.RESULT_OK as resultCode but the intent in null. This produc

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087542 --- Diff: src/info.js --- @@ -30,105 +29,80 @@ var cordova_util = require('./util'), Outputs to a file */ module.exports = function

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087487 --- Diff: src/info.js --- @@ -30,105 +29,80 @@ var cordova_util = require('./util'), Outputs to a file */ module.exports = function

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087348 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087336 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087295 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11087286 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r11087137 --- Diff: src/info-utils.js --- @@ -0,0 +1,150 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contribu

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r11086944 --- Diff: src/info-utils.js --- @@ -0,0 +1,150 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contribu

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-28 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r11086870 --- Diff: src/info-utils.js --- @@ -0,0 +1,150 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contribu

[GitHub] cordova-ios pull request: Update CDVWebViewDelegate.m

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-5362 blackberry parser: support local...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-5585: Fixed hanging process stuck in ...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Added information for file-transfer plu...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Clarify behaviour of android KeepRunnin...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-ios pull request: [CB-5258] use exit library

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: fix args[0] bug, corodva -> cordova

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-5316 Spell Cordova as a brand unless ...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Update index.md

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-blackberry pull request: Rcruz/shim

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-docs pull request: fix semantic for title and 3 first sect...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-cli pull request: [CB-5258] use exit library

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Cordova 3.1.x - Adding amazon-fireos pla...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-blackberry pull request: [CB-1388] Add reset() to plugin A...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-cli pull request: CB-6338 Improve error for missing templa...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: add staging_dir func for firefoxos

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Update Cordova Webview Instructions

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Remove stray 'i'

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-cli pull request: bb10 config.xml options fix

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: [CB-3159][BlackBerry10] Updating plugin...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-5183 WP7/8 lib path is not correctly ...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: [BlackBerry10] Fixed 9 broken blackberry...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Cb 4570

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: added android:installLocation="prefe...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: 3.0.x - Adding amazon-fireos platform to...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11085455 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos : ['win3

[GitHub] cordova-plugman pull request: [CB-4714] Allow forcefully removing ...

2014-03-28 Thread jbondc
Github user jbondc commented on the pull request: https://github.com/apache/cordova-plugman/pull/31#issuecomment-38964731 Ya will have a fix for it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-plugman pull request: [CB-4714] Allow forcefully removing ...

2014-03-28 Thread jbondc
Github user jbondc closed the pull request at: https://github.com/apache/cordova-plugman/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: 5122 platform cl tools

2014-03-28 Thread mike-sierra
Github user mike-sierra commented on the pull request: https://github.com/apache/cordova-docs/pull/149#issuecomment-38963434 Wow, lots of random changes, but I think they're all fixed. Can you try again? But before merging, see my earlier comment about how this platform guide merges

[GitHub] cordova-plugman pull request: CB-6272 Fix subdir bug + tests & met...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugman pull request: CB-6344: Specify after which sibling...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugman pull request: [CB-4714] Allow forcefully removing ...

2014-03-28 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugman/pull/31#issuecomment-38963141 Going to close this given the work that's gone on since. Open a new one to continue on. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cordova-cli pull request: CB 6141 - Fix tests on windows + readabl...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Update README.md

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread Jesse
'process.platform' in node returns win32 for windows ( 32+64 ) 'process.arch' returns x64 if it is 64bit @purplecabbage risingj.com On Fri, Mar 28, 2014 at 12:00 PM, agrieve wrote: > Github user agrieve commented on a diff in the pull request: > > https://github.com/apache/cordova-cli/pul

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Shazron
Yeah lets do a 3.4.1 iOS, simpler for now until we figure out any new way regarding independent releases. Plan: - branch off 3.4.0 release - cherry-pick commits for template changes, script changes, callback id change (to allow callback ids with periods in them) - version it 3.4.1 in VERSION in th

[GitHub] cordova-js pull request: CB-5606 WP8. ArrayBuffer does not exist i...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cordova-js pull request: Fixed "WARNING: file name src\ubuntu\plat...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cordova-cli pull request: Update xml-helpers.js

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11080870 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos : ['win

[GitHub] cordova-mobile-spec pull request: CB-6372 Port createmobilespec fr...

2014-03-28 Thread cmarcelk
Github user cmarcelk closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r11080438 --- Diff: src/info-utils.js --- @@ -0,0 +1,150 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contributo

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r11080370 --- Diff: src/info-utils.js --- @@ -0,0 +1,150 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more contributo

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11080227 --- Diff: src/info.js --- @@ -30,105 +29,80 @@ var cordova_util = require('./util'), Outputs to a file */ module.exports = function in

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11080089 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor l

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11080035 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor l

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r1107 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor l

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/151#discussion_r11080008 --- Diff: src/info-utils.js --- @@ -0,0 +1,58 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor l

Re: Many CLI tests failing

2014-03-28 Thread Steven Gill
Medic is now showing plugman tests passing. No idea what is going on. They still pass fine for me. On Mar 28, 2014 6:07 AM, "David Kemp" wrote: > I have just verified the plugman state and on my machine I get the same 7 > errors that Medic gets. > All of them are related to version comparisions.

[GitHub] cordova-docs pull request: CB-6127 Spanish and French Translations...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: 6085 win8 compat

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: README.md updated to remove manual tran...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-android pull request: AlertDialog.Builder.create is reduda...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...

2014-03-28 Thread cmarcelk
Github user cmarcelk commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/53#issuecomment-38924229 It would be helpful if you put your real name in your github profile, so we could easily verify that you completed an ICLA. I had to search the mailing list

[GitHub] cordova-docs pull request: 5122 platform cl tools

2014-03-28 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-docs/pull/149#issuecomment-38949437 I think the changes here look good. Not sure why it was never merged. Just tried applying them though, and there were too many merge conflicts. Would you be able to

[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...

2014-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Promises FTW!

2014-03-28 Thread Andrew Grieve
IMO, this is *the* biggest feature of ES6, as it now means JS + DOM APIs are being spec'ed out that use them: Intent to ship for both FF & Chrome! https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0Fs5P6Xgg9g https://groups.google.com/forum/#!topic/mozilla.dev.platform/Usb5PmsxM10

[GitHub] cordova-plugins pull request: Resize webView to handle orientation...

2014-03-28 Thread gconnolly
GitHub user gconnolly opened a pull request: https://github.com/apache/cordova-plugins/pull/8 Resize webView to handle orientation change when keyboard will hide The webView does not get properly resized if the orientation changes before the keyboard is dismissed. This issue was int

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Steven Gill
I don't have any problem with going the 3.4.1 route. It would be simpler in terms of docs + js. Shazron, would that work for you? On Mar 28, 2014 8:27 AM, "Andrew Grieve" wrote: > From what I understand of the changes, it should work fine to do a 3.4.1 > and just leave the JS as is. > > > On Thu

Re: Consolidating the Distribution of Platforms & Plugins

2014-03-28 Thread Michal Mocny
I like the idea of hosting on npm just to simplify hosting/downloads, but still using our own tools for dependency / version management. New question: if we host plugins on npm, how can we simplify the plugin registry? Can we: (a) fork https://github.com/npm/npm-www (b) adopt a strategy like http

[GitHub] cordova-js pull request: Fixed "WARNING: file name src\ubuntu\plat...

2014-03-28 Thread dwardu
GitHub user dwardu opened a pull request: https://github.com/apache/cordova-js/pull/67 Fixed "WARNING: file name src\ubuntu\platform.js is missing the license header" during compile You can merge this pull request into a Git repository by running: $ git pull https://github.co

Re: Consolidating the Distribution of Platforms & Plugins

2014-03-28 Thread Andrew Grieve
- I *don't* think platforms should be made explicit dependencies of CLI for the same reason we don't want every plugin to be an explicit dependency. - Fetch to be replaced by "npm cache add" - Moving plugins (and platforms) to npm has the advantage of us not having to maintain them, and I npm now h

Re: [DISCUSS] Release 3.5.0

2014-03-28 Thread Andrew Grieve
>From what I understand of the changes, it should work fine to do a 3.4.1 and just leave the JS as is. On Thu, Mar 27, 2014 at 8:00 PM, Marcel Kinard wrote: > It feels like trying to tag only iOS as 3.5.0 before the other platforms > is going to create a mess when it comes time to release the o

RE: Consolidating the Distribution of Platforms & Plugins

2014-03-28 Thread Jonathan Bond-Caron
To be 'code clear' about it, fetch() can be simplified down to: var things = cordova.findThings(userCommand) ~ var things = ['platform.android','platform.ios', 'org.apache.cordova.console']; // async fetching of things cordova_lib.fetch(things) .then(function(thingByType){ // install flo

[GitHub] cordova-plugin-file-transfer pull request: Update FileTransferProx...

2014-03-28 Thread TNKSoftware
GitHub user TNKSoftware opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/25 Update FileTransferProxy.js Support download & upload progress callback(such as Android and iOS) You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-mobile-spec pull request: CB-6372 Port createmobilespec fr...

2014-03-28 Thread cmarcelk
GitHub user cmarcelk opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/54 CB-6372 Port createmobilespec from bash to node. This is a straight-up port with no change in function. This is the initial work. Improvements and expansion can come later. You can

Re: Many CLI tests failing

2014-03-28 Thread David Kemp
I have just verified the plugman state and on my machine I get the same 7 errors that Medic gets. All of them are related to version comparisions. On Thu, Mar 27, 2014 at 6:17 PM, Steven Gill wrote: > All tests seem to be passing now. > > Medic is showing plugman tests failing after the tizen

Re: ios-deploy issues

2014-03-28 Thread David Kemp
Thanks! I have updated Medic and at the moment ios-deploy is working correctly. On Thu, Mar 27, 2014 at 6:29 PM, Shazron wrote: > ios-deploy 1.0.6 published to npm. > https://github.com/phonegap/ios-deploy/releases/tag/1.0.6 > > Added non-interactive, port flags. Removed python wrapper. > > -

[GitHub] cordova-cli pull request: Update xml-helpers.js

2014-03-28 Thread TNKSoftware
GitHub user TNKSoftware opened a pull request: https://github.com/apache/cordova-cli/pull/154 Update xml-helpers.js On Windows Desktop, "Non-whitespace before first tag." error occurs by an old code. You can merge this pull request into a Git repository by running: $ git pull

Re: Consolidating the Distribution of Platforms & Plugins

2014-03-28 Thread Anis KADRI
I say we should On Fri, Mar 28, 2014 at 1:47 AM, Brian LeRoux wrote: > +1 > > > On Thu, Mar 27, 2014 at 7:36 PM, Steven Gill > wrote: > > > Interesting points about plugins. IMO It would be a good amount of work > to > > move plugins over to npm. Definitely worth it for us to continue > discus

[GitHub] cordova-plugman pull request: CB-6344: Specify after which sibling...

2014-03-28 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugman/pull/68 CB-6344: Specify after which sibling to add config-changes in plugin.xml * refactor munges - now they are in a more extensible form (`munge.files[file].parents[parent][index] { xml, count