[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...

2014-03-31 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-39089517 I believe we have ID_CAP_NETWORKING by default https://github.com/apache/cordova-wp8/blob/master/wp8/template/Properties/WMAppManifest.xml#L11

Re: iOS BackupWebStorage Config Preference Default Value

2014-03-31 Thread Michal Mocny
Background: https://issues.apache.org/jira/browse/CB-1561 Back when we split the storage location into three options, there were vocal users that claimed that WebSQL was being used to store user data and should be backed up to cloud. Many apps were not rejected with this setting, not sure if

RE: Consolidating the Distribution of Platforms Plugins

2014-03-31 Thread Jonathan Bond-Caron
On Sat Mar 29 03:11 PM, Brian LeRoux wrote: I think its a great idea. The platforms have a standard interface [1] for which the higher level CLI Node module depends. We could remove our logic for versioning/caching and leave that to npm. We distribute via npm already for the CLI so this is

Re: Consolidating the Distribution of Platforms Plugins

2014-03-31 Thread Anis KADRI
+1 for platforms on npm. -1 for plugins on npm (best way to create a giant mess). On Mon, Mar 31, 2014 at 4:18 PM, Jonathan Bond-Caron jbo...@gdesolutions.com wrote: On Sat Mar 29 03:11 PM, Brian LeRoux wrote: I think its a great idea. The platforms have a standard interface [1] for which

[GitHub] cordova-docs pull request: 3.4.0

2014-03-31 Thread ldeluca
Github user ldeluca commented on the pull request: https://github.com/apache/cordova-docs/pull/199#issuecomment-39098601 @Watabe08 , you should be using crowdin to enter any translations. our project url is: https://crowdin.net/project/cordova --- If your project is set up for it,

Re: Introductions

2014-03-31 Thread Lisa Seacat DeLuca
Welcome, happy to have you Jason! Lisa Lisa Seacat DeLuca Mobile Engineer | t: +415.787.4589 | ldel...@apache.org | | ldel...@us.ibm.com | lisaseacat.com | | From: jason.robitai...@lge.com jason.robitai...@lge.com To: dev@cordova.apache.org dev@cordova.apache.org Date:

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread kieferhagin
GitHub user kieferhagin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/21 Update index.md Using square brackets here insinuates that this function takes an array; in reality, it takes an object. You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39111334 Square brackets are a pretty common notation for optional arguments -- I haven't checked to see whether we're using them that way consistently across

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39114920 Square brackets in JavaScript mean pass an array. While Square brackets in CMD make sense for optional, I wouldn't recommend that notation anywhere near

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39117406 Not just shell commands; other languages with optional parameters use this notation as well. When describing a function, I've seldom seen square

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39117755 (BTW, please show me that I'm wrong here -- I feel much more strongly about clarity than about, say, a UNIX tradition. I'm happy to standardize on

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-03-31 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/155 CB-6377 Handle spaces in paths for cmd related scripts 0. as discussed elsewhere the slice() efforts on process.platform are pointless 1. for .bat, .cmd, and .js/.vbs, we want to use

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-31 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11128647 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos :

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-03-31 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/155#discussion_r11130975 --- Diff: src/superspawn.js --- @@ -60,11 +60,11 @@ exports.spawn = function(cmd, args, opts) { var spawnOpts = {}; var d = Q.defer();

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-6382 platform list: sort output

2014-03-31 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/156 CB-6382 platform list: sort output You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6382 Alternatively you can review

Looking at the new File API pragmatically

2014-03-31 Thread Ian Clelland
The new File plugin has been in the wild now for almost two months now, and it seems to be seeing a lot of real-world use (bug reports are coming in to JIRA almost daily :) ) There have been a lot of bugs fixed, and a fair number of people guided towards new ways of doing things, but there are

Re: Looking at the new File API pragmatically

2014-03-31 Thread Michal Mocny
On Mon, Mar 31, 2014 at 3:39 PM, Ian Clelland iclell...@chromium.orgwrote: The new File plugin has been in the wild now for almost two months now, and it seems to be seeing a lot of real-world use (bug reports are coming in to JIRA almost daily :) ) There have been a lot of bugs fixed, and a

Re: Android File and Camera plugins

2014-03-31 Thread Ian Clelland
I committed this change, btw, and so it should be part of File 1.0.2. (Thanks, Tommy) On Wed, Mar 19, 2014 at 4:37 PM, tommy-carlos williams to...@devgeeks.orgwrote: Temporary is as temporary does. My only expectation of temp files sticking around is a fear that they will stay around

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39139828 I agree it's ugly, and confusing. It should be made clearer that the line is NOT and example, but indeed a function signature. Do we do this

[GitHub] cordova-docs pull request: 5122 platform cl tools

2014-03-31 Thread mike-sierra
Github user mike-sierra closed the pull request at: https://github.com/apache/cordova-docs/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Looking at the new File API pragmatically

2014-03-31 Thread Michal Mocny
On Mon, Mar 31, 2014 at 4:33 PM, Ian Clelland iclell...@chromium.orgwrote: On Mon, Mar 31, 2014 at 4:20 PM, Michal Mocny mmo...@chromium.org wrote: On Mon, Mar 31, 2014 at 3:39 PM, Ian Clelland iclell...@chromium.org wrote: This is ugly, though, and is going to get worse over time, and

[GitHub] cordova-docs pull request: 5122 platform cl tools

2014-03-31 Thread mike-sierra
Github user mike-sierra commented on the pull request: https://github.com/apache/cordova-docs/pull/149#issuecomment-39140370 Sorry about that. Apparently distracted. Must've gone a pull instead. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-cli pull request: CB-6382 platform list: sort output

2014-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Looking at the new File API pragmatically

2014-03-31 Thread Ian Clelland
On Mon, Mar 31, 2014 at 4:33 PM, Ian Clelland iclell...@chromium.orgwrote: On Mon, Mar 31, 2014 at 4:20 PM, Michal Mocny mmo...@chromium.org wrote: On Mon, Mar 31, 2014 at 3:39 PM, Ian Clelland iclell...@chromium.org wrote: This is ugly, though, and is going to get worse over time, and