Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
I believe this is the common case that the function is used for. The way to do it without eval is: 1. Have your app receive the intent. If the app is still starting up, then store it in a variable. 2. When cordova.js runs, have a plugin whose JS runs on start-up via a tag. It would call exec() t

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
On Mon, May 26, 2014 at 2:04 PM, Joe Bowser wrote: > On Mon, May 26, 2014 at 9:59 AM, Andrew Grieve > wrote: > > From: https://issues.apache.org/jira/browse/CB-6746 > > > > Given that you can implement sendJavascript via PluginResults by just > > eval()ing the results, maybe we could just deprec

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
I think the call is used too frequently to have a short deprecation period. Might be one of those leave it @Deprecated forever kind of things. On Mon, May 26, 2014 at 1:36 PM, Marc Weiner wrote: > +1 for deprecation sooner and removal in 4.0. Might as well break > everything at once. Doesn't so

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
This couldn't be done without an API change, so I don't think there's any advantage to it. On Mon, May 26, 2014 at 1:16 PM, Michal Mocny wrote: > Should we write a plugin that must be installed along with cordova-android > that does the suggested "sendJavascript via PluginResults" and swap the

[GitHub] cordova-plugin-statusbar pull request: Added missing import for An...

2014-05-26 Thread dpogue
Github user dpogue closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-statusbar pull request: Added missing import for An...

2014-05-26 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/6#issuecomment-44225839 I believe this has been merged (I see the commit on master) so I'm going to close the PR. --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-wp8 pull request: [CB-5653][WP8] make visible cordova vers...

2014-05-26 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-wp8/pull/35#issuecomment-44220176 Ohh that's a better, I didn't know the possibility of include content during the build. It a cleaner way to do it. Thanks Jesse. --- If your project is set up

[GitHub] cordova-blackberry pull request: CB-6757 Provide useful hint when ...

2014-05-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/158 CB-6757 Provide useful hint when simulator does not seem to know its IP You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/co

[GitHub] cordova-wp8 pull request: [CB-5653][WP8] make visible cordova vers...

2014-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-wp8 pull request: [CB-5653][WP8] make visible cordova vers...

2014-05-26 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/35#issuecomment-44219957 Thanks Martin, but the version is already part of the output VERSION file, it is just not included in the build. This is the same file that is read by the comma

Restore platforms and multi-version CLI

2014-05-26 Thread Gorkem Ercan
I have sent the PRs for restoring (and saving) platforms through CLI. As expected "cordova save platforms" saves the currently installed platforms on the project to the config.xml and "cordova restore platforms" restores them. --shrinkwrap flag also saves the version of the platform config.xml how

[GitHub] cordova-cli pull request: CB-6756 Add save and restore platforms

2014-05-26 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/178 CB-6756 Add save and restore platforms Adds the platforms subcommand for save and restore You can merge this pull request into a Git repository by running: $ git pull https://github.com/go

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Jesse
I think the cycles required for keeping sendJavascript around are probably worthwhile given that otherwise developers might have to resort to loadURL(javascript://) for their special cases. Ultimately, I am much less involved in the Android particulars, so I'll just leave you with an opinion, and

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Axel Nennker
We have plugins that register for a secure element element in Android. >From the plugin.xml file: The activity then starts the main cordova application (with or without newintent

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Ian Clelland
On Mon, May 26, 2014 at 2:58 PM, Joe Bowser wrote: > On Mon, May 26, 2014 at 11:53 AM, Jesse wrote: > > Is the webview method evaluateJavascript [1] still available, callable > from > > the context of a plugin? Or is this somehow hidden? > > It only exists on KitKat, earlier implementations requ

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Joe Bowser
On Mon, May 26, 2014 at 11:53 AM, Jesse wrote: > Is the webview method evaluateJavascript [1] still available, callable from > the context of a plugin? Or is this somehow hidden? It only exists on KitKat, earlier implementations require loadURL(javascript://). > > Personally I think is okay to r

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Jesse
Is the webview method evaluateJavascript [1] still available, callable from the context of a plugin? Or is this somehow hidden? Personally I think is okay to remove the cordova implemented sendJavascript() as long as there is still a way to accomplish the rare but sometimes required bare metal pas

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Joe Bowser
On Mon, May 26, 2014 at 9:59 AM, Andrew Grieve wrote: > From: https://issues.apache.org/jira/browse/CB-6746 > > Given that you can implement sendJavascript via PluginResults by just > eval()ing the results, maybe we could just deprecate the function? And this comment just earned this proposal a -

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Marc Weiner
+1 for deprecation sooner and removal in 4.0. Might as well break everything at once. Doesn't sound like it's in the spirit of Cordova. On Mon, May 26, 2014 at 1:16 PM, Michal Mocny wrote: > Should we write a plugin that must be installed along with cordova-android > that does the suggested "se

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Michal Mocny
Should we write a plugin that must be installed along with cordova-android that does the suggested "sendJavascript via PluginResults" and swap the implementation on native-side? -Michal On Mon, May 26, 2014 at 1:02 PM, Ian Clelland wrote: > It's probably a good candidate for removal in the 4.0

Re: Issue building docs :(

2014-05-26 Thread Andrew Grieve
Also - just updated the docs.cordova.io redirect. On Mon, May 26, 2014 at 10:22 AM, Andrew Grieve wrote: > Thanks Shaz, I had started to run bin/generate and then forgot about it. > It's finished now, so I've rebased and uploaded the non-en 3.5.0 docs. > > > On Sun, May 25, 2014 at 12:27 AM, Sha

Re: Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Ian Clelland
It's probably a good candidate for removal in the 4.0 branch, if we really don't want to support it On Mon, May 26, 2014 at 12:59 PM, Andrew Grieve wrote: > From: https://issues.apache.org/jira/browse/CB-6746 > > It's a fairly common anti-pattern to use sendJavascript() to communicate > with na

Android: Deprecate WebView.sendJavascript()?

2014-05-26 Thread Andrew Grieve
From: https://issues.apache.org/jira/browse/CB-6746 It's a fairly common anti-pattern to use sendJavascript() to communicate with native side. Not sure if deprecating the call is the right move, but wanted to pitch the idea. There are multiple pitfalls: 1. As in the bug, it doesn't work if cordov

Re: [Blackberry10] View logging events without the IDE

2014-05-26 Thread Martin Gonzalez Glez
Yes agree, Momentics simplifies the process of course. This process it's aimed in the case that only Webworks it's available, or for those who does not use Momentics. Thanks Bryan. 2014-05-26 8:12 GMT-05:00 Bryan Higgins : > Thanks for the write-up Martin! > > For most Cordova devs WebInspector

Web Audio API Android Issues

2014-05-26 Thread Jono Brandel
I'm using cordova 3.4.1-0.1.0 on my Mac and was able to build my project successfully and deploy to iOS. However when I try to build on Android I get errors that the Web Audio API does not exist (no reference — vendor prefixed or not — can be found to AudioContext). I'm using a MotoX and am succes

Re: Issue building docs :(

2014-05-26 Thread Andrew Grieve
Thanks Shaz, I had started to run bin/generate and then forgot about it. It's finished now, so I've rebased and uploaded the non-en 3.5.0 docs. On Sun, May 25, 2014 at 12:27 AM, Shazron wrote: > Docs uploaded. > > > On Sat, May 24, 2014 at 9:50 AM, Shazron wrote: > > > Tagged 3.5.0 docs and I

Re: [Blackberry10] View logging events without the IDE

2014-05-26 Thread Bryan Higgins
Thanks for the write-up Martin! For most Cordova devs WebInspector will be sufficient, but for plugin development or performance tuning it can be useful to view the native device logs. Momentics IDE greatly simplifies this process. Just click "Open Device Logs" from the "Target Navigator" On Fr

Documentation generation process

2014-05-26 Thread Andrey Kurdumov
Hi guys, I start verifying how my translation to Russian look at the actual site and found that sometimes links does not displayed on the same place where they are in English docs. Initially I start from http://cordova.apache.org/docs/ru/edge/guide_platforms_index.md.html where almost all links a