GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-coho/pull/60
CB-8214 COHO. Rename windowsphone to wp8 to be consistent
https://issues.apache.org/jira/browse/CB-8214
You can merge this pull request into a Git repository by running:
$ git pull https:
I vote +1:
* confirmed sigs & hashes with `coho verify-archive`
* verified sha1s match tags with `coho verify-tags`
have Apache-compatible licenses
* recreated archives to ensure contents match release candidate
smime.p7s
Description: S/MIME cryptographic signature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-coho/pull/59#issuecomment-67995102
:+1: Btw, there is similar place here
https://github.com/apache/cordova-coho/blob/master/src/create-release-bug.js#L93
---
If your project is set up for it, you ca
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-coho/pull/59
CB-8212 update coho verify-archive refs for SetUpGpg
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-coho cb_8212
Alternativ
Github user developernotes commented on the pull request:
https://github.com/apache/cordova-lib/pull/82#issuecomment-67992415
Hi @sgrebnov
In my case I need to create two additional `ItemGroup` elements within the
`.csproj` file. The first being a `ProjectReference` to a Man
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/40#issuecomment-67986933
Actually, looks like this was already merged. closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/40#issuecomment-67986845
Going to merge this in and it can be iterated on once checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-js/pull/85#issuecomment-67986342
It looks like this change was made, or this was already merged. Please
close this pull request. Thanks!
---
If your project is set up for it, you can reply to this em
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-js/pull/86#issuecomment-67986272
Although the code here is minor, I think this should be packaged as a
plugin rather than adding it to cordova-js. It's possible that some platforms
might already suppo
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/127#issuecomment-67985332
What's the motivation for this? One nice thing about how it currently works
is that the addition of the function() wrapper doesn't change line number, nor
column num
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/128#discussion_r7969
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -219,6 +258,47 @@ ConfigParser.prototype = {
},
/**
+ * Find
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-67983624
Definitely some good changes here, but do have some feedback before this
goes any further:
1. There are many style-only changes in this commit. Style-only changes
+1
Verified archive
On Dec 23, 2014 8:01 AM, "Andrew Grieve" wrote:
> +1
>
> * coho verify-archive worked fine for me.
> * Verified sha1s match tags with `coho verify-tags`
> * Verified archive contents via extracting & diff -r
>
> Only thing I saw at all awry is that RELEASENOTES.md has an entr
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/135#issuecomment-67972984
Thanks for the patch! Looks like in a couple of other files, we do:
./cordova/config.js:else if (uri.protocol && uri.protocol[1]
==':') return uri.hre
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/82#issuecomment-67972921
HI @developernotes ,
CB-7441 was closed as invalid since it is basically a hack to modify those
files using element. Could you please describe your needs in more
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugman/pull/81
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
This is now merged. Woot!
What I did:
- Looked through the code (skimmed mostly)
- Ran bin/genjs
- Ran npm test
- spot-checked output within public/test
Everything looks great to me! Only things I did:
- Squashed into a single commit
- Removed trailing whitespace
- Added a couple of missing semicol
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
+1
* coho verify-archive worked fine for me.
* Verified sha1s match tags with `coho verify-tags`
* Verified archive contents via extracting & diff -r
Only thing I saw at all awry is that RELEASENOTES.md has an entry for 4.0.0
in the tgz, but not in master within the repo (forgot to commit?)
On M
Github user developernotes commented on the pull request:
https://github.com/apache/cordova-lib/pull/82#issuecomment-67964820
Hi @sgrebnov
I am running into the same issue with `.csproj` files that you did with
`.jsproj` files. As you have closed this pull request, I'm curio
GitHub user Athorcis opened a pull request:
https://github.com/apache/cordova-lib/pull/135
allow to add a plugin from drive different from c:
This commit alllow to add plugin from a drive different from c: when using
bash under Windows.
Therefore the following command now work:
GitHub user fernandoofj opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/22
Update index.md for help people to use plugin in WP8
Sometimes the js files are not included in csproj file. You need to add
manually to work.
You can merge this pull
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/114
CB-8203 Fixed wp8 platform reference in createmobilespec
https://issues.apache.org/jira/browse/CB-8203
You can merge this pull request into a Git repository by running:
$ git pul
41 matches
Mail list logo
