Github user glasser commented on the pull request:
https://github.com/apache/cordova-lib/pull/184#issuecomment-78213647
Awesome, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/commit/242a8d760267379e963977de68d49aae96928562#commitcomment-10136020
Nice catch, @glasser.
I just sent a PR to fix this :
https://github.com/apache/cordova-lib/pull/184
---
If your project
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/184
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
FOO' should fail when no variables specified.
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
Github user glasser commented on the pull request:
https://github.com/apache/cordova-lib/commit/242a8d760267379e963977de68d49aae96928562#commitcomment-10135110
Triggering this error doesn't seem to cause the `cordova plugin add`
command to exit with a non-zero value.
---
If your pro
Github user ryanmc2033 commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/20#issuecomment-78200291
Can someone tell me how to remove the black line that appears on the bottom
of the status bar when using this plugin? I am trying to get the status ba
Thanks, Gorkem.
I reviewed the changes.
Overall, things look good to me, however I left some comments.
Thanks,
Mefire
-Original Message-
From: Gorkem Ercan [mailto:gorkem.er...@gmail.com]
Sent: Monday, March 9, 2015 4:49 PM
To: dev
Subject: Re: Deprecating the feature tag
Here is an e
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-78182770
Thanks for raising this issue, @gorkem. I just pushed some changes to
handle `dependent` plugins and only save `top-level` plugins in config.xml.
---
If your projec
Please review and vote on the release of this Camera plugin release.
Release issue: https://issues.apache.org/jira/browse/CB-8646
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8646/
The packages were published from their corresponding git tags:
cor
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
Repos ready to be released have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645
The package was published from its corresponding gi
Had a quick look, looks great!
@purplecabbage
risingj.com
On Tue, Mar 10, 2015 at 3:09 PM, Mark Koudritsky wrote:
> I've created a pull request with changes across cordova-lib that should
> make it much easier to consolidate the platform specific code in
> cordova-lib to reduce duplication and
I've created a pull request with changes across cordova-lib that should
make it much easier to consolidate the platform specific code in
cordova-lib to reduce duplication and maybe eventually move this code to
the platforms repos.
https://github.com/apache/cordova-lib/pull/183
Feedback is welcome.
GitHub user kamrik opened a pull request:
https://github.com/apache/cordova-lib/pull/183
CB-8595 Merge platforms.js from cordova & plugman CB-8595
Till now we had two separate places for platform specific code
cordova/metadata exposed via cordova/platforms.js
plugman/platform
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78153037
I put the change behind a flag called `--copywww`. By default `www` is
linked, and if the flag is passed, then it is copied instead.
---
If your project is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#issuecomment-78152746
Thanks for the contribution.
I did some cleanup in general of this code, some per comments from
@robpaveza
( 6b1e72c6312f1c449d15a11be4
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/181#issuecomment-78151471
Let's wait until PR #182 goes in !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/181#issuecomment-78150199
Not until PR #182 goes in !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/181#issuecomment-78145771
Please close this PR if #182 supersedes this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Added an issue: https://issues.apache.org/jira/browse/CB-8643
On Mon, Mar 9, 2015 at 11:31 PM, Tommy Williams wrote:
> None here. I still have an iOS 6 device, but can't say I test on it much.
> On 10 Mar 2015 5:21 pm, "Shazron" wrote:
>
>> 0. https://developer.apple.com/support/appstore/
>>
>>
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/133#issuecomment-78142420
Also https://issues.apache.org/jira/browse/CB-8643
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26157156
--- Diff: buildbot-conf/master.cfg ---
@@ -17,37 +17,75 @@
# Absolute or relative path to buildbot per-project configureations.
# For local Bu
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26154261
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/182#discussion_r26153119
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -308,8 +301,8 @@ module.exports = function plugin(command, targets,
opts) {
};
functio
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/133#issuecomment-78121299
Thanks for the reminder, I've posted a new thread to get consensus:
http://callback-dev.markmail.org/thread/c7c3iiuy6hr54pf6
---
If your project is set up for it, y
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152048
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152050
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26151823
--- Diff: bin/checkout.js ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env node
+
+// node dependencies
+var fs = require('fs');
+
+// exter
The main issue is that this isn't documented anywhere, and this is
necessary for people to use a Third Party WebView. Also, why didn't you
bother updating the test with the new API?
On Mon, Mar 9, 2015 at 5:19 PM Andrew Grieve wrote:
> Here's an example:
>
> ConfigXmlParser parser = new ConfigX
Hey Georgi,
I left some comments on your PR. Only big thing is how you populate
preferences, otherwise LGTM. My other comments are mostly nits.
Thanks,
-Rob
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Monday, March 9, 2015 7:25 AM
To: Georgi Alexandro
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26150341
--- Diff: cordova-lib/spec-cordova/project-metadata-apis.spec.js ---
@@ -0,0 +1,85 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-78115338
I noticed that the plugin metadata that is exposed is the id and version
number. What if the source is a git URL - how is that exposed?
---
If your project is set
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149994
--- Diff: src/wp/SplashScreen.cs ---
@@ -68,27 +77,52 @@ public override void OnInit()
if (!WasShown)
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149807
--- Diff: src/wp/SplashScreen.cs ---
@@ -163,5 +190,30 @@ public void hide(string options = null)
story.Begin();
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149711
--- Diff: src/wp/SplashScreen.cs ---
@@ -163,5 +190,30 @@ public void hide(string options = null)
story.Begin();
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26149508
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user cwarden commented on the pull request:
https://github.com/apache/cordova-lib/commit/6fd8e23fda5658d5c8d43ecfb6016edb6f713265#commitcomment-10125851
In cordova-lib/src/plugman/platforms/ios.js:
In cordova-lib/src/plugman/platforms/ios.js on line 188:
This broke `cord
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26144383
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
///
public clas
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26143818
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26143768
--- Diff: src/wp/SplashScreen.cs ---
@@ -68,27 +77,52 @@ public override void OnInit()
if (!WasShown)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26140093
--- Diff: tests/tests.js ---
@@ -28,10 +28,11 @@
exports.defineAutoTests = function () {
// constants
-
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26139904
--- Diff: tests/tests.js ---
@@ -305,7 +306,17 @@ exports.defineAutoTests = function () {
// - 'http://examp
Thanks Steve!
On Tue, Mar 10, 2015 at 12:18 PM, Steven Gill
wrote:
> Alright. Punted for now. Too early to talk about this.
> On Mar 10, 2015 8:56 AM, "Michal Mocny" wrote:
>
> > I don't think this is a good idea, but I'm open to be convinced.
> >
> > However, cannot we punt this discussion for
I don't think this is a good idea, but I'm open to be convinced.
However, cannot we punt this discussion for now? The current phase 1
rollout does not actually have us installing plugins to node_modules, so
really this is an independant feature request to create a new workflow. I
don't see the b
Alright. Punted for now. Too early to talk about this.
On Mar 10, 2015 8:56 AM, "Michal Mocny" wrote:
> I don't think this is a good idea, but I'm open to be convinced.
>
> However, cannot we punt this discussion for now? The current phase 1
> rollout does not actually have us installing plugins
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/210#discussion_r26135743
--- Diff: doc/platform.txt ---
@@ -42,6 +45,8 @@ Syntax
. url to a git repository containing
a platform
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69
CB-8641 Fixed occasional test failures
https://issues.apache.org/jira/browse/CB-8641
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/179#issuecomment-78072159
Tested, works fine. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugman/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/180#issuecomment-78062068
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-cli/pull/210#issuecomment-78062091
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/210#discussion_r26124764
--- Diff: doc/platform.txt ---
@@ -29,11 +29,14 @@ Manage project platforms
Syntax
:
-||
+||
---
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/210#discussion_r26124768
--- Diff: doc/platform.txt ---
@@ -42,6 +45,8 @@ Syntax
. url to a git repository containing
a platform
GitHub user zalun opened a pull request:
https://github.com/apache/cordova-plugins/pull/20
Notification plugin with firefox OS support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zalun/cordova-plugins notification-plugin
Alt
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26114588
--- Diff: cordova-plugin-medic/www/jasmine-jsreporter.js ---
@@ -1,214 +0,0 @@
-/*
- This file is part of the Jasmine JSReporter projec
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26114383
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26113846
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26112764
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26112558
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26111200
--- Diff: buildbot-conf/master.cfg ---
@@ -17,37 +17,75 @@
# Absolute or relative path to buildbot per-project configureations.
# For
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-ios/pull/133#issuecomment-78029460
Thanks for the feedback, Shazron. I wasn't sure how it should be brought
up, I just wanted to get the ball rolling somehow.
---
If your project is set up for it,
Github user dmitriy-barkalov commented on the pull request:
https://github.com/apache/cordova-medic/pull/37#issuecomment-78027552
I am unable to start any platform build using this configuration. I am
getting this error on `cloning configured repos` step on all builds:
```
fata
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78015632
The idea LGTM, but i would prefer not to remove linking of www at all, just
hide it behind a corresponding option (`--linkwww` for example). There is
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26104912
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
63 matches
Mail list logo
