[GitHub] cordova-medic pull request: CB-9011 Adding Buildbot feature suppor...

2015-05-18 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/54#discussion_r30573168 --- Diff: buildbot-conf/cordova-repos.json --- @@ -1,457 +1,285 @@ { "mobile-chrome-apps": { -"codebase": "chrome", -

[CI] Medic Report

2015-05-18 Thread Dmitry Blotsky
Hi list, Here are some points of interest regarding the CI: - Android build is flaky, and it’s an emulator + machine issue; for now, please look at the builds that finish as “Warnings” (i.e. the orange ones) - We caught and fixed two build-breaking bugs in the last two weeks - Windows Phone 8 tur

Licensing Questions How and what to do, Are there any guidelines.

2015-05-18 Thread Mathias Johansson
Hi All, I am sorry if I am posting this to the wrong list. But I haven't been able to find the info via Google or on stackoverflow. I am currently developing a cross-platform application using Intel XDK which uses Cordova. - How / and what do I need to do in the application to apply with the

[GitHub] cordova-medic pull request: CB-9011 Adding Buildbot feature suppor...

2015-05-18 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/54 CB-9011 Adding Buildbot feature support in medic Following are notable changes. - Added commit-triggered builds. - Now using Buildbot Codebases for each codebase; no more download

[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-05-18 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-103346345 @agrieve could you please have another look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-camera pull request: major refactor : readability

2015-05-18 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/96 major refactor : readability aliased lots of the super long namespaces so we aren't fighting past with the 100 char line. You can merge this pull request into a Git repository b

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-05-18 Thread jhurliman
Github user jhurliman commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103265287 My apologies, I'm not doing active development with Cordova at the moment and don't have time to setup a dev environment to work on this. Can someone pl

[GitHub] cordova-lib pull request: CB-8965 copy cordova-js-src into platfor...

2015-05-18 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-js pull request: CB-8441 add platforms as devdeps and cord...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Dearly Departed

2015-05-18 Thread Jesse
To the committers who have recently been reassigned, and will be committing less over the next while, please release any jira issues you have assigned to yourselves, and if possible/relevant, add some comments to help whoever comes after you. TIA Cheers, Jesse @purplecabbage risingj.com

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-05-18 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103238194 bump Any update on this? Running into issues because of it. Thanks --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-plugin-vibration pull request: index.md(jp)

2015-05-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/32#issuecomment-103237444 Hi @HirofumiTamori Is this still valid? If so, please fix the merge conflicts. ありがとう --- If your project is set up for it, y

[GitHub] cordova-plugin-vibration pull request: CB-7216 API audit for vibra...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-osx pull request: Fix OS X, see CB-7143

2015-05-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-103236074 I'm waiting on @onflapp for this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/75#issuecomment-103224344 LGTM! Let's get this in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-docs pull request: CB-8486 improve packaging docs

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-windows pull request: CB-9025 Removes 'prepare' logic call...

2015-05-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/77#issuecomment-103223739 Please fix the jshint error and let's get this in today - before the next Cordova-windows release. --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-8486 improve packaging docs

2015-05-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/290#issuecomment-103222639 Great docs! Let's get this in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-lib pull request: CB-9023 Add support to specify a build c...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: build.json file

2015-05-18 Thread Steven Gill
I am generally hesitant to add more config files to cordova projects. I would rather see us converge to package.json as the de facto config file over config.xml in the future. Aside from that, I do see the value in having a build.json file which contains sensitive information (certs, passwords, si

[GitHub] cordova-docs pull request: CB-8486 improve packaging docs

2015-05-18 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-docs/pull/290 CB-8486 improve packaging docs Improved the docs for windows packaging by giving some example You can merge this pull request into a Git repository by running: $ git pull https://github.c

[GitHub] cordova-lib pull request: CB-9030: Shell scripts can't execute whe...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: add sugar platform

2015-05-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/98#issuecomment-103145410 #83 has more info. Please rebase+update or close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

build.json file

2015-05-18 Thread Nikhil Khandelwal
I want to bring this to the attention of everyone that I have added a build.json for specifying signing parameters for different platforms as part of cordova build. Here are the design principles I used: - build.json should be used over config.xml for specifying build time behavior (as

[GitHub] cordova-lib pull request: add sugar platform

2015-05-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/98#issuecomment-103136263 It's unclear what's the intent of this PR. In any case, this PR needs updating. We should consider closing this one and re-opening one if needed. --- If your proje

Cordova 5 - Android and 3rd party libraries question

2015-05-18 Thread Maffett, Ian
I’ve run into a few issues with Cordova CLI5, Android 4 and libraries/frameworks. I will try to explain below, but the issue appears to be related to the dependency section in build.gradle and each librarie’s build.gradle file. We’ve developed a plugin to enable expansion files on Android. It

Cordova-js update

2015-05-18 Thread Steven Gill
I have a pull request [1] ready for cordova-js which adds platforms as dev dependencies and uses the previously moved cordova-js-src from the platform repos instead of src/platform. I moved existing platform specific js into cordovajs/src/legacy-exec to use in cases where released platforms don't h

RE: Breaking changes in cordova-windows@>3.8.2

2015-05-18 Thread Vladimir Kotikov (Akvelon)
Do we have a way to check if specific platform supports current CLI/LIB version? AFAIK there is two places, where tag is supported (project's config.xml and plugin's plugin.xml) but none of them suits to our case. But if I wrong, could you please point me to docs or code where this check exists

[GitHub] cordova-js pull request: CB-8441 add platforms as devdeps and cord...

2015-05-18 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-js/pull/112 CB-8441 add platforms as devdeps and cordova-js-src to build cordova.js * Use legacy-exec/platform when cordova-js-src is not available * updated grunt workflow to not require platformVer

[GitHub] cordova-lib pull request: CB-8965 copy cordova-js-src into platfor...

2015-05-18 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/221 CB-8965 copy cordova-js-src into platform_www and update browserify workflow to use it You can merge this pull request into a Git repository by running: $ git pull https://github.com/

[GitHub] cordova-lib pull request: CB-8965 copy platform specific js into p...

2015-05-18 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: Cb 8965

2015-05-18 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: Cb 8965

2015-05-18 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/220 Cb 8965 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib CB-8965 Alternatively you can review and apply these cha