[GitHub] cordova-wp8 pull request: assign async task to var to prevent warn...

2015-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-wp8 pull request: assign async task to var to prevent warn...

2015-05-19 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-wp8/pull/81 assign async task to var to prevent warning You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-wp8 CB-8964 Alterna

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103709357 Hmm you're right on seperation of concerns. Having a new solution file isn't really a good solution to this problem. I think I have a workaround that will work w

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-coho/pull/78#issuecomment-103703256 Awesome addition! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30661704 --- Diff: src/merge-pr.js --- @@ -0,0 +1,62 @@ + +var flagutil = require('./flagutil'); +var optimist = require('optimist'); +var shelljs

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30661261 --- Diff: src/merge-pr.js --- @@ -0,0 +1,62 @@ + +var flagutil = require('./flagutil'); +var optimist = require('optimist'); +var shelljs

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30661140 --- Diff: src/merge-pr.js --- @@ -0,0 +1,62 @@ + --- End diff -- missing header --- If your project is set up for it, you can reply to

Re: Cordova 5 - Android and 3rd party libraries question

2015-05-19 Thread Andrew Grieve
Hmm, I've written a couple of other plugins that don't suffer from multiple dex exceptions. I forget the first, but the second is: https://github.com/MobileChromeApps/cordova-plugin-background-app So, I think there might be something else going on besides the plugin's lib having a dependency on C

[GitHub] cordova-coho pull request: Renamed Create release branch step to p...

2015-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Update setting-up-gpg.md

2015-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Renamed Create release branch step to p...

2015-05-19 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/79 Renamed Create release branch step to prepare release You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-35

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103682040 Does it make sense to continue to support `cordova platform add windows` in this case? or should we add `cordova platform add windows10` ? I for one pre

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103681444 UAP and SharedProj dont play nice on VisualStudio13. My understanding is, in order to have backwards compat we need to split UAP from SharedProj. This provides a

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/78#issuecomment-103679656 Is this the 'new' way, or is this a temporary step on the road to 10? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...

2015-05-19 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/78 CB-9045 Create a new solution for Win10/Dev15 Currently in dev12 solution we're using shared project. The shared project has some logic that doesn't work with windows10 projects. (This is du

Re: Behavior of --copy-from

2015-05-19 Thread Raymond Camden
Ok, so I filed a bug about it not copying misc files (https://issues.apache.org/jira/browse/CB-9041). I can understand wanting to skip platforms and plugins, but I think there are plenty of valid reasons to copy everything else. In my case, I built a hook for Visual Studio Code so I can do a build

[GitHub] cordova-plugin-media-capture pull request: Cancel of Image Capture...

2015-05-19 Thread aroberson
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/36 Cancel of Image Capture Causes App to Crash. App crashes due to an undefined file object being returned on cancel. You can merge this pull request into a Git repository by ru

Re: Behavior of --copy-from

2015-05-19 Thread Michal Mocny
And for yet more context, I think this is because we did not want to import plugins / platforms, and so did not just cp -R the whole thing, but perhaps thats a better strategy. Up to you now :) -Michal On Tue, May 19, 2015 at 12:07 PM, Michal Mocny wrote: > Just checked: > https://github.com/a

Re: Behavior of --copy-from

2015-05-19 Thread Michal Mocny
Just checked: https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L179 Seems config.xml isn't required. We import the nested www/ if it exists, and same for config.xml merges and hooks. I would not expect any files/folders outside of www to be copied, dotfiles or

Re: Licensing Questions How and what to do, Are there any guidelines.

2015-05-19 Thread Shazron
GPL? Apache Cordova is licensed under the Apache v 2.0, license, hence the prefix "Apache" in Apache Cordova. Here are "guidelines" since almost all of Cordova is licensed under Apache v2.0 (esp. the "I'M NOT A LAWYER. WHAT DOES IT ALL MEAN?" section) http://www.apache.org/foundation/license-faq.h

Re: Behavior of --copy-from

2015-05-19 Thread Michal Mocny
The *intention* of copy-from / link-to is to import either (a) a web project, or (b) another cordova project. We used to check for (b) I think by the existence of a config.xml and www/ (note: double check config.xml is required). If that check passes, we copy those two nested contents only (I thi

Re: build.json file

2015-05-19 Thread Michal Mocny
2 cents: A pattern I was introduced to recently was simply to use: .SECRET.json For any sensitive settings for any file, and: .SAMPLE.json To provide dummy data for any SECRET files as a source of documentation. Then, in your .gitignore, you can just ignore **/*.SECRET.*, and write a single he

RE: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release

2015-05-19 Thread Nikhil Khandelwal
Our customers are asking for this fix. I would love to see this released soon. Steve: Let me know if I can help with releasing this. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, May 15, 2015 12:05 PM To: dev@cordova.apache.org Subjec

Re: Dearly Departed

2015-05-19 Thread Michal Mocny
:D On Mon, May 18, 2015 at 7:01 PM, Jesse wrote: > To the committers who have recently been reassigned, and will be committing > less over the next while, please release any jira issues you have assigned > to yourselves, and if possible/relevant, add some comments to help whoever > comes after y

[GitHub] cordova-browser pull request: Switch from adm-zip to archiver.

2015-05-19 Thread arlaneenalra
Github user arlaneenalra closed the pull request at: https://github.com/apache/cordova-browser/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

Re: Behavior of --copy-from

2015-05-19 Thread Raymond Camden
I definitely can't recreate the "end up with a folder that isn't a project" but --copy-from does seem to ignore files it doesn't recognize. I filed a bug for it. On Tue, May 19, 2015 at 6:07 AM, Raymond Camden wrote: > No, what seems to happen to me is: > > If I copy-from a directory that has a w

Re: Behavior of --copy-from

2015-05-19 Thread Raymond Camden
No, what seems to happen to me is: If I copy-from a directory that has a www folder in it, then it is treated as the *root* of the new project and a proper Cordova folder is not created. If I copy-from a dir that does NOT have a www folder in it, it is treated as the www folder of a new project.

[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...

2015-05-19 Thread digiclick74
Github user digiclick74 commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103426643 Sorry but I don't have the permissions to merge the pull request. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...

2015-05-19 Thread timuric
Github user timuric commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103402749 Can you please merge this request, otherwise plugin does not install on android --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-plugin-camera pull request: Retain ascpect ratio in resize...

2015-05-19 Thread benjamineberle
Github user benjamineberle commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/32#issuecomment-103396867 Re-opened --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30577529 --- Diff: src/merge-pr.js --- @@ -0,0 +1,62 @@ + +var flagutil = require('./flagutil'); +var optimist = require('optimist'); +var shelljs

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30577435 --- Diff: src/merge-pr.js --- @@ -0,0 +1,62 @@ + +var flagutil = require('./flagutil'); +var optimist = require('optimist'); +var shelljs

[GitHub] cordova-plugin-camera pull request: Retain ascpect ratio in resize...

2015-05-19 Thread benjamineberle
GitHub user benjamineberle reopened a pull request: https://github.com/apache/cordova-plugin-camera/pull/32 Retain ascpect ratio in resizeImageBase64 The docs say aspect ratio is constant when using targetWidth and targetHeight at the same time. You can merge this pull request into

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30577315 --- Diff: src/executil.js --- @@ -46,13 +47,16 @@ function execHelper(cmdAndArgs, silent, allowError) { gitCommitCount++; }

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30577302 --- Diff: src/repo-update.js --- @@ -129,8 +129,9 @@ function *updateRepos(repos, branches, noFetch) { yield gitutil.gitChec

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30577291 --- Diff: src/gitutil.js --- @@ -43,12 +43,14 @@ exports.tagExists = function*(tagName) { } exports.retrieveCurrentBranchName = function*

[GitHub] cordova-coho pull request: Add command to merge PR

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/78#discussion_r30576714 --- Diff: src/main.js --- @@ -172,11 +177,6 @@ module.exports = function() { var command; var argv = optimist .usage(usage

[GitHub] cordova-plugin-camera pull request: Retain ascpect ratio in resize...

2015-05-19 Thread benjamineberle
Github user benjamineberle closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-windows pull request: CB-9025 Removes 'prepare' logic call...

2015-05-19 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/77#issuecomment-103380436 @nikhilkh, @muratsu Please take a look again, since #75 has been merged before this, so i had to resolve conflict and update build config applying logic

[GitHub] cordova-medic pull request: CB-9011 Adding Buildbot feature suppor...

2015-05-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/54#discussion_r30574601 --- Diff: buildbot-conf/cordova-repos.json --- @@ -1,457 +1,285 @@ { "mobile-chrome-apps": { -"codebase": "chrome", -

Re: Behavior of --copy-from

2015-05-19 Thread Dmitry Blotsky
Hi Raymond, The semantics of “--copy-from” are: copy the passed path in place of the new project's “www” directory, which “cordova create” seems to obey. Is that not what happened in your case? However, the failure to copy over paths that start with “.” looks like a bug to me. Unless someone sa