[GitHub] cordova-plugin-contacts pull request: Android - Filter search: Con...

2015-05-27 Thread jonmikelm
GitHub user jonmikelm opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/64 Android - Filter search: Contacts with informed phone number only When searching for all the contacts in Android, by default all the google contacts(Gmail history, etc...) are

[GitHub] cordova-windows pull request: CB-8889 Persist app/package name and...

2015-05-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/87 CB-8889 Persist app/package name and product ID during platform update You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-windows pull request: CB-9073 Fixes build error when path ...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/85#issuecomment-105848653 Yup, this still works fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Android - Filter search: Con...

2015-05-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/64#issuecomment-105879343 Please document the new param and create a JIRA ticket also. This should potentially be done on other platforms also. --- If your project is

[GitHub] cordova-plugin-contacts pull request: Android - Filter search: Con...

2015-05-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/64#issuecomment-105878860 Can we make the option param name simply 'hasPhoneNumber'? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31134829 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-plugin-file pull request: CB-8844 Increased timeout for as...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Do we have a commits mailing list?

2015-05-27 Thread Carlos Santana
Make sense Dmitry On Wed, May 27, 2015 at 3:28 AM Dmitry Blotsky dblot...@microsoft.com wrote: The Buildbot announcements that make it to the list signify critical issues: build machines going down. I will look into making the emails go to the machine owner. Kindly, Dmitry On May 26,

Re: Best place to browse plugins

2015-05-27 Thread Tommy-Carlos Williams
+1 On 26 May 2015, at 21:44, Carlos Santana csantan...@gmail.com wrote: I would like to see plugin.cordova.io be a page easy to search and filter cordova plugins just like gulp [1], grunt [2], yeoman [3] and bower [4] [1]: http://gulpjs.com/plugins [2]: http://gruntjs.com/plugins [3]:

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 (wp8) Handle ex...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-windows pull request: CB-9074 Fixed incorrect parameter er...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31134853 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] cordova-mobile-spec pull request: CB-9066 Fixed crash on Windows

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-motion pull request: CB-8842 Return cached v...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/226#issuecomment-105921556 Yeah, reworking tests will be painful. BTW, i'm still wondering that so small number of tests is became failing. --- If your project is set up for it,

[GitHub] cordova-mobile-spec pull request: CB-8843 Fixed mobilespec tests t...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-mobile-spec pull request: CB-9052 Fixed failure when creat...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-geolocation pull request: CB-8845 Pended tests for ...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: Android - Filter search: Con...

2015-05-27 Thread jonmikelm
Github user jonmikelm commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/64#issuecomment-105889981 I changed the param name and readme file. I have also opened a JIRA but I'm not sure if I've filled the form correctly. It's the first I open...

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: CSP question

2015-05-27 Thread Raymond Camden
On Tue, May 26, 2015 at 7:12 PM, Steven Gill stevengil...@gmail.com wrote: Thanks for the blog post Ray! Link for the lazy http://www.raymondcamden.com/2015/05/25/important-information-about-cordova-5 Thanks - I was the lazy one for forgetting to post it back here. ;) --

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2015-05-27 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/228 CB-8627: Only update fetch.json when plugins are successfully installed. CB-8627: Only update fetch.json when plugins are successfully installed. You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2015-05-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-106026407 This change makes sure that the fetch.json file only gets updated with plugin information once the plugin has been successfully installed. fetch.json is considered

[GitHub] cordova-windows pull request: CB-9073 Fixes build error when path ...

2015-05-27 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/85#issuecomment-106028591 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media pull request: CB-9079 Increased timeout for p...

2015-05-27 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/55#issuecomment-106011984 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-windows pull request: Draft implementation for Unified pla...

2015-05-27 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/84#discussion_r31144880 --- Diff: template/cordova/Api.js --- @@ -0,0 +1,54 @@ + +/*jshint node: true*/ + +var path = require('path'); + +var buildImpl

[GitHub] cordova-plugin-media pull request: CB-9079 Increased timeout for p...

2015-05-27 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/55 CB-9079 Increased timeout for playback tests https://issues.apache.org/jira/browse/CB-9079 This is a fix for failing tests on

[GitHub] cordova-windows pull request: Draft implementation for Unified pla...

2015-05-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/84#discussion_r31137262 --- Diff: template/cordova/Api.js --- @@ -0,0 +1,54 @@ + +/*jshint node: true*/ + +var path = require('path'); + +var

Re: Best place to browse plugins

2015-05-27 Thread Kerri Shotts
+1 I’ve used both Gulp Yeoman’s search, and prefer both to NPM (although it’s not difficult to be better than NPM’s search). I also think close association with the brand and site are important. For those users who don’t know about Node NPM yet, it’s quickly apparent that there’s a large

[GitHub] cordova-docs pull request: CB-8900: Documentation for the platform...

2015-05-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/292#discussion_r31159121 --- Diff: docs/en/edge/platform_plugin_versioning_ref/index.md --- @@ -0,0 +1,82 @@ +--- +license: Licensed to the Apache Software Foundation

[GitHub] cordova-docs pull request: CB-8900: Documentation for the platform...

2015-05-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/292#discussion_r31158760 --- Diff: docs/en/edge/platform_plugin_versioning_ref/index.md --- @@ -0,0 +1,82 @@ +--- +license: Licensed to the Apache Software Foundation

Couple questions

2015-05-27 Thread Murat Sutunc
Hey everyone, I've two simple questions: 1) How do we close github issues? There are PRs that are older than a year and there's no need for having them around. In fact having them around for so long can be discouraging to new contributors. 2) If we want to add pictures to plugin

Re: Couple questions

2015-05-27 Thread Shazron
1) We can't directly. Some have resorted to updating some doc (maybe we need a dummy doc) and add the text (closes #XX) where XX is the PR number. 2) Not sure about the breakage part. But I would put it under docs for sure. On Wed, May 27, 2015 at 9:40 AM, Murat Sutunc mura...@microsoft.com

Re: Couple questions

2015-05-27 Thread Victor Sosa
Hello Murat. I can speak on Translation side. No, adding changing images won't break the translated documents. In fact, in translation process, we take the text blocks only, not multimedia, HTML format or whatsoever. Lisa can correct me though. On Wed, May 27, 2015 at 11:40 AM Murat Sutunc

[GitHub] cordova-docs pull request: CB-8900: Documentation for the platform...

2015-05-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/292#discussion_r31158610 --- Diff: docs/en/edge/platform_plugin_versioning_ref/index.md --- @@ -0,0 +1,82 @@ +--- +license: Licensed to the Apache Software Foundation

[GitHub] cordova-docs pull request: CB-8900: Documentation for the platform...

2015-05-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/292#discussion_r31158552 --- Diff: docs/en/edge/platform_plugin_versioning_ref/index.md --- @@ -0,0 +1,82 @@ +--- +license: Licensed to the Apache Software Foundation

[GitHub] cordova-docs pull request: CB-8783 Document iOS specific callback ...

2015-05-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/276#issuecomment-106066558 By silent consensus -- I'll just add the all option for iOS and document it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-coho pull request: Update tools-release-process.md

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: Series of improvements to the list-pull...

2015-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Support needed

2015-05-27 Thread julio cesar sanchez
This isn't a support mail, you should ask on stackoverflow. But that's hiw the plugin works, it launchs the camera app, if you don't want that you can create your own plugin. I've seen ine that shows the camera inside of a canvas element, as far as I know, that's the only way to show the camera

Re: Building cordova.js on first build

2015-05-27 Thread Andrew Grieve
Certainly would be nice to have the create scripts generate cordova.js in the same way CLI does. Maybe have the create script call into cordova-js? Would it make sense in this case to have platforms depend on cordova-js, rather than the other way around? Having cordova-js depend on platforms

RE: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-27 Thread Nikhil Khandelwal
Joe, Andrew, Ian, Michael: I'm hoping one of you can plug this documentation gap since you are most knowledgeable about changes from Cordova-android 3.7 to 4.0. Thanks, Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Friday, May 15, 2015 4:23 PM To:

Support needed

2015-05-27 Thread Mohamed Ali
Hello Team, I'm developing a crossplatform application using cordova (Visual studio hyprid multi device application). I need to open the camera inside of the application without launching the camera application. Requirements: 1- Back camera should be opened in a frame

Re: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-27 Thread Joe Bowser
The bigger issue is the question of what is a public API. Android used public docs to delineate between public and private APIs and I think we should do the same, mostly because I want to draw a line between what we can and can't support and not have everything in third-party tests break because

[GitHub] cordova-coho pull request: Update tools-release-process.md

2015-05-27 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/81 Update tools-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-36 Alternatively you can

[Vote] Tools Release May 27th

2015-05-27 Thread Steven Gill
Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9087/ The packages were

RE: Support needed

2015-05-27 Thread Ryan J. Salva
Mohamed, If you check the documentation available for the Camera plugin at https://github.com/apache/cordova-plugin-camera#options, you'll find an option for cameraDirection. - cameraDirection: Choose the camera to use (front- or back-facing). The default is

Re: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-27 Thread Andrew Grieve
I'm wary of creating any docs for the Java APIs, since I think they will inevitably get out of sync with the real code (it's hard enough getting code comments to match the code). I think some beefed up Javadocs might be nice, but I think plugin developers should just read through Cordova's code

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

2015-05-27 Thread uareurapid
GitHub user uareurapid opened a pull request: https://github.com/apache/cordova-plugin-media/pull/56 fix record and play NullPointerException I´ve came across a use case where i always get a NullPointerException: 1 - Start recording audio file 2 - Stop recording 3

[GitHub] cordova-lib pull request:

2015-05-27 Thread wildabeast
Github user wildabeast commented on the pull request: https://github.com/apache/cordova-lib/commit/60f19284ce5b8e265e2348ba88907fc47af42007#commitcomment-11395737 In cordova-lib/src/plugman/platforms/android.js: In cordova-lib/src/plugman/platforms/android.js on line 150: This

Re: Do we have a commits mailing list?

2015-05-27 Thread Dmitry Blotsky
The Buildbot announcements that make it to the list signify critical issues: build machines going down. I will look into making the emails go to the machine owner. Kindly, Dmitry On May 26, 2015, at 8:28 PM, Carlos Santana csantan...@gmail.com wrote: Agree dev@ being noisy with build bot

[GitHub] cordova-plugin-camera pull request: CB-8054 Support taking picture...

2015-05-27 Thread ekambarrao
Github user ekambarrao commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-105808283 muratsu, I have footer in the page where I activate the camera, camera has cancel but it is going under the footer. How can I control the size of the