Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build it again and now it's all good. - Serge Op do 4 jun. 2015 om 07:54 schreef Serge Huijben : > I must say that restoring state in the webview ha

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
I must say that restoring state in the webview has not been a problem for me. admittedly our app is only for Android 4.1 (sdk 16) and higher. In our app we save state all the time using localstorage, and I do know exaxtly where the user was at --> he was taking a picture or selecting one from the g

Cordova edge docs update needed

2015-06-03 Thread Nikhil Khandelwal
I was looking to make a blog post for the Windows release, but I could not find the docs for Windows 10 on the edge version of the published docs website. How often are the docs published to the edge website? This commit introduced the change to the cordova-docs repo: 50f1d88 - Merge branch 'ma

RE: [VOTE] Partial Tools Release June 1, 2015

2015-06-03 Thread Nikhil Khandelwal
+1. I verified the following: * Confirmed signature with `coho verify-archive` * Manually verified tags * Verified it picks up the 3.7.2 version of Android. Thanks, Nikhil -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, June 2, 2015 9:41 AM To: 'dev

RE: [DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Mefire O .
Thanks guys, Looks like we can go ahead with this. I've sent 2 PRs that add deprecation warnings to both CLI and cordova-lib : - https://github.com/apache/cordova-cli/pull/214 - https://github.com/apache/cordova-lib/pull/234 Thanks, Mefire -Original Message- From: Shazron [mailto:sha

RE: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Dan Polivy
Interesting, thanks for the history, Joe and Serge. I do probably agree with you, Joe, that this won't work well as it'll be hard to restore the DOM to the correct state. I can say that for my app, it's pretty unlikely to get exactly back to where you started. In prior versions of Cordova (pre-

[GitHub] cordova-android pull request: Grant Lollipop permission requests

2015-06-03 Thread vbraun
Github user vbraun commented on the pull request: https://github.com/apache/cordova-android/pull/178#issuecomment-108617961 Corresponding Apache JIRA issue: https://issues.apache.org/jira/browse/CB-9115 --- If your project is set up for it, you can reply to this email and have your r

Re: App

2015-06-03 Thread Shazron
Hi Paulo, Congrats for the app! Please consult http://www.apache.org/foundation/marks/contact#swag On Wed, Jun 3, 2015 at 1:42 PM, Paulo Lelis wrote: > Hello, my name is Paulo, and I'm developing an app in Apache Cordova and Im > gonna introduce this app at my college. We are going to make shirt

[GitHub] cordova-android pull request: Grant Lollipop permission requests

2015-06-03 Thread vbraun
GitHub user vbraun opened a pull request: https://github.com/apache/cordova-android/pull/178 Grant Lollipop permission requests This patch overrides onPermissionRequest so that getUserMedia can be used inside the browser. Since a hybrid app has to request permissions anyway

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-03 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/234 CB-9114: Log deprecation message when --usegit flag is used CB-9114: Log deprecation message when --usegit flag is used Moving towards using `cordova platform add git-url#my

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

2015-06-03 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/214 CB-9114: Deprecating the --usegit flag CB-9114: Deprecating the --usegit flag Background: http://apache.markmail.org/message/7cf5zovxcgdxgwa2?q=ommenjik+list:org%2Eapache%2Eincubat

App

2015-06-03 Thread Paulo Lelis
Hello, my name is Paulo, and I'm developing an app in Apache Cordova and Im gonna introduce this app at my college. We are going to make shirts with the name of the app and we want to use the logo and the name of Apache Cordova in this shirt, can we make this ?

Re: [DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Shazron
+1 On Wed, Jun 3, 2015 at 12:35 PM, Brian LeRoux wrote: > +1 > > On Wed, Jun 3, 2015 at 12:17 PM, Jesse wrote: > > > +1 > > and using real git urls (should?) lets you install from > branches/tags+other > > git repos and not just the mystical magical one that lives behind the > flag. > > > > @pu

Re: [DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Brian LeRoux
+1 On Wed, Jun 3, 2015 at 12:17 PM, Jesse wrote: > +1 > and using real git urls (should?) lets you install from branches/tags+other > git repos and not just the mystical magical one that lives behind the flag. > > @purplecabbage > risingj.com > > On Wed, Jun 3, 2015 at 12:05 PM, Steven Gill > w

RE: [DISCUSS] cordova-serve

2015-06-03 Thread Tim Barham
I'd like to start moving forward with this. I've started a cordova-discuss proposal for further discussion here: https://github.com/cordova/cordova-discuss/issues/8 My preference (if it weren't for the negatives) would be that it live within the cordova-lib repo - it seems overkill to have a ne

Re: [DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Jesse
+1 and using real git urls (should?) lets you install from branches/tags+other git repos and not just the mystical magical one that lives behind the flag. @purplecabbage risingj.com On Wed, Jun 3, 2015 at 12:05 PM, Steven Gill wrote: > Sounds like a good candidate for deprecation to me. I used

Re: [DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Steven Gill
Sounds like a good candidate for deprecation to me. I used --usegit in the old nightly builds I had running. But the custom git urls would work just as well. -Steve On Wed, Jun 3, 2015 at 11:44 AM, Mefire O. wrote: > Hi list, > I think it's high time we deprecate the -usegit flag, whose intent

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108581410 Great! I will proceed with the release! On Wed, Jun 3, 2015 at 11:36 AM, Tim Barham wrote: > Sounds good regarding the discuss thread, @omef

[DISCUSS] Deprecate --usegit flag

2015-06-03 Thread Mefire O .
Hi list, I think it's high time we deprecate the -usegit flag, whose intent was to provide apache git repos as an alternative source to install platforms (the default being npm). A little bit of background : In the past, there were two main sources from which to install a platform. You could fe

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Joe Bowser
This has been a problem since we started, and there's no solution to it because there's no reliable way to restore state on a WebView. We have tried in the past, and failed miserably. I'm extremely skeptical that this would even work, since this apparently failed Travis. That said, if it does, e

Proposal: Cordova Plugin Search

2015-06-03 Thread Murat Sutunc
Hey everyone, I've seen couple folks mention the idea of turning plugins.cordova.io into a Gulp & Yeoman style search page on dev mailing list. I've gone ahead and created a proposal for how we might potentially tackle this problem. Please see the extended discussion at GH: https://github.com/c

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108567398 Sounds good regarding the discuss thread, @omefire and @stevengill. In the mean time, I've pushed this so we can proceed with the tools release. --- If your proj

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108554655 Ok. I've track down and handled that weird Zlib error you were seeing @stevengill. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108549545 @stevengill, starting the discuss thread on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-03 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-108547543 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-03 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/13#issuecomment-108547570 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-03 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108544922 You make a good point @omefire. Lets kick up a discuss thread to depreciate --usegit and if we decide to move forward, we will want to have it around for about 6

RE: [VOTE] 4.0.0 Windows Release

2015-06-03 Thread Nikhil Khandelwal
The vote has been closed. The results are: Positive binding votes: - Sergey Grenov - Jesse - Nikhil Khandelwal No negative votes. The vote has passed. I will shortly follow the next steps for the release. Thanks, Nikhil -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@micro

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Mefire O .
Interesting fix, Serge. A question comes to mind: - Since it seems like this issue affects all android plugins that call other intents, won't we have to do this for all of them? Is there a way we can leverage your PR and maybe come up with a general solution ? Maybe fit the boilerplate code (sta

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
what I did to solve this is add a check for callbackcontext, If that is null save the incoming parameters. if (this.callbackContext == null) { this.savedRequestCode = requestCode; this.savedResultCode = resultCode; this.savedIntent = intent; } els

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-06-03 Thread thedarkman123
Github user thedarkman123 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-108289054 Is there a way to config this for phonegap build? really need to play multiple sounds in my phonegap app --- If your project is set up for it, you c