[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31790359 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,13 +192,65 @@ module.exports = { var xcBuildConfiguration =

Translation QA tools

2015-06-05 Thread Andrey Kurdumov
1) I submit pull request to the cordova-docs which add one more QA tool for the translation. I verify that after translation, HTML files generated from Markdown should have same structure of HTML DOM. Sometimes, mostly due to inserting additional lines by CrowdIn the resulting files become

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

2015-06-05 Thread galexandrov
GitHub user galexandrov opened a pull request: https://github.com/apache/cordova-lib/pull/236 Change cordova-lib to execute plugin hooks without the need of Cordova project structure Change cordova-lib to execute plugin hooks defined in plugin.xml without the need of Cordova

Re: Translation QA tools

2015-06-05 Thread Victor Sosa
Hi Andrey, I'll work on that today or tomorrow, depending on the workload on back today On Fri, Jun 5, 2015 at 1:28 AM Andrey Kurdumov kant2...@googlemail.com wrote: 1) I submit pull request to the cordova-docs which add one more QA tool for the translation. I verify that after translation,

[GitHub] cordova-plugin-media pull request: iOS: Add support for playing no...

2015-06-05 Thread shauntrennery
Github user shauntrennery commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-109308647 I would love this added to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109377681 It's certainly a common JavaScript recommendation to always use strict equality / inequality operators so you don't accidentally get an invalid match because of

[GitHub] cordova-plugin-camera pull request: Major refactor

2015-06-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-109397387 This is amazing, thank you for this. This seems to fix: https://issues.apache.org/jira/browse/CB-5942 although I'm not sure how exactly (side

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-109396714 It'd be a great idea to convert the scripts from 'shell' to 'node'. bash is hard to follow and make sense of. --- If your project is set up for it, you can

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109379851 Great answer(s)! I was actually partially trolling @ligaz, our style-guide does say be strict so it's all good. Are there any side effects of the change

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109383817 Heh - I tried turning on the JSHint rule in `cordova-lib` just for kicks. 150 hits :). --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-05 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/235#discussion_r31840378 --- Diff: cordova-lib/src/platforms/PlatformApi.js --- @@ -0,0 +1,365 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-lib pull request: CB-9127 Implements cordova-serve module.

2015-06-05 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/238 CB-9127 Implements cordova-serve module. This takes code and functionality from `cordova-browser` and `cordova-lib` (`cordova serve` command) and combines it in a single module. There's a

[GitHub] cordova-plugin-camera pull request: Major refactor

2015-06-05 Thread dieppe
GitHub user dieppe opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/101 Major refactor Hi there, We needed access to the metadata which lead to asynchronous operations. We took the opportunity to refactor most of the plugin logic. Hopefully it's

RE: [CI] Builds failing due to cordova lib version bump

2015-06-05 Thread Dmitry Blotsky
Fixed and deployed to CI server. Builds are now back to their former green glory. Having said that, should we set up a nightly job to check our released code? That is, have a build that gets *nothing* from master - everything only from NPM - and see that tests and builds still pass on it.

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-05 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/235#issuecomment-109401910 Looks great! The need to duplicate common code like ConfgiParser in cordova-android is a bit annoying and is bound to generate some versioning confusion. But

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31841226 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-app-hello-world pull request: Useless change

2015-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31843167 --- Diff: src/cli.js --- @@ -226,7 +227,9 @@ function cli(inputArgs) { downstreamArgs.push('--' + flag); }

Re: [CI] Builds failing due to cordova lib version bump

2015-06-05 Thread Jesse
Love it! +1000 @purplecabbage risingj.com On Fri, Jun 5, 2015 at 10:43 AM, Dmitry Blotsky dblot...@microsoft.com wrote: Fixed and deployed to CI server. Builds are now back to their former green glory. Having said that, should we set up a nightly job to check our released code? That is,

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-109396260 Does it make sense to convert any of these scripts to node instead of 'shell'? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-mobile-spec pull request: CB-8927 Add media to cspMeta and...

2015-06-05 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/127#issuecomment-109399489 @muratsu Can you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109339921 Using !== instead of != --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9126 Fix ios pbxproj' resources paths...

2015-06-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/237 CB-9126 Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment [Jira issue with details](https://issues.apache.org/jira/browse/CB-9126) You can merge this pull

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109357001 It is not better. Just trying to follow cordova-lib coding guidelines requirements ! --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread ogoguel
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31824683 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,13 +192,65 @@ module.exports = { var xcBuildConfiguration =

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109353274 Why is it better? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-cli/pull/215 CB-9121 Add support for build configuration to be specified using the CLI You can merge this pull request into a Git repository by running: $ git pull

RE: [VOTE] Partial Tools Release June 1, 2015

2015-06-05 Thread Nikhil Khandelwal
LGTM. +1 Thanks, Nikhil -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Thursday, June 4, 2015 3:44 PM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 If we need a blog post for this one, I have one here for review:

[GitHub] cordova-coho pull request: Add a verbose switch to see all the com...

2015-06-05 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-coho/pull/83 Add a verbose switch to see all the commands that coho is issuing You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31853903 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/215#issuecomment-109439886 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31854039 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-webos pull request: CB-6715 [webOS] Upgrade webOS Cordova ...

2015-06-05 Thread JayCanuck
GitHub user JayCanuck opened a pull request: https://github.com/apache/cordova-webos/pull/3 CB-6715 [webOS] Upgrade webOS Cordova project tool/template Fully compatible with all LG webOS products, including SmartTVs and wearables. Uses the ares-sdk-tool included in the TV SDK to

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-cli/pull/215#issuecomment-109445919 :+1: apart from the one small thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-js pull request: CB-9129 [webOS] Add webOS platform to cor...

2015-06-05 Thread JayCanuck
GitHub user JayCanuck opened a pull request: https://github.com/apache/cordova-js/pull/114 CB-9129 [webOS] Add webOS platform to cordova-js Re-adds webOS as a platform option for the cordova-js build system. Also includes a minor system detection fix in the legacy section that is

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31853375 --- Diff: doc/build.txt --- @@ -18,6 +19,9 @@ all/the specified platforms. --emulator . Deploy to an emulator

[GitHub] cordova-cli pull request: CB-9121 Add support for build configurat...

2015-06-05 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/215#discussion_r31844480 --- Diff: src/cli.js --- @@ -226,7 +227,9 @@ function cli(inputArgs) { downstreamArgs.push('--' + flag); }

Sticky Channels

2015-06-05 Thread Jesse
I have been looking into unifying launchParameters across devices so that all cordova apps can get some context of how they were launched/activated. This includes everything from a url/protocol launch in another app, to a touch on a notification (toast,local,push,... ) My intent was to add a

[GitHub] cordova-lib pull request: CB-8052: [webOS] Update cordova-lib for ...

2015-06-05 Thread JayCanuck
GitHub user JayCanuck opened a pull request: https://github.com/apache/cordova-lib/pull/239 CB-8052: [webOS] Update cordova-lib for webOS support Allows for Cordova CLI and Plugman to work with webOS in the Cordova project environment. Naturally it relies on

[GitHub] cordova-webos pull request: CB-6715 [webOS] Upgrade webOS Cordova ...

2015-06-05 Thread JayCanuck
Github user JayCanuck commented on the pull request: https://github.com/apache/cordova-webos/pull/3#issuecomment-109457194 Oh and I should add that once this get merged, someone will need to register cordova-webos to npm as it's not there currently. --- If your project is set up for

Cordova Meetup/Beerup at WWDC?

2015-06-05 Thread Carlos Santana
I will be in SF this week starting Sunday for WWDC, somehow I was able to get a ticket thru IBM ;-) I will be there Sunday to Friday, if anyone wants to meet to talk, hack, eat or drink let me know -- Carlos Santana

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2015-06-05 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-109485385 As I general design point, I don't like the idea of breaking the `save_fetch_metadata()` call out so it needs to be called separately, for two reasons:

RE: Proposal: Cordova Plugin Search

2015-06-05 Thread Murat Sutunc
Got some updates on this proposal! I've prepared a live demo on: http://people.apache.org/~muratsu/ Please visit the webpage and let me know what you think! Thanks, Murat -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Wednesday, June 3, 2015 11:41 AM To: