[GitHub] cordova-coho pull request: CB-8214 COHO. Rename windowsphone to wp...

2015-06-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-coho/pull/60#issuecomment-111987098 Looks good :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/214#discussion_r32484109 --- Diff: doc/platform.txt --- @@ -5,7 +5,10 @@ Synopsis Manage project platforms add plat-spec [...].. add specified

[GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...

2015-06-15 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-wp8/pull/83 Remove `ecosystem:cordova` keyword from package.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-wp8

Re: [GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...

2015-06-15 Thread Jesse
merge it! @purplecabbage risingj.com On Mon, Jun 15, 2015 at 5:46 PM, nikhilkh g...@git.apache.org wrote: GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-wp8/pull/83 Remove `ecosystem:cordova` keyword from package.json You can merge this pull

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/234#discussion_r32483383 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) { }

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-15 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-coho/pull/85#issuecomment-112294287 Wow! @TimBarham this looks great! I will keep testing and playing around with it. But I'd say merge it in. We can make fixes where needed as they come up.

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/234#discussion_r32484031 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) { }

[GitHub] cordova-plugin-file-transfer pull request: Fixed Browser to set wi...

2015-06-15 Thread aroberson
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/89 Fixed Browser to set withCredentials flag on XMLHttpRequest object to allow cookies to be used You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...

2015-06-15 Thread devpaul
Github user devpaul commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-112295207 Hi, I was wondering if this was going to be reviewed soon. I'm receiving content uris for some media types on a Nexus 5 - 5.1 and I am hoping this could

[VOTE] Cordova Serve 0.1.2 release

2015-06-15 Thread Tim Barham
Please review and vote on this Cordova Serve Release by replying to this email. Release issue: https://issues.apache.org/jira/browse/CB-9181 Package has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9181/ I have uploaded the package to npm under the RC tag for

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#issuecomment-112255281 Duke, I did not do that on purpose as I wanted to keep it as close to possible to the original functionality. I can make the change.

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
Github user aroberson closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-docs pull request: CB-9034 Improve reporting errors in tra...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-15 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/234#issuecomment-112177005 https://github.com/apache/cordova-cli/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

2015-06-15 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/214#issuecomment-112176978 Related PR : https://github.com/apache/cordova-lib/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

2015-06-15 Thread uareurapid
Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112163607 Is the repo alive or is just a bot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: Proposal: Cordova Plugin Search

2015-06-15 Thread Murat Sutunc
Before I went ahead with the new page I've spent some time thinking about ways to improve our current search page (http://plugins.cordova.io/#/search?search=camera). The new site (http://people.apache.org/~muratsu/) isn't that big of a departure from the old one but has couple new UEX ideas.

Query regarding CSS

2015-06-15 Thread Mehta, Ruchit
Hello, I am using Cordova to build a hybrid mobile application. I am using my custom css files in it for styling.But it is not working,I am not getting any styling when I build and install my app.Will it work only for jquery mobile CSS? Please give me some direction. Thanks Regards,

[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112186148 Thanks @ogoguel! A couple of things need fixing - I'll merge this once they're sorted. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-cli pull request: CB-9171 Support Variables with =

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Dmitry WFH

2015-06-15 Thread Dmitry Blotsky
Hi all, I’m not feeling any better, so I’ll remain at home today and work from here. Will call in for sprint planning. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r32458071 --- Diff: cordova-lib/spec-plugman/install-browserify.spec.js --- @@ -46,6 +46,7 @@ var install = require('../src/plugman/install'),

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r32458159 --- Diff: cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml --- @@ -0,0 +1,18 @@ +?xml version=1.0 encoding=UTF-8? + +

Re: Dmitry WFH

2015-06-15 Thread Dmitry Blotsky
Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all. :/ On Jun 15, 2015, at 12:38 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, I’m not feeling any better, so I’ll remain at home today and work from here. Will call in for sprint planning. Kindly, Dmitry

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r32458351 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...

2015-06-15 Thread aroberson
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/106#issuecomment-112257930 I would like this pull to be approved as I am having the same issues that are fixed here. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112212662 Fixed requiredVariables Fixed whitespace in plugin.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Should files in cordova-lib/templates have license headers?

2015-06-15 Thread Jesse
What specific files? The problem that I have is with adding license headers to template files is that it *may* imply that the developer's app must be APL 2.0, these typically are 'sample' files and the user is expected to change them ... but expecting them to remove a license header as their first

Re: Should files in cordova-lib/templates have license headers?

2015-06-15 Thread Shazron
I believe we had this exact discussion regarding our app-hello-world. Ultimately we added it in: https://github.com/apache/cordova-app-hello-world/blob/master/www/index.html On Mon, Jun 15, 2015 at 2:21 PM, Jesse purplecabb...@gmail.com wrote: What specific files? The problem that I have is

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread dukex
Github user dukex commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469454 --- Diff: www/browser/FileTransfer.js --- @@ -231,7 +236,9 @@ FileTransfer.prototype.download = function(source, target, successCallback,

Re: Dmitry WFH

2015-06-15 Thread Jesse
Get well soon! @purplecabbage risingj.com On Mon, Jun 15, 2015 at 1:01 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all. :/ On Jun 15, 2015, at 12:38 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, I’m not

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread aroberson
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88 Add Browser support for using Cookies Added a property for browser to set the withCredentials flag on the XMLHttpRequest for upload and download You can merge this pull

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread ogoguel
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r32466926 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-plugin-file-transfer pull request: Add Browser support for...

2015-06-15 Thread dukex
Github user dukex commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/88#discussion_r32469314 --- Diff: www/browser/FileTransfer.js --- @@ -121,6 +122,9 @@ FileTransfer.prototype.upload = function(filePath, server, successCallback,

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

2015-06-15 Thread mattdsteele
Github user mattdsteele commented on the pull request: https://github.com/apache/cordova-ios/pull/138#issuecomment-112217556 Hi folks, I'm trying this out - looks really slick! I had one question: this produces a signed `.app` file. What's the best way to convert it to an

Re: Dmitry WFH

2015-06-15 Thread Steven Gill
Hope you feel better buddy! On Mon, Jun 15, 2015 at 2:00 PM, Jesse purplecabb...@gmail.com wrote: Get well soon! @purplecabbage risingj.com On Mon, Jun 15, 2015 at 1:01 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Whoop, I sent it to the wrong list. I should lie down. Sorry, y’all.

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112216370 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

2015-06-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/138#issuecomment-112220047 Yes xcrun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

2015-06-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/20#issuecomment-111981249 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Keeping Cordova app open in background all th time

2015-06-15 Thread Jesse
This is a limitation of windows store apps ( which cordova-windows apps are ) You can pin them to the sides to keep them both open, but there are no apis to do this programmatically. Please note, this is a mail list for people who develop/contribute to cordova, not for people who develop apps

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112236890 I believe this is still required, will test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

RE: Should files in cordova-lib/templates have license headers?

2015-06-15 Thread Tim Barham
So... I added the license headers to the checked-in code, but got around the issue you describe by adding logic to strip out the license headers when creating a plugin. See https://github.com/apache/cordova-lib/commit/921dad392a. Tim -Original Message- From: Jesse

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r32479018 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -168,10 +168,19 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-06-15 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112238832 I believe this is still required, will test. Sorry I missed the question before. I don't think this should be needed as already commented by

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-15 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/246#discussion_r32394905 --- Diff: cordova-lib/spec-cordova/save.spec.js --- @@ -0,0 +1,435 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

2015-06-15 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232035 Why does this pull request touch iOS? Can you make it so that it's only Android? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232437 Numerous issues here .. removing whitespace from the diff reveals only minor changes. The changes however do not address the issue as

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-06-15 Thread killswitch
Github user killswitch commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-112232774 This package hasn't been published since before this pull request was merged. Can we get this code published to npm? --- If your project is set up for it, you

[GitHub] cordova-plugin-camera pull request: fix crash when trying to pick ...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: fix broken plugman command to install a...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: Update README.md

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Query regarding CSS

2015-06-15 Thread Jesse
Yes, you can use css. No other requirements exist. I suspect you are modifying things in the wrong place, or not including your css from your index.html Please note, this is a mail list for people who develop/contribute to cordova, not for people who develop apps using cordova. Try asking on

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112240606 Not a bot! Or am I? LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

2015-06-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/138#issuecomment-112240780 This change creates an ipa in addition to .app file by invoking xcrun:

[GitHub] cordova-cli pull request: CB-9171 Support Variables with =

2015-06-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/217#issuecomment-112241310 Nice. and a test too! Keep it up! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [DISCUSS] 5.1.1 Docs Release?

2015-06-15 Thread Steven Gill
docs have been released! On Fri, Jun 12, 2015 at 8:06 AM, Victor Sosa sosah.vic...@gmail.com wrote: Hi Steven. Translations are committed now and I did a quick check on the docs. Translations are there. Could you publish these docs, please? Thanks a lot. On Fri, Jun 12, 2015 at 8:21 AM