[GitHub] cordova-lib pull request: Adds plugman support for the Windows pla...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/251 Adds plugman support for the Windows platform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-plugman-windows

[GitHub] cordova-registry-web pull request: Refactor code

2015-06-19 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/20 Refactor code You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/refactor Alternatively you can

[GitHub] cordova-js pull request: CB 9156 - Move to sibling based platform ...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113683706 @thehuijb Thanks for quickly reworking based on my feedback! I "ported" these into my fork and it seems to be working fine for me at the moment. I did add

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879337 --- Diff: www/Camera.js --- @@ -72,4 +72,28 @@ cameraExport.cleanup = function(successCallback, errorCallback) { exec(successCallback,

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879268 --- Diff: src/android/CameraLauncher.java --- @@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType == SAVEDPHOTOALBUM)) {

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879234 --- Diff: src/android/CameraLauncher.java --- @@ -163,7 +159,19 @@ else if ((srcType == PHOTOLIBRARY) || (srcType == SAVEDPHOTOALBUM)) {

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879192 --- Diff: src/android/CameraLauncher.java --- @@ -124,16 +127,9 @@ public boolean execute(String action, JSONArray args, CallbackContext callbac

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879107 --- Diff: README.md --- @@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when the value of function onFail(message)

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879074 --- Diff: README.md --- @@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when the value of function onFail(message)

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879022 --- Diff: README.md --- @@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when the value of function onFail(message)

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879001 --- Diff: README.md --- @@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when the value of function onFail(message)

[GitHub] cordova-coho pull request: Add a verbose switch to see all the com...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-wp8 pull request: Remove `ecosystem:cordova` keyword from ...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-registry-web pull request: Updated the look and feel of th...

2015-06-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/18#issuecomment-113672827 @cpsloal Please close this PR as it's been subsumed by #19. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...

2015-06-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/19#issuecomment-113672308 LGTM. Feel free to improve this stylistic changes I mentioned later - Merging this one in. --- If your project is set up for it, you can reply to this em

Re: [VOTE] Plugins Release June 17th, 2015

2015-06-19 Thread Steven Gill
Bump! On Wed, Jun 17, 2015 at 6:06 PM, Steven Gill wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-9192 > > The plugins have been published t

Re: [CI] Weekly Update

2015-06-19 Thread Dmitry Blotsky
@Steve: It’s really just a nice-to-have in the long-term: all CI in one place. They’re fine where they are right now though. Buildbot just runs on our own hardware, and we can control our slave environments more than those of Travis and AppVeyor. Also we don’t need to administer two extra accoun

[GitHub] cordova-browser pull request: CB-9221 Update 'cordova run browser'...

2015-06-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/12#issuecomment-113660968 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [CI] Weekly Update

2015-06-19 Thread Jesse
Steve, travis+appveyor are about running platform tests while buildbot is running all the plugin tests as well. Dmitry, can you elaborate on the specifics of the path-length issue? Is it one platform in particular? My team is hiring! @purplecabbage risingj.com On Fri, Jun 19, 2015 at 2:36 PM, S

[GitHub] cordova-browser pull request: Update 'cordova run browser' command...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/12 Update 'cordova run browser' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-b

[GitHub] cordova-lib pull request: Updates 'cordova serve' command to use c...

2015-06-19 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/250 Updates 'cordova serve' command to use cordova-serve module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-us

Re: [CI] Weekly Update

2015-06-19 Thread Steven Gill
Quick question, why don't keep travis + appveyor as well as build bot? I don't see the reason to remove that functionality. On Fri, Jun 19, 2015 at 2:27 PM, Dmitry Blotsky wrote: > Hi all, > > CI has been doing pretty well this week. Some notable things are: > - We’re hitting scaling issues (a

[CI] Weekly Update

2015-06-19 Thread Dmitry Blotsky
Hi all, CI has been doing pretty well this week. Some notable things are: - We’re hitting scaling issues (a buffer of 70+ pending builds happened a few times this week) - We’re still waiting on INFRA-9811 and INFRA-9678 for PR-triggered builds Next uses for the CI that are impeded by the scaling

[GitHub] cordova-android pull request: Fixed printing flavored versions

2015-06-19 Thread oNaiPs
GitHub user oNaiPs opened a pull request: https://github.com/apache/cordova-android/pull/184 Fixed printing flavored versions Current code never prints anything because .has() is not used correctly You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-06-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/84#issuecomment-113594895 Thanks. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-registry-web pull request: CB-9219 Added filters to search...

2015-06-19 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/19 CB-9219 Added filters to search, support for multiple words, localize… … download count and other css changes You can merge this pull request into a Git repository by running:

[GitHub] cordova-docs pull request: CB-9128 Russian translation for the 5.1

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-splashscreen pull request: CB-7964 Add cordova-plug...

2015-06-19 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-113439475 I'm getting `10:53:31.345 uncaught exception: module cordova/confighelper not found1 ` using Cordova 5.1.1 --- If your project is set up for it, you

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

2015-06-19 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-113429801 Yeah, on iOS the user agent change applies to all the webviews, maybe it should be restored after closing the inappbrowser --- If your project

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-06-19 Thread SunboX
GitHub user SunboX opened a pull request: https://github.com/apache/cordova-wp8/pull/84 Added the XHR upload attribute Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs/Web

[GitHub] cordova-docs pull request: CB-9128 Russian translation for the 5.1

2015-06-19 Thread kant2002
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/294 CB-9128 Russian translation for the 5.1 I verified all links in the translation. Docs ready to be released. You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-19 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113403640 thanks @dpolivy, that's exactly the kind of review I was looking to get. --- If your project is set up for it, you can reply to this email and