change to cordova-plugin-console

2015-07-08 Thread Axel Nennker
Hi, this commit https://github.com/apache/cordova-plugin-console/commit/d58f218b9149d362ebb0b8ce697cf403569d14cd#diff-53f390d375398624afe1cfe1125f42bfR36 moved the common code from the platforms up one level into the common space in plugin.xml. Please revert this change. On Android this change

Re: [iOS 4.x] cordova-plugin-whitelist deficiencies

2015-07-08 Thread Shazron
FYI, we get to revisit this whitelist stuff again for iOS 9 with it's Application Transport Security (ATS): https://developer.apple.com/library/prerelease/ios/technotes/App-Transport-Security-Technote/index.html#//apple_ref/doc/uid/TP40016240 Should be relatively simple -- convert access tags to

[GitHub] cordova-lib pull request: CB-9330 Removes 'plugman publish' relate...

2015-07-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/254 CB-9330 Removes 'plugman publish' related functionality See [CB-9330](https://issues.apache.org/jira/browse/CB-9330) for more details. You can merge this pull request into a Git

[GitHub] cordova-plugman pull request: CB-9330 Adds notice about removed pl...

2015-07-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugman/pull/84 CB-9330 Adds notice about removed plugman commands See [CB-9330](https://issues.apache.org/jira/browse/CB-9330) for more details You can merge this pull request into a Git

RE: [DISCUSS] Remove 'plugman publish' functionality from cordova-lib

2015-07-08 Thread Vladimir Kotikov (Akvelon)
Hey, guys. Here is PRs, which removes 'publish' Co. Plugman: https://github.com/apache/cordova-plugman/pull/84 Cordova-lib: https://github.com/apache/cordova-lib/pull/254 Corresponding JIRA: https://issues.apache.org/jira/browse/CB-9330 The next step will be npm and semver update according to

[iOS 4.x] cordova-plugin-whitelist deficiencies

2015-07-08 Thread Shazron
Related: https://issues.apache.org/jira/browse/CB-9329 From the README: https://github.com/apache/cordova-plugin-whitelist The Android whitelist supports allow-navigation, allow-intent and access. The iOS whitelist supports allow-navigation only currently. The docs mention access SHOULD be

RE: [DISCUSS] Dropping the -dev suffix

2015-07-08 Thread Vladimir Kotikov (Akvelon)
Hey, guys. I've found another reason to drop this while testing cordova-lib with updated dependencies (see https://issues.apache.org/jira/browse/CB-9332) It appears, that starting from 4.x.x semver treats prerelease versions in a very different way. For example:

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34163912 --- Diff: template/cordova/lib/deployment.js --- @@ -0,0 +1,275 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34164434 --- Diff: template/cordova/lib/deployment.js --- @@ -0,0 +1,275 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9334 loop on CordovaPlugins befor...

2015-07-08 Thread spirann
GitHub user spirann opened a pull request: https://github.com/apache/cordova-android/pull/195 CB-9334 loop on CordovaPlugins before returning remapped Uri This is a fix for https://issues.apache.org/jira/browse/CB-9334 Because sometimes you need more than one plugin to

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34166637 --- Diff: template/cordova/lib/deployment.js --- @@ -0,0 +1,275 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34167364 --- Diff: template/cordova/lib/package.js --- @@ -113,16 +112,32 @@ function getPackageName(platformPath) { // returns one of available

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34167789 --- Diff: template/cordova/lib/run.js --- @@ -155,7 +155,8 @@ module.exports.help = function () { console.log('

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34168225 --- Diff: template/cordova/lib/deployment.js --- @@ -0,0 +1,275 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

2015-07-08 Thread edades
Github user edades commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119638131 Hi, sorry for write here. I have a problem with this plugin, this interrupt the load of cordova.js, and my page refresh all the time. And this

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34164191 --- Diff: template/cordova/lib/run.js --- @@ -155,7 +155,8 @@ module.exports.help = function () { console.log('

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34166300 --- Diff: template/cordova/lib/package.js --- @@ -113,16 +112,32 @@ function getPackageName(platformPath) { // returns one of available

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34167579 --- Diff: template/cordova/lib/package.js --- @@ -130,58 +145,47 @@ module.exports.findDevice = function (target) { }; // returns

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34168004 --- Diff: template/cordova/lib/target-list.js --- @@ -17,20 +17,21 @@ under the License. */ -var devices =

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34163428 --- Diff: spec/unit/deployment.spec.js --- @@ -0,0 +1,282 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34164096 --- Diff: template/cordova/lib/package.js --- @@ -130,58 +145,47 @@ module.exports.findDevice = function (target) { }; // returns

Re: Introduction

2015-07-08 Thread Paul Contat
Thanks for the feedback! Maybe I could determine in the cordova plugin if there is a browser implementation with “getOriginalSymbol(window, 'navigator.battery');” and return the browser object from navigator.getBattery or return the cordova implementation. I’ll be working on a patch toward that

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34166452 --- Diff: template/cordova/lib/package.js --- @@ -113,16 +112,32 @@ function getPackageName(platformPath) { // returns one of available

Re: [iOS 4.x] cordova-plugin-whitelist deficiencies

2015-07-08 Thread Andrew Grieve
On Wed, Jul 8, 2015 at 4:47 AM, Shazron shaz...@gmail.com wrote: FYI, we get to revisit this whitelist stuff again for iOS 9 with it's Application Transport Security (ATS):

[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...

2015-07-08 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-119692899 Does this have a corresponding JIRA issue? Also, I'm going to talk about this on the dev list before pulling it in. --- If your project is set up for

[Android] Camera Plugin Request

2015-07-08 Thread Joe Bowser
Hey Since for some reason the browser doesn't resolve content URIs anymore, I'm tempted to pull this into Camera. https://github.com/apache/cordova-plugin-camera/pull/93 The problem I have with it is the large amount of code that is being added, and I want some more people to look at it before

Re: [DISCUSS] Cordova-Android 4.0.3 Release

2015-07-08 Thread Joe Bowser
OK, Going to start a new discuss thread for 4.1.0 On Tue, Jul 7, 2015 at 5:49 PM Joe Bowser bows...@gmail.com wrote: We could do a 4.1.0 release, but I don't think I'd say it was overdue. I'm not even sure if there's any real reason to do a 4.1.x release other than cadence, which we stopped

[DISCUSS] Release Cordova-Android 4.1.0

2015-07-08 Thread Joe Bowser
Hey After discussing the release of Cordova-Android 4.0.3, and looking at the commit log on Master, we should probably just do a 4.1.0 release instead. This is a minor release with enough bug fixes to justify it. I'm wondering if there's any reason we shouldn't do a 4.1.0 release? If not, I'll

RE: [DISCUSS] Dropping the -dev suffix

2015-07-08 Thread Nikhil Khandelwal
As a committer working on the master branch using npm link, it has been useful to have '-dev' prefix and do a cordova --version. I vote for (3). Thanks, Nikhil -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Wednesday, July 8, 2015 7:28 AM

Re: [Android] Camera Plugin Request

2015-07-08 Thread Joe Bowser
That makes sense. I'll whitelist the Content URI and see if that resolves the issue. I do think we need something to get real URIs on Android but this seems like the wrong place for it. On Wed, Jul 8, 2015, 1:21 PM Nikhil Khandelwal nikhi...@microsoft.com wrote: I remember seeing a PR, that

RE: [VOTE] Plugins release - cordova-plugin-file-transfer

2015-07-08 Thread Murat Sutunc
+1 * unpacked and tested/verified the changes * ran coho verify-archive -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Tuesday, July 7, 2015 11:25 AM To: dev@cordova.apache.org Subject: [VOTE] Plugins release - cordova-plugin-file-transfer Please

Re: [Discuss] Windows: Removal of Windows 8 from VS 2013 solution (keep it in the VS 2012 solution)?

2015-07-08 Thread Jesse
yes yes yes! Is it sufficient to simply make the win8.1 project the startup project in the 2013 sln? If there are still nags, we can remove the windows8.0 project entirely from the 2013 sln. My team is hiring! @purplecabbage risingj.com On Wed, Jul 8, 2015 at 2:57 PM, Rob Paveza

RE: [Android] Camera Plugin Request

2015-07-08 Thread Nikhil Khandelwal
I remember seeing a PR, that mentioned content:// was not working because of the whitelist plugin not supporting it when '*' was specified and/or because CSP did not include it. That PR and discussion did not go anywhere: https://github.com/apache/cordova-plugin-whitelist/pull/6 I have myself

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119734093 Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [Android] Camera Plugin Request

2015-07-08 Thread Joe Bowser
I just tried it and it doesn't work. I think we should probably adopt this, since I don't have a better solution to this problem. I'll pull it in tomorrow if I don't see any objections. On Wed, Jul 8, 2015 at 1:32 PM Joe Bowser bows...@gmail.com wrote: That makes sense. I'll whitelist the

[GitHub] cordova-lib pull request: CB-9330 Removes 'plugman publish' relate...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/254#discussion_r34200986 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -169,35 +160,6 @@ plugman.commands = { } }); }, - -

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119730497 I see - I can take a stab at updating all the older versions on the svn repo that has our website. --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119734040 I merged this one 2f620e6. I had a typo in my commit message and this PR remained open. Can you please close it? --- If your project is set up for it, you can

[Discuss] Windows: Removal of Windows 8 from VS 2013 solution (keep it in the VS 2012 solution)?

2015-07-08 Thread Rob Paveza
I've been tackling a couple quality-of-life improvements and I've been thinking about this issue. In VS 2012 and 2013, Windows 8 is supported, but in VS 2015, it isn't (you can use VS 2015 to target Windows 8.1 and 10). We have the following projects in our solutions: - Windows 8 - Windows 8.1

[GitHub] cordova-lib pull request: CB-9330 Removes 'plugman publish' relate...

2015-07-08 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/254#discussion_r34204394 --- Diff: cordova-lib/src/plugman/plugman.js --- @@ -169,35 +160,6 @@ plugman.commands = { } }); }, -

[GitHub] cordova-plugin-file pull request: CB-6703cordova-plugin-file

2015-07-08 Thread ghenry22
Github user ghenry22 closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

2015-07-08 Thread ghenry22
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/125 CB-9331 cordova-plugin-file resolves CB-9331, correct the value queried on iOS devices so that free getFreeDiskSpace() returns a valid value instead of always returning 0. You can

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread kant2002
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119465461 Ok, so I drop it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread kant2002
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119465537 To update the file index.js should be distributed to all versions. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2015-07-08 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865 @stevengill @infil00p Any possibility of reviewing this before the next release? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread AndyChenW
GitHub user AndyChenW opened a pull request: https://github.com/apache/cordova-plugin-device/pull/35 add isSimulator for iOS Android device @purplecabbage change pr and property name to isSimulator. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-device pull request: add is_simulator for iOS And...

2015-07-08 Thread AndyChenW
Github user AndyChenW commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792320 https://github.com/apache/cordova-plugin-device/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-device pull request: add is_simulator for iOS And...

2015-07-08 Thread AndyChenW
Github user AndyChenW commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792313 a new pr is created for isSimulator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-08 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r34224410 --- Diff: template/cordova/lib/package.js --- @@ -130,58 +145,47 @@ module.exports.findDevice = function (target) { }; // returns

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119811586 2 other 'offers' device.isVirtual Or the opposite device.isDevice --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...

2015-07-08 Thread kant2002
Github user kant2002 closed the pull request at: https://github.com/apache/cordova-docs/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119809686 Attempting to avoid a semantics argument, I chose to overlook this. do we really need to add 2 properties? iOS simulator IS a simulator. ---

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119813107 Heh, I wasn't wanting to start a semantics argument, just after consistency. My understanding is that the usual terminology is simulator for iOS

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817528 Ah, gotcha. I actually think I like isVirtual better as it sidesteps all the sim/emu discussions. I'll let this pr sit for a bit and see

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119804386 Should this be Emulator rather than Simulator (that's the terminology used elsewhere in Cordova, isn't it? And the typical terminology for Android and

[GitHub] cordova-plugin-device pull request: add isSimulator for iOS Andr...

2015-07-08 Thread AndyChenW
Github user AndyChenW commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119817738 device.isVirtual +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

RE: Cordova July Hangout

2015-07-08 Thread tommy-carlos williams
Thanks, Nikhil. Looking forward to it. --  tommy-carlos williams On 9 July 2015 at 08:18:24, Nikhil Khandelwal (nikhi...@microsoft.com) wrote: I'm closing the doodle now. Thursday July 16th 12 - 2 PM PST has the maximum folks. Please add it to your calendars. I will send out a hangout link

Re: [CI] iOS bugs found

2015-07-08 Thread Shazron
Made whitelist changes to mobilespec and added the whitelist plugin. I think these issues should be resolved but a build are not triggered, how I can I trigger an iOS build? On Mon, Jun 29, 2015 at 9:18 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, We’ve seen two issues pop up

Re: [iOS 4.x] cordova-plugin-whitelist deficiencies

2015-07-08 Thread Shazron
The docs mention access SHOULD be supported, but CSP is the way to go. Therefore access needs to be supported on iOS for native code requests (see failing FileTransfer tests CB-9329) since CSP is only in the context of the UIWebView. This is duplication of definitions unless we

[GitHub] cordova-plugin-globalization pull request: CB-9336 Fix Globalizati...

2015-07-08 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/38 CB-9336 Fix Globalization plugin init on Windows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-9336) You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-device pull request: add is_simulator for iOS And...

2015-07-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119703244 This looks good, I will look at adding it to windows+wp8 Please change the new property to `isSimulator` instead of `is_simulator`. --- If your