Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/198#issuecomment-122826854
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/197#issuecomment-122842603
LGTM. Not sure, why this submitted against `3.7.x` branch, cherry-picked it
to master.
Also, if you're going to contribute to Apache projects,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/186#issuecomment-122836685
LGTM. The build seems to fail due to some Travis internal issues with
Android SDK.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/29#issuecomment-122859132
can you please close this? You have opened a pull request
If you have problem using the plugin ask on stackoverflow or the phonegap
google
GitHub user davidmweber opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/110
Fix crash on browser window close
This fixes references to webView delegates on deallocation to prevent
crashes in iOS apps. It is particularly a problem when opening and
GitHub user Sergioo2 opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/29
Does it works on the device?
Hi,
I have a problem with this plugin, it works on the iOS emulator (iOS 8.2)
but doesn't works on the device.. could you help me?
Github user Sergioo2 closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/199#issuecomment-122875696
Created JIRA: https://issues.apache.org/jira/browse/CB-9391
LGTM, merging. @mlegenhausen, if you're going to contribute to Apache
projects,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/200#issuecomment-122876504
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user eweap opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/7
Typo: Remove duplicate word
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eweap/cordova-plugin-whitelist patch-1
Alternatively
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/184#issuecomment-122891112
Created JIRA: https://issues.apache.org/jira/browse/CB-9392
LGTM. @oNaiPs, please sign Apache's Contributor License Agreement (can be
done
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
I've taken a look on a popular plugins:
Proposed fix for Facebook:
https://github.com/Wizcorp/phonegap-facebook-plugin/pull/1032
Reviewed and voted for corresponding fix for PushPlugin:
https://github.com/phonegap-build/PushPlugin/pull/588
Reported this issue to Local Notification plugin
Github user athibaud commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-122946563
:wave:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
We chatted briefly about this at the hangout last week, and I wanted to
continue on the discussion. I gave the example that the Quirks section of
CameraOptions [1] is longer than the actual API documentation. I like to pick
on the Camera plugin because it's one of the most-used and is very
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-registry-web/pull/29
Modularize code and faster search experience
Refactored the codebase to be more modular, which fits with the reactjs
class/components concept.
Also rewrote `searchbar.jsx`
Github user omefire commented on the pull request:
https://github.com/apache/cordova-android/pull/200#issuecomment-122991020
Why don't we set keepRunning to true here ?
We seem to want to set keepRunning to false while still allowing things to
run in the background under certain
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user ielcoro opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/126
Prevent passing encoded URIS to native fs apis
The current implementation of FileProxy.js passes encoded URIs to native
filesystem apis, causing problems when handling files and
Please review and vote on this 4.1.0 Android Release by replying to this email
(and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-9394
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-9394
Note that
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
+1 to CSP as the right way to do it.
This all sounds very similar to what we ended up doing with the Android
whitelist plugins: Default is (ugh) *, and the strong recommendation is to
use CSP to actually filter requests from the WebView.
On Mon, Jul 20, 2015 at 7:24 PM, Shazron shaz...@gmail.com
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/commit/d8f491b0e47f47e44e41697e5fd9781fdd1b29b7#commitcomment-12265211
For you @omefire !
---
If your project is set up for it, you can reply to this email and have your
reply appear on
I am sick of seeing my commits cause build CI failures because of single vs
double quote use.
Can we relax this condition? I absolutely disagree with this being an error!
Cheers,
Jesse
My team is hiring!
@purplecabbage
risingj.com
I vote +1:
* Ran mobile-spec against the platform
* Verified the signatures and hashes using coho
On Mon, Jul 20, 2015 at 12:44 PM Nikhil Khandelwal nikhi...@microsoft.com
wrote:
Please review and vote on this 4.1.0 Android Release by replying to this
email (and keep discussion on the DISCUSS
I'm not certain that this makes sense, but anyway...
If a user is using CSP can we tell them to specify a single '*' entry for the
network request whitelist (a.k.a. access tags)?
If they are not using CSP, in spite of our recommendation, do the access
tags provide an alternative, though
I assume this is for the new whitelist plugin as opposed to the legacy
whitelist plugin which will continue to use the current access tags.
Another alternative, but not necessarily better, would be to default
the new whitelist plugin to a 'wildcard' network request list until the
user adds any
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user oNaiPs commented on the pull request:
https://github.com/apache/cordova-android/pull/184#issuecomment-123074385
@vladimir-kotikov signed and sent ICLA.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
1. If a user is using CSP can we tell them to specify a single '*' entry
for the network request whitelist (a.k.a. access tags)?
We could. But comes back to my point, why recommend *two* ways, it's just
confusing -- especially if we recommend CSP and require an access
wildcard. What I'm proposing
Ah I forgot about the legacy whitelist plugin -- we can't remove the
whitelist totally then, but as you said default
the new whitelist plugin to a 'wildcard' network request list until the
user adds any entries.
That will preserve backwards compat.
On Mon, Jul 20, 2015 at 4:18 PM, Treggiari, Leo
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-registry-web/pull/29#issuecomment-123100212
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
37 matches
Mail list logo
