Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread julio cesar sanchez
+1 to Joe, this update is 4.1.0 (major version bump) because the support for API Level 10 was removed BTW, Carlos, I've seen that you changed the issue priority from Minor to Critical, I set it to Minor because there is an easy workaround, just tell the user to add the android-minSdkVersion prefer

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126570699 Running `cordova prepare` fixes the order for me too, thanks for the tip @jcesarmobile. --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Joe Bowser
Enhance update script and notify user. We do not support API Level 10. On Thu, Jul 30, 2015, 8:49 PM Carlos Santana wrote: > Is still not clear to me what's the proper fix, to revert back both minsdk > to level 10, or enhance update script to check if app minsdk have lower > level than 14 makin

Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Carlos Santana
Is still not clear to me what's the proper fix, to revert back both minsdk to level 10, or enhance update script to check if app minsdk have lower level than 14 making incompatible with new cordovalib and update it to 14 for the user? On Thu, Jul 30, 2015 at 9:57 PM Murat Sutunc wrote: > Good ca

Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Murat Sutunc
Good catch! +1 on 4.1.1 > On Jul 30, 2015, at 6:41 PM, Steven Gill wrote: > > +1. I can get a vote out for it tomorrow >> On Jul 30, 2015 6:20 PM, "Carlos Santana" wrote: >> >> I think we need to fix and release a 4.1.1 this CB-9428 fixed before new >> cordova-cli get's released. >> >> the up

Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Steven Gill
+1. I can get a vote out for it tomorrow On Jul 30, 2015 6:20 PM, "Carlos Santana" wrote: > I think we need to fix and release a 4.1.1 this CB-9428 fixed before new > cordova-cli get's released. > > the update logic lives in the platform update script, not the cordova cli > > https://issues.apach

cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Carlos Santana
I think we need to fix and release a 4.1.1 this CB-9428 fixed before new cordova-cli get's released. the update logic lives in the platform update script, not the cordova cli https://issues.apache.org/jira/browse/CB-9428 basically doing an upgrade today like "cordova platform update android@4.1.

[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/298#discussion_r35933864 --- Diff: docs/en/edge/guide/platforms/win8/index.md --- @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/106#issuecomment-126521787 I'm game. Let's make a Jira for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/106#issuecomment-126521511 Ah makes sense - thanks. At what point can we remove this code from cordova-lib - not sure if support for older project template is that relevant now? We could

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/106#issuecomment-126520990 It only goes into the case if it's an "old project template." This change is only expected for newer Cordova projects. (src/cordova/metadata/windows_parser.

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/106#issuecomment-126520317 @robpaveza - Did you get a chance to look at the comment I mentioned? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/266#issuecomment-126519728 Thinking about it - wonder if you can add test case for this to prevent future regression. It's really a basic use case here. --- If your project is set up for it

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/266#issuecomment-126516900 @nikhilkh , it's ready to be merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/298#discussion_r35931879 --- Diff: docs/en/edge/guide/platforms/win8/index.md --- @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/266#issuecomment-126516413 @omefire - Is this ready to be merged? It will be good to get this merged before the next cordova-lib release. --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/298#discussion_r35931710 --- Diff: docs/en/edge/guide/platforms/win8/index.md --- @@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The Cordova CLI relies

[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/106#issuecomment-126515663 cordova-lib does some replacement using the `displayname` and it might not work with this change. I'm not tally familiar with what cordova-lib is doing - but w

[GitHub] cordova-windows pull request: CB-9408: Added a `windows-packageVer...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...

2015-07-30 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-js/pull/123#issuecomment-126489678 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126487866 BTW, I checked what you commented about the default value not being the first one, and it isn't the first one when you add the platform, but as soo

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126475712 Sorry, I proposed this change because I didn't know the reason for the default preferences. I'm closing CB-9076 now. Please @miscer, close

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126447487 Okay, then it is cordova-lib specific, or platform specific. But still it is not specific to this plugin, and this pull request does not address

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-30 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/110#issuecomment-126443320 I think the logic has to stay in onClick event for easy cleanup purposes. I've made the event handlers seperate functions. It's much cleaner now. --- I

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126413242 It happens even without adding a plugin, if you put one of the default preferences with another value, both will show (see CB-9264) --- If your p

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126395802 The issue is plugman specific and just happens to show up here. Create a jira for 'Cordova plugin add ' creates duplicate config preferences.

Re: org.apache.cordova.camera: Selecting the front-facing camera on Android

2015-07-30 Thread Joe Bowser
It's not guaranteed to work and it doesn't work past 2.3. On Thu, Jul 30, 2015, 8:49 AM Anders Borg (Abiro) wrote: > The Android API does have support for forcing (or maybe gently suggest) > that > the front-facing camera should be used if available, supposedly since 2.3. > > The documentation f

org.apache.cordova.camera: Selecting the front-facing camera on Android

2015-07-30 Thread Anders Borg (Abiro)
The Android API does have support for forcing (or maybe gently suggest) that the front-facing camera should be used if available, supposedly since 2.3. The documentation for the plugin specifically says nothing will happen, and I've checked that it's true, so ipso facto. Any hard reason this woul

[GitHub] cordova-plugin-file pull request: Make Android default persistent ...

2015-07-30 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-126341456 @purplecabbage we make developers migrate the files if they want to go through the trouble. If they don't want to do that they can always get the old beha

[GitHub] cordova-lib pull request: CB-9407 FFOS permissions missing in mani...

2015-07-30 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-lib/pull/274 CB-9407 FFOS permissions missing in manifest CB-9407 running an update on platform_cfg allows permissions from plugins to feed the manifest. You can merge this pull request into a Git reposi

Issue with firefoxos permission

2015-07-30 Thread Piotr Zalewa
https://issues.apache.org/jira/browse/CB-9407 For some reason permission is an empty array config.doc.findall('permission'); https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js#L134 although the permission exists in ``this.config_path``

RE: [DISCUSS] cordova-ios 3.9.0 release

2015-07-30 Thread Sergey Grebnov (Akvelon)
Release blog post for review: https://github.com/cordova/apache-blog-posts/pull/42 Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Monday, July 27, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Please review prepared release

[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-30 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-medic/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126208513 Ok, I'll take a look, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126207327 Yes, it does ignore the first preference, but sometimes the default value from plugin.xml is not first, but second in the code. In my case it happened w

[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126205747 Hi, I told you on the JIRA page that I could reproduce the preference being duplicated, but I couldn't reproduce your problem, in my tests it ignor