Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user devgeeks opened a pull request:
https://github.com/apache/cordova-android/pull/206
CB-9496 removed permissions added for crosswalk
These would better live in the actual crosswalk plugin
https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-131553995
I feel like the plugman changes ( `run_hooks` ) should be part of a
separate pull request.
---
If your project is set up for it, you can reply to this email and ha
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146091
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -81,12 +81,6 @@ describe('HooksRunner', function() {
process.chdir(path.join(__
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146081
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37146073
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -357,7 +356,7 @@ function runInstall(actions, platform, project_dir,
plugin_dir, plugins_dir, opt
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145990
--- Diff: cordova-lib/src/hooks/scriptsFinder.js ---
@@ -105,6 +105,11 @@ function getApplicationHookScriptsFromDir(dir) {
*/
function getScrip
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145607
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -80,6 +96,15 @@ HooksRunner.prototype.prepareOptions = function(opts) {
return opts;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r37145507
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -60,11 +64,23 @@ HooksRunner.prototype.fire = function fire(hook, opts) {
};
/**
GitHub user nourshamrok opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/114
save data and metadata to disk to photos when use usesGeolocation is enabled
save data and metadata to disk to photos when use usesGeolocation is enabled
i fix the bug
You c
10 matches
Mail list logo
