Re: Marshmallow Update and Cordova-Android 5.0

Hi Joe, I tested your patch and it works for the most part using mobilespec's manual test for contacts. I do see the prompt for permissions contacts, but not explicitly to read or write contacts like you mentioned. One thing that doesn't work is if you click "Deny" permission, the app crashes. I

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659073 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659458 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/219#issuecomment-137487656 Thanks! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38659317 --- Diff: README.md --- @@ -113,7 +113,9 @@ Vibrates the device with a given pattern Windows Quirks --

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#issuecomment-137486956 Should any mobilespec tests be updated now that this is supported for Windows? Or is mobilespec not testing this because its not supported on

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669813 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

Re: [VOTE] 3.8.0 BlackBerry Release (take 2)

+1 On Wed, Sep 2, 2015 at 2:39 PM, Tim Windsor wrote: > +1 (non-PMC member) > > Tested: > - new project creation, platform add and build to device. > - webworks-cli (3.6.0) new project creation, update to 3.8.0 and deploy to > device > - new cordova project, add

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/64#issuecomment-137533398 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/329#issuecomment-137551154 It lives! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/329#issuecomment-137541650 GitHub has fallen out of sync with ASF Git. ): --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-media pull request: CB-9606 Fixes arguments parsing...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/65#issuecomment-137535688 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/329#issuecomment-137535292 Wow, thanks! Merge away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Marshmallow Update and Cordova-Android 5.0

On Thu, Sep 3, 2015 at 8:07 AM Karen Tran wrote: > Hi Joe, > > I tested your patch and it works for the most part using mobilespec's > manual test for contacts. I do see the prompt for permissions contacts, but > not explicitly to read or write contacts like you mentioned. > >

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669919 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38670056 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

Re: [Vote] Tools Release Aug 28th

The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Tim Barham Sergey Grebnov The vote has passed. I will publish to dist. I'll wait until after the blackberry release to set to latest on npm. On Tue, Sep 1, 2015 at 2:29 AM, Sergey Grebnov (Akvelon) <

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-137558561 Hi Paulo, Please sign an ICLA as explained here: http://cordova.apache.org/#contribute --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-media pull request: Update index.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: iOS 9 data-rel back not working - known issue?

Can you verify that jQuery+jQM function correctly? Since iOS9 is not out yet, we don't have a lot of details for you. There are currently no known issues related to this. Also, this list is for cordova development itself, not for development questions using cordova. You should try

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-137579131 rebase or close please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media pull request: Added parameter for additional ...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/24#issuecomment-137575541 Hi Simon, Please file a ICLA and a JIRA Ticket. You will need to rebase as well. We will have to close this soon otherwise. --- If your

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-9079 Increased timeout for p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

Github user appjitsu commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-137566856 remove/add works for me on mac --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

iOS 9 data-rel back not working - known issue?

Hi, I have an app that is going to be shipped to my client next week. He reported to me that the back button in the navigation bar (anchor with data-rel="back") is not working. I downloaded the XCode Beta with iOS 9 and it's true. It's working fine on other versions.Is that a known issue, or at

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546 Looks good. However there is another chance to access `this._config` before it will be initialized:

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/293#issuecomment-13732 Yes, i didn't found any 'browser'-specific things to check too. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-media/pull/64 CB-9605 Fixes issue with playback resume after pause on WP8 This fixes [CB-9605](https://issues.apache.org/jira/browse/CB-9605) In case of playing remote file,

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: CB-9606 Fixes arguments parsing...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-media/pull/65 CB-9606 Fixes arguments parsing in `seekAudio` This fixes [CB-9606](https://issues.apache.org/jira/browse/CB-9606) You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795 @stevengill Can you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: Fixing license headers in all Markdown ...

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/329 Fixing license headers in all Markdown files. Some files had partially translated or overflowing and malformed license headers. This commit fixes all of them to use the text of the Apache

[GitHub] cordova-docs pull request: Merging files.

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/330 Merging files. Obeying all `config.json` files, merged all files into their specified destinations. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

Github user daserge closed the pull request at: https://github.com/apache/cordova-cli/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/219#issuecomment-137405643 @stevengill, @nikhilkh, Verified (works OK) and documented the ways to disable updates check, please take a look. --- If your project is set up for it, you

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

GitHub user daserge reopened a pull request: https://github.com/apache/cordova-cli/pull/219 CB-9523 Show out of date message for older cordova CLI Used [update-notifier](https://github.com/yeoman/update-notifier) module You can merge this pull request into a Git repository by

[GitHub] cordova-docs pull request: Merging files.

Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-137588661 Closing due to age --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

Github user vldmrrr closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-137591772 Great news. I will send you the pdf in the next days. cheers --- If your project is set up for it, you can reply to this email and have your reply

[REVIEW] CPR readonly blog post.

Please review. https://github.com/cordova/apache-blog-posts/blob/master/2015-09-03-CPR-readonly.md Anything else I should add? -Steve

Re: [REVIEW] CPR readonly blog post.

Looks good. Spelling "swithed" On Thu, Sep 3, 2015 at 5:14 PM, Steven Gill wrote: > Please review. > > https://github.com/cordova/apache-blog-posts/blob/master/2015-09-03-CPR-readonly.md > > Anything else I should add? > > -Steve >

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-137600450 I'll review them next week (off tomorrow). Thanks for the ping. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: Merging all specified merges.

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/331 Merging all specified merges. Obeying all config.json files, merged all files into their specified destinations. You can merge this pull request into a Git repository by running: $ git

Re: [REVIEW] CPR readonly blog post.

Replace "read-only" , it's soo 2014 Use "immutable" sounds more hipster :-) Other than that looks good to me, I notice you don't mentioned plugman cli. I think is OK to make general use to be cordova cli. - Carlos Sent from my iPhone > On Sep 3, 2015, at 8:27 PM, Shazron

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function

Github user cojomojo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-137577342 Is this PR still being considered? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: iOS 9 data-rel back not working - known issue?

data-rel="back" is a jquery mobile thing, right? Then it might be a jquery mobile issue. El 3/9/2015 23:27, "Cem Yesil" escribió: > Hi, > I have an app that is going to be shipped to my client next week. He > reported to me that the back button in the navigation bar (anchor

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38723211 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38723140 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-docs pull request: Merging all specified merges.

Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the